> > In these cases, I think it would look nicer to put the *s and the @j0's 
> > on .owner rather than at the start of the structure.
> 
> Is this a manual fix or a fix to sgen?

I asked Chi whether it could be done automatically, but I would suggest to 
do it manually for the moment.

> > Unless there is some situation in which the transformation is not 
> > required, I think High confidence would be appropriate.
> 
> The calls I check for always set .owner. So it should be 'high', I'd
> guess. However, if the behavioue of these calls are ever to be changed
> there is a risk that this spatch gets not updated. More like a general
> problem, though, which does not really influence the confidence.

If there are concerns, you can add the relevant information in the 
comments at the top.

julia

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Reply via email to