> You would need when any on the ... Otherwise, it will not match anything
> (perhaps declarations). The s1 after is precludes matching any statement.
> Likewise in the next if.
The suggested variant does still not work in the way I would expect it.
@duplicated_code@
identifier work;
statement s1, s2;
type T;
@@
T work(...)
{
... when any
*if ((...) < 0)
*{
... when any
* s1
* s2
*}
<+...
*if ((...) < 0)
*{
... when any
* s1
* s2
*}
...+>
}
I got some promising test results from the following SmPL approach.
@duplicated_code@
identifier work;
statement s1, s2;
type T;
@@
T work(...)
{
... when any
*if ((...) < 0)
*{
... when any
* s1
* s2
*}
... when any
*if ((...) < 0)
*{
... when any
* s1
* s2
*}
... when any
}
elfring@Sonne:~/Projekte/Linux/next-patched> XX=$(date) && spatch.opt --timeout
12 --sp-file ~/Projekte/Coccinelle/janitor/show_same_statements3b.cocci --dir
sound >
~/Projekte/Bau/Linux/scripts/Coccinelle/tuning1/next/20170803/same_statements3b.diff
2>
~/Projekte/Bau/Linux/scripts/Coccinelle/tuning1/next/20170803/same_statements3b-errors.txt;
YY=$(date) && echo "$XX | $YY"
Mi 23. Aug 17:25:54 CEST 2017 | Mi 23. Aug 17:29:15 CEST 2017
How should the source code search be improved further here?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
