On Mon, 13 May 2019, Markus Elfring wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Tue, 7 May 2019 11:20:48 +0200
>
> The Linux coding style tolerates long string literals so that
> the provided information can be easier found also by search tools
> like grep.
> Thus simplify a message construction in a SmPL rule by concatenating text
> with two plus operators less.
I don't know python very well. Is there any way to unindent, so that the
string doesn't exceed 80 characters, or at least no so much?
On the other hand, I would have much preferred the original msg = code. I
don't understand why it is so offensive.
julia
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
> ---
> scripts/coccinelle/free/put_device.cocci | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/coccinelle/free/put_device.cocci
> b/scripts/coccinelle/free/put_device.cocci
> index c9f071b0a0ab..3ebebc064f10 100644
> --- a/scripts/coccinelle/free/put_device.cocci
> +++ b/scripts/coccinelle/free/put_device.cocci
> @@ -42,11 +42,10 @@ p1 << search.p1;
> p2 << search.p2;
> @@
>
> -coccilib.report.print_report(p2[0], "ERROR: missing put_device; "
> - + "call of_find_device_by_node on line "
> - + p1[0].line
> - + ", but without a corresponding object release "
> - + "within this function.")
> +coccilib.report.print_report(p2[0],
> + "ERROR: missing put_device; call
> of_find_device_by_node on line "
> + + p1[0].line
> + + ", but without a corresponding object release
> within this function.")
>
> @script:python depends on org@
> p1 << search.p1;
> --
> 2.21.0
>
>
