>> Combine the exclusion specifications into a disjunction for the semantic
>> patch language so that this argument is referenced only once there.
…
> NACK. This hurts readability
I suggest to reconsider such readability concerns once more.
Can corresponding software limitations be adjusted any further?
> and gives no practical benefit.
I guess that you know better which aspects can matter also here
for software fine-tuning.
>> +++ b/scripts/coccinelle/free/put_device.cocci
>> @@ -22,8 +22,7 @@ id = of_find_device_by_node@p1(x)
>> if (id == NULL || ...) { ... return ...; }
>> ... when != put_device(&id->dev)
>> when != id = (T6)(e)
>> - when != platform_device_put(id)
>> - when != of_dev_put(id)
>> + when != \( platform_device_put \| of_dev_put \) (id)
Can the reduction of a bit of duplicate SmPL code result in nicer
run time characteristics?
Regards,
Markus
