From: Markus Elfring <[email protected]> Date: Wed, 25 Sep 2019 11:55:24 +0200
Values from expressions were occasionally assigned to local variables before they will be returned by the subsequent statement. Such expressions can be directly specified in the return statement instead. Adjust affected source code by the means of the semantic patch language (Coccinelle software). Signed-off-by: Markus Elfring <[email protected]> --- .../coccinelle/misc/move_code_to_return.cocci | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 scripts/coccinelle/misc/move_code_to_return.cocci diff --git a/scripts/coccinelle/misc/move_code_to_return.cocci b/scripts/coccinelle/misc/move_code_to_return.cocci new file mode 100644 index 000000000000..78cdf84f9aaa --- /dev/null +++ b/scripts/coccinelle/misc/move_code_to_return.cocci @@ -0,0 +1,67 @@ +// SPDX-License-Identifier: GPL-2.0 +/// Return expressions directly instead of assigning them to +/// local variables immediately before affected statements. +// +// Keywords: return statements variable assignments coding style +// Confidence: Medium + +virtual patch + +@replacement1 depends on patch@ +expression x; +identifier f, rc; +local idexpression lrc; +type rt; +@@ + rt f(...) + { + ... when any + if (...) +-{ +-lrc@rc = x; + return +- rc ++ x + ; +-} + ... when any + } + +@replacement2 depends on patch@ +expression x; +identifier f, rc; +local idexpression lrc; +type rt; +@@ + rt f(...) + { + ... when any +-lrc@rc = x; + return +- rc ++ x + ; + ... when any + } + +@deletion2 depends on patch@ +identifier replacement2.f, replacement2.rc; +type replacement2.rt, t; +@@ + rt f(...) + { + ... when any +-t rc; + ... when != rc + } + +@deletion1 depends on patch@ +identifier replacement1.f, replacement1.rc; +type replacement1.rt, t; +@@ + rt f(...) + { + ... when any +-t rc; + ... when != rc + } -- 2.23.0 _______________________________________________ Cocci mailing list [email protected] https://systeme.lip6.fr/mailman/listinfo/cocci
