On Mon, 4 Nov 2019, Markus Elfring wrote:
> Hello,
>
> I have tried the following small script variant out for
> the semantic patch language.
>
> @adjustment@
> type T, T2;
> expression x,E1,E2,E3,E4;
> statement S;
> @@
> (
> - x = kmalloc(E1,E2);
> + x = kzalloc(E1,E2);
> |
> x = (T)dma_alloc_coherent(E2,E1,E3,E4);
> )
> if ((x==NULL) || ...) S
> - memset((T2)x,0,E1);
>
>
> It can generate an usable diff hunk.
>
> elfring@Sonne:~/Projekte/Linux/next-patched> spatch
> scripts/coccinelle/api/alloc/zalloc-simple-x.cocci drivers/scsi/pmcraid.c
>
>
> But I would like to add the last case distinction also to a similar
> disjunction in the known (and discussed) SmPL script version.
What is "the known (and discussed) SmPL script version"?
> I observe that the expected diff hunk is not provided then.
> How would you like to fix this software situation?
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
