> There is a block of if tests against the same variable
> in include/linux/mtd/pfow.h that likely is defective

I wonder about this interpretation.


> Likely the first test should be something like
>
>       if ((prog_status & 0x03) == 0x03)

Why would you prefer such a code variant?


> Is there a way for cocci to find this style of bitwise logic defect?

* Probably, yes.

* How often will this implementation detail really be a “defect”?

* Where do you stumble on difficulties to express a corresponding source code
  search pattern by the means of the semantic patch language?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Reply via email to