On Thu, 2020-12-31 at 21:27 +0100, Julia Lawall wrote: > On Thu, 31 Dec 2020, Joe Perches wrote: > > On Thu, 2020-12-31 at 11:04 -0800, Joe Perches wrote: > > > strlcpy is deprecated. see: Documentation/process/deprecated.rst > > > > > > Change the calls that do not use the strlcpy return value to the > > > preferred strscpy. > > > > > > Done with cocci script: > > > > > > @@ > > > expression e1, e2, e3; > > > @@ > > > > > > - strlcpy( > > > + strscpy( > > > e1, e2, e3); > > > > > > This cocci script leaves the instances where the return value is > > > used unchanged. > > > > Hey Julia. > > > > After using the cocci script above on a test treewide conversion, > > there were a few instances with no return use that were not converted. > > > > Any idea why these were not converted? [] > The parse is not happy about the for_each_possible_cpu. It seems that the > heuristic for detecting that as a loop expects that the body of the loop > will have braces. You can see this with the --parse-c option, ie > > spatch --parse-c drivers/block/rnbd/rnbd-clt.c > > The offending line will have BAD in front of it.
Thanks. Do you consider the for_each heuristic a defect? (I'm not sure I do) I hope it's time for you to stop working today... cheers and happy new year, Joe _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
