On Aug 10, 2009, at 11:04 PM, Uli Kusterer wrote:

On Aug 8, 2009, at 3:30 AM, Kirk Swenson wrote:

- (id) windowWillReturnFieldEditor: (NSWindow*) aWindow toObject: (id) anObject
{
// myTextFieldEditor is a member variable, so there will only be one of them.
        if( myTextFieldEditor == nil) {
                myTextFieldEditor = [[MyTextView alloc] init];

Isn't that missing an autorelease? Or is this documented as an exception somewhere? Looks like you're leaking a text view each time this is called.

As the comment suggests, myTextFieldEditor is an instance variable. It's released in the dealloc method. It's worth pointing out that according to the documentation, "This method may be called multiple times while a control is first responder. Therefore, you must return the same field editor object for the control while the control is being edited." In other words, the pointer has to be cached -- creating a new one on every call would violate the requirements of the method.

Kirk Swenson
Senior Software Engineer
KCP Technologies

_______________________________________________

Cocoa-dev mailing list (Cocoa-dev@lists.apple.com)

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com

This email sent to arch...@mail-archive.com

Reply via email to