On May 10, 2012, at 8:54 AM, Ken Thomases <[email protected]> wrote:
> On May 10, 2012, at 1:07 AM, Roland King wrote:
>> My confusion comes from not knowing whether this function now returns an 
>> object with a +1 refcount or not. If it does it needs to be renamed to have 
>> new or copy etc in the method name, or annotated properly to show that.
> 
> I think you have this backward.  You are giving ownership over to ARC.  ARC 
> decides what to do in part based on the method name.  You don't pick the 
> method name to match the behavior you anticipate from ARC, ARC picks its 
> behavior based on the name, which should reflect your chosen semantics.
> 
> Since your method name doesn't indicate that it returns ownership, ARC will 
> autorelease the value.  [If the caller is also compiled with ARC, then it 
> hardly matters.  It will decide how to behave also based on the method name 
> and the two behaviors will complement each other (and, depending on 
> optimizations, cancel out so that neither an autorelease nor a retain 
> happens).  If the caller is MRC, then ARC autoreleasing the return value is, 
> of course, important given your method name.]

This logic is clearer if you use the CFBridgingRetain() and CFBridgingRelease() 
functions instead of the __bridge_retained and __bridge_transfer casts:

        +(NSString*)webEncodedString:(NSString *)string
        {
                CFStringRef retval = CFURLCreateStringByAddingPercentEscapes( 
NULL, (__bridge CFStringRef)string, NULL, CFSTR( "!*'();:@&=+$,/?%#[]" ), 
kCFStringEncodingUTF8 );
                return CFBridgingRelease(retval);
        }

CFBridgingRelease() balances CFURLCreateString...(). Everything else is ARC's 
problem as usual.


-- 
Greg Parker     [email protected]     Runtime Wrangler



_______________________________________________

Cocoa-dev mailing list ([email protected])

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com

This email sent to [email protected]

Reply via email to