Carsten Ziegeler wrote:
> Torsten Curdt wrote:
>
>>So.... should we upgrade cocoon to LogEnabled?
>>
>>a) only HEAD
>>b) HEAD and 2.0
>>
>>
> I think we should forget the 2.0 branch as soon as possible, so
> changing a) is sufficient.
>
> Before we vote on it, can you identify what really has to be
> changed?
>>From my memory there is at least this:
>
> a) All components must extend AbstractLogEnabled instead
> of AbstractLoggable.
> To be precise, this changes the interface
> of each component! As both solutions provide a getLogger() method
> which points to objects with similar interfaces this is not
> really a problem unless someone relies on this interface.
>
> b) There are other place where classes are tested against Loggable,
> these can not be changed that easy as someone might have developed own
> components which are either Loggable or LogEnabled.
> So at these places we have to support both! And that might be a
> problem as you need there both loggers.
The solution that Excalibur came up with for the ExcaliburTestCase
(used for testing Avalon Components) is to provide two methods:
getLogger() returns the Loggable version
getLogEnabledLogger() returns the LogEnabled version
Keep in mind that ExcaliburComponentManager can detect which Component
uses which interface, and therefore give you protection from backwards
incompatibility...
> There might be other places as well.
>
> If noone sees a problem in a) and b) can be solved and there are
> no other interface changes required, I'm +1 on this.
>
>
>>I volunteer to do it...
>>
> Great!
>
> Carsten
>
>>--
>>Torsten
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: [EMAIL PROTECTED]
>>For additional commands, email: [EMAIL PROTECTED]
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, email: [EMAIL PROTECTED]
>
> .
>
>
--
"They that give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety."
- Benjamin Franklin
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
