Great edge case, thanks for sharing that one!

I think currently that could only be _encoded_ as a separate opening in the CSV 
file for loading into the database, which won't work because of my assumption. 
There simply isn't a way to express it. The relevant fields for the load file 
are startdate, enddate, opentime, and closetime, the last two being formatted 
as only "hh:mm", so it's assumed they relate to each single day in the range.

However, I edited a "closes" field value directly in the test database, and to 
my surprise it rendered sensibly. I would have thought it would be rejected by 
a validity test I have which checks that the day portion of the start and 
closing datestamps are the same [1].

I can't justify spending time on this in the near future, since it's a use case 
we are unlikely to need here. However, I'll log an issue, or you may. Thanks 
again.

Cheers
Hugh

[1] https://github.com/LincolnUniLTL/calibr/blob/master/lib/app.php#L113

-----Original Message-----
From: Code for Libraries [mailto:CODE4LIB@LISTSERV.ND.EDU] On Behalf Of Bohyun 
Kim
Sent: Wednesday, 27 November 2013 11:28 a.m.
To: CODE4LIB@LISTSERV.ND.EDU
Subject: Re: [CODE4LIB] calibr: a simple opening hours calendar

Hugh,

Thanks for sharing. A quick question. If a library opens past midnight, does 
that count more than one opening a day or no?

~Bohyun


On Nov 26, 2013, at 5:04 PM, "Barnes, Hugh" <hugh.bar...@lincoln.ac.nz> wrote:

> Hi folks
> 
> I took a calendar script posted to this list by Andrew Darby some time ago 
> and made some changes. I don't think there is any of Andrew's code left, so 
> I've rebranded it with an acknowledgement. (If I had my time again, I might 
> have coded it from scratch rather than built it over Andrew's script, but 
> that's somewhat academic.)
> 
> The whole scoop is in the readme on Github: 
> http://github.com/LincolnUniLTL/calibr
> 
> TLDR: With PHP, MySQL, some fiddling and data entry, you can publish a 
> library opening hours calendar on your website in more than one language if 
> you wish. It's a little quicker to enter common period patterns than it used 
> to be in Google Calendar. The output is more accessible, customisable, 
> multilingual, semantic, and hopefully more extensible (iCal etc) than 
> previously.
> 
> Here's a branded reference implementation: 
> http://library2.lincoln.ac.nz/hours - it won't necessarily reflect the latest 
> version.
> 
> Use it, improve it, feed back, or log issues right there on Github if that 
> works for you.
> 
> Many thanks to Andrew for providing the foundation!
> 
> Cheers
> 
> Hugh Barnes
> Digital Access Coordinator
> Library, Teaching and Learning
> Lincoln University
> Christchurch
> New Zealand
> p +64 3 423 0357
> 
> 
> 
> ________________________________
> P Please consider the environment before you print this email.
> "The contents of this e-mail (including any attachments) may be confidential 
> and/or subject to copyright. Any unauthorised use, distribution, or copying 
> of the contents is expressly prohibited. If you have received this e-mail in 
> error, please advise the sender by return e-mail or telephone and then delete 
> this e-mail together with all attachments from your system."

Reply via email to