Hi there, I've been looking at the ban code in ircu (urgh!) and have noticed a potential problem with the way bans are handled.
This first came to my attention due to the QuakeNet "sethost" feature. If you use SETHOST to alter your host to "127.0.0.1", you effectively cannot be banned from channels, since a ban of "*!*@127.0.0.1" will be treated as an IP ban and thus checked against your real IP address, not the fake host. This is fine (QuakeNet feature, QuakeNet problem) but there are real cases where a ban containing only numbers and wildcards might reasonable match hostnames and not IP addresses, e.g. a ban of "*27*" won't match a user whose host is "host27.someisp.net", (unless their IP address happened to contain "27" in it somewhere. IMO all bans should be checked against hostname regardless, and IP addresses as well if they CHFL_BAN_IPMASK set. It's a one line change so we'll probably do it in the qnet ircd anyway. Comments? Cheers, splidge QuakeNet person
