Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1311#discussion_r159497520
  
    --- Diff: win-odbc64/odbcclient/drvr35/sqltocconv.cpp ---
    @@ -36,6 +36,36 @@
     
     #define MAXCHARLEN 32768 //32K
     
    +// for server2008 when using function pow() then throws 
STATUS_ILLEGAL_INSTRUCTION
    +double pow(int base, short power, unsigned long *error)
    +{
    +   DWORD dwVersion = 0;
    +   DWORD dwBuild = 0;
    +
    +   dwVersion = GetVersion();
    +
    +   // Get the build number.
    +
    +   if (dwVersion < 0x80000000)
    +           dwBuild = (DWORD)(HIWORD(dwVersion));
    +
    +   double retValue = 1;
    --- End diff --
    
    Please consider setting *error to 0 here for non-error condition


---

Reply via email to