Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1612#discussion_r198262065
  
    --- Diff: core/sql/cli/SessionDefaults.cpp ---
    @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap 
sessionDefaultMap[] =
       SDEntry(SessionDefaults::SCHEMA,                   SCHEMA,               
      SessionDefaults::SDT_ASCII,          TRUE,    TRUE,  FALSE, FALSE),
       SDEntry(SessionDefaults::STATISTICS_VIEW_TYPE,     STATISTICS_VIEW_TYPE, 
      SessionDefaults::SDT_ASCII,          FALSE,   FALSE, TRUE,  TRUE),
       SDEntry(SessionDefaults::SUSPEND_LOGGING,          SUSPEND_LOGGING,      
      SessionDefaults::SDT_BOOLEAN,        FALSE,   FALSE, TRUE,  FALSE),
    +  SDEntry(SessionDefaults::USE_LIBHDFS,              USE_LIBHDFS,          
      SessionDefaults::SDT_BOOLEAN,        TRUE,    TRUE,  FALSE, FALSE),
    --- End diff --
    
    The CQD could have been passed in just like we pass in LOB_MAX_SIZE and 
LOB_MAX_MEM_CHUNK size but that makes the code a bit messy and Selva will need 
to change way too many interfaces. The CQD as SSD is a good choice for this 
particular case since it's a "setting".  It's better not to have it as an 
envvar since switching back and forth  will make it more difficult. 


---

Reply via email to