Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1665#discussion_r205606604
  
    --- Diff: core/sql/executor/ExSequence.cpp ---
    @@ -1487,7 +1487,35 @@ void ExSequenceTcb::updateDiagsArea(  ExeErrorCode 
rc_)
         }
         if (!da->contains((Lng32) -rc_))
         {
    -      *da << DgSqlCode(-rc_);
    +      char msg[512];
    --- End diff --
    
    It would be nice if you can encapsulate these changes in cluster_->flush(). 
The caller doesn't need to know  about the internals of cluster_


---

Reply via email to