Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221723122 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp --- @@ -9246,26 +9280,44 @@ short CmpSeabaseDDL::executeSeabaseDDL(DDLExpr * ddlExpr, ExprNode * ddlNode, // create seabase library StmtDDLCreateLibrary * createLibraryParseNode = ddlNode->castToStmtDDLNode()->castToStmtDDLCreateLibrary(); - - createSeabaseLibrary(createLibraryParseNode, currCatName, + if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF)) + createSeabaseLibrary(createLibraryParseNode, currCatName, currSchName); + else + { + + createSeabaseLibrary2(createLibraryParseNode, currCatName, + currSchName); + + + } } else if (ddlNode->getOperatorType() == DDL_DROP_LIBRARY) { // drop seabase library StmtDDLDropLibrary * dropLibraryParseNode = ddlNode->castToStmtDDLNode()->castToStmtDDLDropLibrary(); - - dropSeabaseLibrary(dropLibraryParseNode, currCatName, currSchName); + if( (CmpCommon::getDefault(USE_LIB_BLOB_STORE) == DF_OFF)) --- End diff -- Again, I would have expected that we don't look at this CQD when we drop a library. Shouldn't we look at the type of the library to determine what flavor to use?
---