Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225015107
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp ---
    @@ -1637,6 +1660,43 @@ short 
CmpSeabaseMDupgrade::executeSeabaseMDupgrade(CmpDDLwithStatusInfo *mdui,
               }
               break;
     
    +        case UPGRADE_LIBRARIES:
    +          {
    +             if (NOT isLibrariesUpgradeNeeded())
    +              {
    +                mdui->setStep(UPGRADE_PRIV_MGR);
    +                mdui->setSubstep(0);
    +                break;
    +              }
    +
    +            if (xnInProgress(&cliInterface))
    +              {
    +                *CmpCommon::diags() << DgSqlCode(-20123);
    +                
    +                mdui->setStep(UPGRADE_FAILED_RESTORE_OLD_REPOS);
    --- End diff --
    
    Should this message mention failure during upgrade library step?


---

Reply via email to