DaveBirdsall commented on a change in pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330712806
########## File path: core/sql/sqlcomp/nadefaults.cpp ########## @@ -3629,11 +3622,12 @@ void NADefaults::initCurrentDefaultsWithDefaultDefaults() } // End: Temporary workaround for SQL build regressions to pass - // Cache all the default keywords up front, // leaving other non-keyword token to be cached on demand. Review comment: Should this comment line (line 3625 in the new file) be deleted also? It doesn't make sense by itself. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
