Created Codestriker topic at:
http://codestriker.sourceforge.net/cgi-bin/codestriker.pl?topic=9009938&action=view
User: sits
Date: 05/05/25 01:00:16
Modified: html codestriker.js
template/en/default createtopic.html.tmpl search.html.tmpl
Log:
Modified help tooltips so that they are also sticky and centered,
so that they are consistent with all the other tooltips in the
application. This also works better under IE, where the tooltips
get displayed under combo boxes, which is what happens if you
display them right next to the (?) text.
Index: codestriker.js
===================================================================
RCS file: /cvsroot/codestriker/codestriker/html/codestriker.js,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- codestriker.js 24 May 2005 08:27:56 -0000 1.10
+++ codestriker.js 25 May 2005 08:00:13 -0000 1.11
@@ -294,6 +294,15 @@
HEIGHT, 300);
}
+// Create a new tooltip window which creates a sticky, draggable
+// window with a close link.
+function create_window(text)
+{
+ var html = '<a href="javascript:hideElt(getElt(\'overDiv\'));
void(0);">' +
+ 'Close</a><p>' + text;
+ overlib(html, STICKY, DRAGGABLE, ALTCUT, CENTERPOPUP);
+}
+
// Function for posting to Codestriker using the XMLHttpRequest object.
function postXMLDoc(params)
{
Index: createtopic.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/createtopic.html.tmpl,v
retrieving revision 1.42
retrieving revision 1.43
diff -u -r1.42 -r1.43
--- createtopic.html.tmpl 23 May 2005 11:54:00 -0000 1.42
+++ createtopic.html.tmpl 25 May 2005 08:00:15 -0000 1.43
@@ -31,10 +31,9 @@
[%# The topic title input field #%]
Topic title:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('The topic title should be a concise but \
+onmouseover="return create_window('The topic title should be a concise but \
informative summary of the code to be reviewed. The title is used in the \
-subject of sent emails, and in the topic list screen.');"
-onmouseout="return nd();">(?)</a></FONT>
+subject of sent emails, and in the topic list screen.');">(?)</a></FONT>
<BR>
<INPUT TYPE="text" NAME="topic_title" VALUE="[% topic_title | html_entity
%]" SIZE=70 MAXLENGTH=70>
<P>
@@ -42,12 +41,11 @@
[%# The topic description input field #%]
Topic description:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
The topic description should contain enough information \
for a reviewer to understand broadly what the code change \
achieves. This information is sent with the new topic \
-notification email to all reviewers.')"
-onmouseout="return nd();">(?)</a></FONT>
+notification email to all reviewers.')">(?)</a></FONT>
<BR>
<TEXTAREA NAME="topic_description" ROWS=12 COLS=70 WRAP="hard">[%
topic_description | html_entity %]</TEXTAREA>
<P>
@@ -67,7 +65,7 @@
<TR>
<TD>Topic text upload:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
The uploaded file contains the actual text of the review. \
Typically, the text is the output of a command such as: \
<p> \
@@ -81,8 +79,7 @@
but will be treated simply as \'new files\'. \
<p> \
This should be left blank if you are reviewing files \
-directly from a repository.')"
-onmouseout="return nd();">(?)</a></FONT>
+directly from a repository.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><INPUT TYPE="file" NAME="topic_file" VALUE="[% topic_file |
html_entity %]" SIZE=40 MAXLENGTH=200></TD>
</TR>
@@ -93,7 +90,7 @@
<TD>
Start tag:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Rather than uploading the topic text, if the repository \
supports it, the text can be fetched by querying the \
repository, given start and/or end tags, and a module name. \
@@ -101,14 +98,13 @@
is uploaded.<p> \
If only one tag value is specified, the full contents of all \
files in the specified module corresponding to the entered tag \
-will be downloaded.')"
-onmouseout="return nd();">(?)</a></FONT>
+will be downloaded.')">(?)</a></FONT>
</TD>
<TD>
<INPUT TYPE="text" NAME="start_tag" VALUE="[% start_tag | html_entity %]"
SIZE=20 MAXLENGTH=150>
</TD>
<TD>End tag: <FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Rather than uploading the topic text, if the repository \
supports it, the text can be fetched by querying the \
repository, given start and/or end tags, and a module name. \
@@ -116,8 +112,7 @@
is uploaded. <p> \
If only one tag value is specified, the full contents of all \
files in the specified module corresponding to the entered tag \
-will be downloaded.')"
-onmouseout="return nd();">(?)</A></FONT></TD>
+will be downloaded.')">(?)</A></FONT></TD>
<TD>
<INPUT TYPE="text" NAME="end_tag" VALUE="[% end_tag | html_entity %]"
SIZE=20 MAXLENGTH=150>
</TD>
@@ -127,10 +122,9 @@
<TD>
Module:
<FONT SIZE="-2"><A HREF="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
This is the path to the file or module relative to the repository \
-root that should be inspected. It is ignored if text is uploaded.')"
-onmouseout="return nd();")>(?)</a></FONT>
+root that should be inspected. It is ignored if text is
uploaded.')">(?)</a></FONT>
</TD>
<TD>
<INPUT TYPE="text" NAME="module" VALUE="[% module | html_entity %]" SIZE=20
MAXLENGTH=150>
@@ -142,12 +136,11 @@
[%# The default_to_head input field #%]
<TD>Default to HEAD:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Fall back to HEAD revision if a file does not exist on either tag. \
This will allow diffs between a branch and the HEAD revision, without \
showing files not on the branch as deleted. \
-This option affects only CVS topics currently.')"
-onmouseout="return nd();">(?)</A></FONT>
+This option affects only CVS topics currently.')">(?)</A></FONT>
</TD>
<TD COLSPAN="3"><INPUT TYPE="checkbox" NAME="default_to_head" [% IF
default_to_head %]CHECKED[% END %]></TD>
</TR>
@@ -159,14 +152,13 @@
<TR>
<TD>Repository:
<FONT SIZE="-2"><A HREF="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
The SCM system (eg CVS, Subversion, ClearCase) \
which the topic text was prepared against. If \
this is correctly set, this provides the \
ability to view the entire contents of a file \
with and/or without a proposed change, which \
-an aid in the reviewing process.')"
-onmouseout="return nd();">(?)</a></FONT>
+an aid in the reviewing process.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><SELECT NAME="repository">
[% FOREACH entry = repositories %]
@@ -187,10 +179,9 @@
<TR>
<TD>Project:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Topics are associated with a specific project, which can be \
-used as filtering criteria in the search screen.')"
-onmouseout="return nd();">(?)</a></FONT>
+used as filtering criteria in the search screen.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><SELECT NAME="projectid">
[% FOREACH project = projects %]
@@ -211,7 +202,7 @@
<TR>
<TD>Bug IDs:
<FONT SIZE="-2"><a href="javascript:void(0)"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Indicates what bug identifiers are addressed by this code change. \
These are space or comma separated identifiers, such as: \
<p> \
@@ -228,8 +219,7 @@
is changed, a comment will be inserted automatically to the \
associated bugs for cross referencing. When a bug is viewed, \
it can be easily determined what code fixes have been applied \
-to it.')"
-onmouseout="return nd();">(?)</a></FONT>
+to it.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><INPUT TYPE="text" NAME="bug_ids" VALUE="[% bug_ids |
html_entity %]" SIZE=30 MAXLENGTH=50></TD>
</TR>
@@ -239,11 +229,10 @@
<TR>
<TD>Your email address:
<FONT SIZE="-2"><A HREF="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
This is your email address. All comments made against a topic \
will be sent to this address. The new topic notification email \
-will also be sent to this address.')"
-onmouseout="return nd();">(?)</a></FONT>
+will also be sent to this address.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><INPUT TYPE="text" NAME="email" VALUE="[% email |
html_entity %]" SIZE=50 MAXLENGTH=80></TD>
</TR>
@@ -252,11 +241,10 @@
<TR>
<TD>Reviewers:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
This is a comma separated list of email addresses, which are the \
people who need to review this code. When the topic is created, \
-the new topic notification email will be sent to these addresses.')"
-onmouseout="return nd();">(?)</a></FONT>
+the new topic notification email will be sent to these
addresses.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><INPUT TYPE="text" NAME="reviewers" VALUE="[% reviewers |
html_entity %]" SIZE=50 MAXLENGTH=150></TD>
</TR>
@@ -265,11 +253,10 @@
<TR>
<TD>Cc:
<FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
This is a comma separated list of email addresses, which are \
not intended to be reviewers, but typically a mailing list \
-to notify a number of people about the creation of a new topic.')"
-onmouseout="return nd();">(?)</a></FONT>
+to notify a number of people about the creation of a new
topic.')">(?)</a></FONT>
</TD>
<TD COLSPAN="3"><INPUT TYPE="text" NAME="cc" VALUE="[% cc | html_entity %]"
SIZE=50 MAXLENGTH=150></TD>
</TR>
Index: search.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/search.html.tmpl,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- search.html.tmpl 23 May 2005 11:54:00 -0000 1.28
+++ search.html.tmpl 25 May 2005 08:00:15 -0000 1.29
@@ -16,30 +16,27 @@
[%# The author input field #%]
<TR>
<TD>Author: <FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on topic author, which may be wildcarded \
-as joe* or joe*company*.')"
-onmouseout="return nd();">(?)</a></FONT></TD>
+as joe* or joe*company*.')">(?)</a></FONT></TD>
<TD><INPUT TYPE="text" NAME="sauthor" SIZE=50 MAXLENGTH=100></TD>
</TR>
[%# The reviewer input field #%]
<TR>
<TD>Reviewer: <FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on topic reviewer, which may be wildcarded \
-as paul* or paul*company*.')"
-onmouseout="return nd();">(?)</a></FONT></TD>
+as paul* or paul*company*.')">(?)</a></FONT></TD>
<TD><INPUT TYPE="text" NAME="sreviewer" SIZE=50 MAXLENGTH=100></TD>
</TR>
[%# The Cc input field #%]
<TR>
<TD>Cc: <FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on topic CC, which may be wildcarded \
-as group* or group*company*.')"
-onmouseout="return nd();">(?)</a></FONT></TD>
+as group* or group*company*.')">(?)</a></FONT></TD>
<TD><INPUT TYPE="text" NAME="scc" SIZE=50 MAXLENGTH=100></TD>
</TR>
@@ -47,10 +44,9 @@
[% IF bugdb_enabled != 0 %]
<TR>
<TD>Bug ID: <FONT SIZE="-2"><A HREF="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on the topic bugid. This field \
-cannot be wildcarded.')"
-onmouseout="return nd();">(?)</a></FONT>
+cannot be wildcarded.')">(?)</a></FONT>
</TD>
<TD><INPUT TYPE="text" NAME="sbugid" SIZE=50 MAXLENGTH=100></TD>
</TR>
@@ -59,12 +55,11 @@
[%# The state multi-select #%]
<TR>
<TD>State: <FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on the topic\'s state. Multiple \
fields can be selected here by holding down the control \
button while selecting. State \'Any\' indicates the \
-returned topics can be in any state.')"
-onmouseout="return nd();">(?)</a></FONT></TD>
+returned topics can be in any state.')">(?)</a></FONT></TD>
<TD><SELECT NAME="state_group" SIZE=3 MULTIPLE>
[% FOREACH state = states %]
[% IF state == 'Open' %]
@@ -80,12 +75,11 @@
[%# The project multi-select #%]
<TR>
<TD>Project: <FONT SIZE="-2"><a href="javascript:void(0)"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on topic project membership. \
Multiple fields can be selected here by holding down the \
control button while selecting. State \'Any\' indicates the \
-returned topics can in any project.')"
-onmouseout="return nd();">(?)</a></FONT></TD>
+returned topics can in any project.')">(?)</a></FONT></TD>
<TD><SELECT NAME="project_group" SIZE=3 MULTIPLE>
[% FOREACH project = projects %]
[% IF project.name == 'Any' %]
@@ -101,10 +95,9 @@
[%# The contains text input field and checkbox #%]
<TR>
<TD>Contains text: <FONT SIZE="-2"><a href="javascript:void(0);"
-onmouseover="return overlib('\
+onmouseover="return create_window('\
Constrain the search on text contained in the title, description, \
-comment, body and filename topic attributes. Text can be wildcarded.')"
-onmouseout="return nd();">(?)</a></FONT></TD>
+comment, body and filename topic attributes. Text can be
wildcarded.')">(?)</a></FONT></TD>
<TD><INPUT TYPE="text" NAME="stext" SIZE=50 MAXLENGTH=100></TD>
</TR>
<TR>
-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
Codestriker-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/codestriker-commits
