Created Codestriker topic at:
http://codestriker.sourceforge.net/cgi-bin/codestriker.pl?topic=4578379&action=view
User: sits
Date: 05/06/07 15:51:48
Modified: lib Codestriker.pm
lib/Codestriker/Action DownloadTopic.pm MetricsReport.pm
lib/Codestriker/Http Response.pm UrlBuilder.pm
template/en/default createtopic.html.tmpl header.html.tmpl
listprojects.html.tmpl listtopics.html.tmpl
metricsreport.html.tmpl search.html.tmpl
viewtopic.html.tmpl viewtopiccomments.html.tmpl
viewtopicinfo.html.tmpl
viewtopicproperties.html.tmpl
Log:
HTML fixes from Jason
Index: Codestriker.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker.pm,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -r1.74 -r1.75
--- Codestriker.pm 24 May 2005 08:35:53 -0000 1.74
+++ Codestriker.pm 7 Jun 2005 22:51:45 -0000 1.75
@@ -27,7 +27,7 @@
);
# Version of Codestriker.
-$Codestriker::VERSION = "1.9.0";
+$Codestriker::VERSION = "1.9.0.beta1";
# Default title to display on each Codestriker screen.
$Codestriker::title = "Codestriker $Codestriker::VERSION";
Index: DownloadTopic.pm
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/lib/Codestriker/Action/DownloadTopic.pm,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- DownloadTopic.pm 22 May 2005 11:03:58 -0000 1.11
+++ DownloadTopic.pm 7 Jun 2005 22:51:46 -0000 1.12
@@ -31,6 +31,7 @@
# Dump the raw topic data as text/plain.
print $query->header(-type=>'text/plain',
-content_type=>'text/plain',
+ -charset=>"ISO-8859-1",
-attachment=>"topic${topicid}.txt",
-filename=>"topic${topicid}.txt",
-pragma=>"Cache",
Index: MetricsReport.pm
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/lib/Codestriker/Action/MetricsReport.pm,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- MetricsReport.pm 22 Aug 2004 12:09:29 -0000 1.6
+++ MetricsReport.pm 7 Jun 2005 22:51:46 -0000 1.7
@@ -61,6 +61,7 @@
my $query = $http_response->get_query();
print $query->header(-type=>'text/plain',
+ -charset=>"ISO-8859-1",
-attachment=>"metrics.csv",
-filename=>"metrics.csv");
Index: Response.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- Response.pm 2 Jun 2005 11:31:01 -0000 1.33
+++ Response.pm 7 Jun 2005 22:51:46 -0000 1.34
@@ -173,10 +173,12 @@
if ($cache) {
print $query->header(-cookie=>$cookie_obj,
-content_encoding=>'x-gzip',
+ -charset=>"ISO-8859-1",
-vary=>'Accept-Encoding');
} else {
print $query->header(-cookie=>$cookie_obj,
-expires=>'+1d',
+ -charset=>"ISO-8859-1",
-cache_control=>'no-store',
-pragma=>'no-cache',
-content_encoding=>'x-gzip',
@@ -192,10 +194,12 @@
$output_compressed = 1;
} else {
if ($cache) {
- print $query->header(-cookie=>$cookie_obj);
+ print $query->header(-cookie=>$cookie_obj,
+ -charset=>"ISO-8859-1");
} else {
print $query->header(-cookie=>$cookie_obj,
-expires=>'+1d',
+ -charset=>"ISO-8859-1",
-cache_control=>'no-store',
-pragma=>'no-cache');
}
@@ -368,10 +372,10 @@
my $key = $comment_locations[$index];
$key =~ /^(\-?\d+)\|(\-?\d+)\|(\d+)$/o;
$overlib_html .= "<a
href=\"javascript:add_comment_tooltip($1,$2,$3)" .
- "; void(0);\">Add Comment</a> | ";
+ "; void(0);\">Add Comment<\\/a> | ";
# Add a close link.
- $overlib_html .= "<a href=\"javascript:hideElt(getElt(\\'overDiv\\'));
void(0);\">Close</a><p>";
+ $overlib_html .= "<a href=\"javascript:hideElt(getElt(\\'overDiv\\'));
void(0);\">Close<\\/a><p>";
# Create the actual comment text.
my @comments = @{ $comment_hash{$key} };
@@ -388,7 +392,7 @@
# Show each comment with the author and date in bold.
$overlib_html .= "<b>Comment from $comment->{author} ";
- $overlib_html .= "on $comment->{date}</b><br>";
+ $overlib_html .= "on $comment->{date}<\\/b><br>";
$overlib_html .= "$data";
# Add a newline at the end if required.
Index: UrlBuilder.pm
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/lib/Codestriker/Http/UrlBuilder.pm,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- UrlBuilder.pm 21 Dec 2004 23:02:57 -0000 1.26
+++ UrlBuilder.pm 7 Jun 2005 22:51:46 -0000 1.27
@@ -52,13 +52,13 @@
$updated, $brmode, $fview) = @_;
return ($prefix ne "" ? $prefix : $self->{query}->url()) .
- "?topic=$topic&action=view" .
+ "?topic=$topic&action=view" .
($updated ? "&updated=$updated" : "") .
- ((defined $tabwidth && $tabwidth ne "") ? "&tabwidth=$tabwidth" : "") .
- ((defined $mode && $mode ne "") ? "&mode=$mode" : "") .
- ((defined $brmode && $brmode ne "") ? "&brmode=$brmode" : "") .
- ((defined $fview && $fview ne "") ? "&fview=$fview" : "") .
- ((defined $email && $email ne "") ? "&email=$email" : "") .
+ ((defined $tabwidth && $tabwidth ne "") ? "&tabwidth=$tabwidth" :
"") .
+ ((defined $mode && $mode ne "") ? "&mode=$mode" : "") .
+ ((defined $brmode && $brmode ne "") ? "&brmode=$brmode" : "") .
+ ((defined $fview && $fview ne "") ? "&fview=$fview" : "") .
+ ((defined $email && $email ne "") ? "&email=$email" : "") .
($line != -1 ? "#${line}" : "");
}
@@ -75,14 +75,14 @@
# Create the URL for downloading the topic text.
sub download_url ($$) {
my ($self, $topic) = @_;
- return $self->{query}->url() . "?action=download&topic=$topic";
+ return $self->{query}->url() . "?action=download&topic=$topic";
}
# Create the URL for creating a topic.
sub create_topic_url ($$) {
my ($self, $obsoletes) = @_;
return $self->{query}->url() . "?action=create" .
- (defined $obsoletes ? "&obsoletes=$obsoletes" : "");
+ (defined $obsoletes ? "&obsoletes=$obsoletes" : "");
}
# Create the URL for editing a topic.
@@ -90,17 +90,17 @@
my ($self, $filenumber, $line, $new, $topic, $context,
$anchor, $prefix) = @_;
return ($prefix ne "" ? $prefix : $self->{url_prefix}) .
- "?fn=$filenumber&line=$line&new=$new&topic=$topic&action=edit" .
- ((defined $anchor && $anchor ne "") ? "&a=$anchor" : "") .
- ((defined $context && $context ne "") ? "&context=$context" : "");
+
"?fn=$filenumber&line=$line&new=$new&topic=$topic&action=edit" .
+ ((defined $anchor && $anchor ne "") ? "&a=$anchor" : "") .
+ ((defined $context && $context ne "") ? "&context=$context" : "");
}
# Create the URL for viewing a new file.
sub view_file_url ($$$$$$$) {
my ($self, $topic, $filenumber, $new, $line, $mode, $parallel) = @_;
if (!(defined $mode)) { $mode = $Codestriker::default_topic_create_mode;
}
- return $self->{url_prefix} . "?action=view_file&fn=$filenumber&" .
-
"topic=$topic&new=$new&mode=$mode¶llel=$parallel#$filenumber|$line|$new";
+ return $self->{url_prefix} . "?action=view_file&fn=$filenumber&" .
+
"topic=$topic&new=$new&mode=$mode&parallel=$parallel#$filenumber|$line|$new";
}
# Create the URL for the search page.
@@ -145,19 +145,19 @@
my $sproject = defined $project_array_ref ?
(join ',', @$project_array_ref) : "";
return $self->{query}->url() . "?action=$action" .
- ($sauthor ne "" ? "&sauthor=$sauthor" : "") .
- ($sreviewer ne "" ? "&sreviewer=$sreviewer" : "") .
- ($scc ne "" ? "&scc=$scc" : "") .
- ($sbugid ne "" ? "&sbugid=$sbugid" : "") .
- ($stext ne "" ? "&stext=" . CGI::escape($stext) : "") .
- ($stitle ne "" ? "&stitle=$stitle" : "") .
- ($sdescription ne "" ? "&sdescription=$sdescription" : "") .
- ($scomments ne "" ? "&scomments=$scomments" : "") .
- ($sbody ne "" ? "&sbody=$sbody" : "") .
- ($sfilename ne "" ? "&sfilename=$sfilename" : "") .
- ($sstate ne "" ? "&sstate=$sstate" : "") .
- ($sproject ne "" ? "&sproject=$sproject" : "") .
- (defined $content && $content ne "" ? "&content=$content" : "");
+ ($sauthor ne "" ? "&sauthor=$sauthor" : "") .
+ ($sreviewer ne "" ? "&sreviewer=$sreviewer" : "") .
+ ($scc ne "" ? "&scc=$scc" : "") .
+ ($sbugid ne "" ? "&sbugid=$sbugid" : "") .
+ ($stext ne "" ? "&stext=" . CGI::escape($stext) : "") .
+ ($stitle ne "" ? "&stitle=$stitle" : "") .
+ ($sdescription ne "" ? "&sdescription=$sdescription" : "") .
+ ($scomments ne "" ? "&scomments=$scomments" : "") .
+ ($sbody ne "" ? "&sbody=$sbody" : "") .
+ ($sfilename ne "" ? "&sfilename=$sfilename" : "") .
+ ($sstate ne "" ? "&sstate=$sstate" : "") .
+ ($sproject ne "" ? "&sproject=$sproject" : "") .
+ (defined $content && $content ne "" ? "&content=$content" : "");
}
@@ -165,7 +165,7 @@
sub edit_project_url ($$) {
my ($self, $projectid) = @_;
- return $self->{query}->url() .
"?action=edit_project&projectid=$projectid";
+ return $self->{query}->url() .
"?action=edit_project&projectid=$projectid";
}
# Construct a URL for listing all projects.
@@ -186,7 +186,7 @@
sub view_comments_url ($$) {
my ($self, $topic) = @_;
- return $self->{query}->url() . "?action=list_comments&topic=$topic";
+ return $self->{query}->url() . "?action=list_comments&topic=$topic";
}
# Create the URL for viewing the topic properties.
@@ -194,14 +194,14 @@
my ($self, $topic) = @_;
return $self->{query}->url() .
- "?action=view_topic_properties&topic=$topic";
+ "?action=view_topic_properties&topic=$topic";
}
# Create the URL for viewing the topic metrics.
sub view_topicinfo_url ($$) {
my ($self, $topic) = @_;
- return $self->{query}->url() . "?action=viewinfo&topic=$topic";
+ return $self->{query}->url() . "?action=viewinfo&topic=$topic";
}
sub metric_report_url {
Index: createtopic.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/createtopic.html.tmpl,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- createtopic.html.tmpl 25 May 2005 08:00:15 -0000 1.43
+++ createtopic.html.tmpl 7 Jun 2005 22:51:47 -0000 1.44
@@ -24,9 +24,9 @@
<p>
[% END %]
-<FORM METHOD="POST" ENCTYPE="multipart/form-data">
-<INPUT TYPE="hidden" NAME="action" VALUE="submit_new_topic">
-<INPUT TYPE="hidden" NAME="obsoletes" VALUE="[% obsoletes %]">
+<FORM METHOD="post" ENCTYPE="multipart/form-data">
+<INPUT TYPE="hidden" NAME="action" VALUE="submit_new_topic" />
+<INPUT TYPE="hidden" NAME="obsoletes" VALUE="[% obsoletes %]" />
[%# The topic title input field #%]
Topic title:
@@ -34,8 +34,8 @@
onmouseover="return create_window('The topic title should be a concise but \
informative summary of the code to be reviewed. The title is used in the \
subject of sent emails, and in the topic list screen.');">(?)</a></FONT>
-<BR>
-<INPUT TYPE="text" NAME="topic_title" VALUE="[% topic_title | html_entity
%]" SIZE=70 MAXLENGTH=70>
+<BR/>
+<INPUT TYPE="text" NAME="topic_title" VALUE="[% topic_title | html_entity
%]" SIZE=70 MAXLENGTH=70 />
<P>
[%# The topic description input field #%]
@@ -46,7 +46,7 @@
for a reviewer to understand broadly what the code change \
achieves. This information is sent with the new topic \
notification email to all reviewers.')">(?)</a></FONT>
-<BR>
+<BR/>
<TEXTAREA NAME="topic_description" ROWS=12 COLS=70 WRAP="hard">[%
topic_description | html_entity %]</TEXTAREA>
<P>
@@ -81,7 +81,7 @@
This should be left blank if you are reviewing files \
directly from a repository.')">(?)</a></FONT>
</TD>
- <TD COLSPAN="3"><INPUT TYPE="file" NAME="topic_file" VALUE="[% topic_file |
html_entity %]" SIZE=40 MAXLENGTH=200></TD>
+ <TD COLSPAN="3"><INPUT TYPE="file" NAME="topic_file" VALUE="[% topic_file |
html_entity %]" SIZE=40 MAXLENGTH=200 /></TD>
</TR>
[% IF allow_repositories != 0 %]
@@ -101,7 +101,7 @@
will be downloaded.')">(?)</a></FONT>
</TD>
<TD>
-<INPUT TYPE="text" NAME="start_tag" VALUE="[% start_tag | html_entity %]"
SIZE=20 MAXLENGTH=150>
+<INPUT TYPE="text" NAME="start_tag" VALUE="[% start_tag | html_entity %]"
SIZE=20 MAXLENGTH=150 />
</TD>
<TD>End tag: <FONT SIZE="-2"><a href="javascript:void(0);"
onmouseover="return create_window('\
@@ -114,7 +114,7 @@
files in the specified module corresponding to the entered tag \
will be downloaded.')">(?)</A></FONT></TD>
<TD>
-<INPUT TYPE="text" NAME="end_tag" VALUE="[% end_tag | html_entity %]"
SIZE=20 MAXLENGTH=150>
+<INPUT TYPE="text" NAME="end_tag" VALUE="[% end_tag | html_entity %]"
SIZE=20 MAXLENGTH=150 />
</TD>
</TR>
<TR>
@@ -127,7 +127,7 @@
root that should be inspected. It is ignored if text is
uploaded.')">(?)</a></FONT>
</TD>
<TD>
-<INPUT TYPE="text" NAME="module" VALUE="[% module | html_entity %]" SIZE=20
MAXLENGTH=150>
+<INPUT TYPE="text" NAME="module" VALUE="[% module | html_entity %]" SIZE=20
MAXLENGTH=150 />
</TD>
</TR>
@@ -142,7 +142,7 @@
showing files not on the branch as deleted. \
This option affects only CVS topics currently.')">(?)</A></FONT>
</TD>
- <TD COLSPAN="3"><INPUT TYPE="checkbox" NAME="default_to_head" [% IF
default_to_head %]CHECKED[% END %]></TD>
+ <TD COLSPAN="3"><INPUT TYPE="checkbox" NAME="default_to_head" [% IF
default_to_head %]CHECKED[% END %] /></TD>
</TR>
[% END %]
@@ -221,7 +221,7 @@
it can be easily determined what code fixes have been applied \
to it.')">(?)</a></FONT>
</TD>
- <TD COLSPAN="3"><INPUT TYPE="text" NAME="bug_ids" VALUE="[% bug_ids |
html_entity %]" SIZE=30 MAXLENGTH=50></TD>
+ <TD COLSPAN="3"><INPUT TYPE="text" NAME="bug_ids" VALUE="[% bug_ids |
html_entity %]" SIZE=30 MAXLENGTH=50 /></TD>
</TR>
[% END %]
@@ -234,7 +234,7 @@
will be sent to this address. The new topic notification email \
will also be sent to this address.')">(?)</a></FONT>
</TD>
- <TD COLSPAN="3"><INPUT TYPE="text" NAME="email" VALUE="[% email |
html_entity %]" SIZE=50 MAXLENGTH=80></TD>
+ <TD COLSPAN="3"><INPUT TYPE="text" NAME="email" VALUE="[% email |
html_entity %]" SIZE=50 MAXLENGTH=80 /></TD>
</TR>
[%# The reviewers input field #%]
@@ -246,7 +246,7 @@
people who need to review this code. When the topic is created, \
the new topic notification email will be sent to these
addresses.')">(?)</a></FONT>
</TD>
- <TD COLSPAN="3"><INPUT TYPE="text" NAME="reviewers" VALUE="[% reviewers |
html_entity %]" SIZE=50 MAXLENGTH=150></TD>
+ <TD COLSPAN="3"><INPUT TYPE="text" NAME="reviewers" VALUE="[% reviewers |
html_entity %]" SIZE=50 MAXLENGTH=150 /></TD>
</TR>
[%# The Cc input field #%]
@@ -258,12 +258,12 @@
not intended to be reviewers, but typically a mailing list \
to notify a number of people about the creation of a new
topic.')">(?)</a></FONT>
</TD>
- <TD COLSPAN="3"><INPUT TYPE="text" NAME="cc" VALUE="[% cc | html_entity %]"
SIZE=50 MAXLENGTH=150></TD>
+ <TD COLSPAN="3"><INPUT TYPE="text" NAME="cc" VALUE="[% cc | html_entity %]"
SIZE=50 MAXLENGTH=150 /></TD>
</TR>
</TABLE>
<P>
-<INPUT TYPE="submit" NAME=".submit" VALUE="Create Topic">
+<INPUT TYPE="submit" NAME=".submit" VALUE="Create Topic" />
</FORM>
Index: header.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/header.html.tmpl,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- header.html.tmpl 22 Feb 2005 01:38:25 -0000 1.12
+++ header.html.tmpl 7 Jun 2005 22:51:47 -0000 1.13
@@ -1,6 +1,6 @@
[% IF closehead %]
</head>
-<body charset="ISO-8859-1" link="blue" vlink="purple" bgcolor="#eeeeee"
onLoad="gotoAnchor(cs_load_anchor, cs_reload);">
+<body link="blue" vlink="purple" bgcolor="#eeeeee"
onLoad="gotoAnchor(cs_load_anchor, cs_reload);">
[% END %]
[%# Header HTML code to appear on each screen, after <body> tag. #%]
@@ -26,4 +26,4 @@
</div>
[% END %]
-<hr>
+<hr />
Index: listprojects.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/listprojects.html.tmpl,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- listprojects.html.tmpl 23 May 2005 11:54:00 -0000 1.18
+++ listprojects.html.tmpl 7 Jun 2005 22:51:47 -0000 1.19
@@ -34,13 +34,13 @@
[% END %]
<tr class="tlh">
- <td colspan="3"> </td>
+ <td colspan="3"> </td>
</tr>
</TABLE>
<P>
-<HR>
+<HR/>
<A HREF="[% create_project_url %]">Create new project</A>
Index: listtopics.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/listtopics.html.tmpl,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- listtopics.html.tmpl 23 May 2005 11:54:00 -0000 1.34
+++ listtopics.html.tmpl 7 Jun 2005 22:51:47 -0000 1.35
@@ -10,21 +10,21 @@
[% END %]
[%# Display the heading and create the table #%]
-<FORM METHOD="POST" ENCTYPE="multipart/form-data">
-<INPUT TYPE="hidden" NAME="action" VALUE="change_topics_state">
+<FORM METHOD="post" ENCTYPE="multipart/form-data">
+<input TYPE="hidden" NAME="action" VALUE="change_topics_state" />
[%# Store the search parameters as hidden variables #%]
-<INPUT TYPE="hidden" NAME="sauthor" VALUE="[% sauthor | html_entity %]">
-<INPUT TYPE="hidden" NAME="sreviewer" VALUE="[% sreviewer | html_entity %]">
-<INPUT TYPE="hidden" NAME="scc" VALUE="[% scc | html_entity %]">
-<INPUT TYPE="hidden" NAME="sbugid" VALUE="[% sbugid %]">
-<INPUT TYPE="hidden" NAME="stext" VALUE="[% stext | html_entity %]">
-<INPUT TYPE="hidden" NAME="sstate" VALUE="[% sstate %]">
-<INPUT TYPE="hidden" NAME="stitle" VALUE="[% stitle | html_entity %]">
-<INPUT TYPE="hidden" NAME="sdescription" VALUE="[% sdescription |
html_entity %]">
-<INPUT TYPE="hidden" NAME="scomments" VALUE="[% scomments | html_entity %]">
-<INPUT TYPE="hidden" NAME="sbody" VALUE="[% sbody | html_entity %]">
-<INPUT TYPE="hidden" NAME="sfilename" VALUE="[% sfilename | html_entity %]">
+<input TYPE="hidden" NAME="sauthor" VALUE="[% sauthor | html_entity %]" />
+<input TYPE="hidden" NAME="sreviewer" VALUE="[% sreviewer | html_entity %]"
/>
+<input TYPE="hidden" NAME="scc" VALUE="[% scc | html_entity %]" />
+<input TYPE="hidden" NAME="sbugid" VALUE="[% sbugid %]" />
+<input TYPE="hidden" NAME="stext" VALUE="[% stext | html_entity %]" />
+<input TYPE="hidden" NAME="sstate" VALUE="[% sstate %]" />
+<input TYPE="hidden" NAME="stitle" VALUE="[% stitle | html_entity %]" />
+<input TYPE="hidden" NAME="sdescription" VALUE="[% sdescription |
html_entity %]" />
+<input TYPE="hidden" NAME="scomments" VALUE="[% scomments | html_entity %]"
/>
+<input TYPE="hidden" NAME="sbody" VALUE="[% sbody | html_entity %]" />
+<input TYPE="hidden" NAME="sfilename" VALUE="[% sfilename | html_entity %]"
/>
<H1>Topic list</H1>
@@ -34,18 +34,18 @@
[%# Display the table header #%]
<tr class="tlh">
- <th colspan="2"><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=title">Title</a></th>
- <th><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=author">Author</a></th>
+ <th colspan="2"><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=title">Title</a></th>
+ <th><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=author">Author</a></th>
<th>Reviewer</th>
<th>Cc</th>
- <th><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=created">Created</a></th>
+ <th><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=created">Created</a></th>
[% FOREACH commentmetric = commentmetrics %]
<th>[% commentmetric.value | html_entity %]</th>
[% END %]
[% IF bugdb_enabled != 0 %]
<th>Bug IDs</th>
[% END %]
- <th><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=state">State</a></th>
+ <th><a href="[% list_sort_url | uri | html_entity
%]&topic_sort_change=state">State</a></th>
</tr>
[%# Display each topic row, alternating the background colour #%]
@@ -53,7 +53,7 @@
[% FLUSH IF loop.count() % 10 == 1 %]
<tr class="[% loop.count() % 2 == 0 ? 'tl1' : 'tl2' %]">
- <td><INPUT TYPE="checkbox" NAME="selected_topics" VALUE="[% topic.id
%],[% topic.version %]"></td>
+ <td><input TYPE="checkbox" NAME="selected_topics" VALUE="[% topic.id
%],[% topic.version %]" /></td>
<td><a href="[% topic.view_topic_url | uri | html_entity %]">[%
topic.title | html_entity %]</a></td>
<td>[% topic.author | html_entity %]</td>
<td>[% topic.reviewer | html_entity %]</td>
@@ -71,7 +71,7 @@
[% END %]
<tr class="tlh">
- <td colspan="8"> </td>
+ <td colspan="8"> </td>
</tr>
</table>
@@ -100,21 +100,21 @@
</select>
</td>
<td>
- <input type="submit" name="button" value="Update">
+ <input type="submit" name="button" value="Update" />
</td>
</tr>
[% IF obsoleted_state_present == 1 %]
<tr>
<td> </td>
<td>
- <input type="submit" name="button" value="Obsolete Topic(s)">
+ <input type="submit" name="button" value="Obsolete Topic(s)" />
</td>
</tr>
[% END %]
</table>
<table width="100%">
- <tr class="tlh"><td> </td></tr>
+ <tr class="tlh"><td> </td></tr>
</table>
</FORM>
@@ -129,7 +129,7 @@
[% IF rss_enabled %]
| <a href="[% list_sort_url_rss | uri | html %]">RSS</a>
- <link rel="alternate" type="application/rdf+xml" title="RSS" href="[%
list_sort_url_rss | uri | html %]">
+ <link rel="alternate" type="application/rdf+xml" title="RSS" href="[%
list_sort_url_rss | uri | html %]" />
[% END %]
</p>
Index: metricsreport.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/metricsreport.html.tmpl,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- metricsreport.html.tmpl 23 May 2005 11:54:00 -0000 1.13
+++ metricsreport.html.tmpl 7 Jun 2005 22:51:47 -0000 1.14
@@ -113,7 +113,7 @@
-<hr>
+<hr/>
<p><a href="[% download_url %]">Download all metric data as a tabbed
delimited text file</a>
Index: search.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/search.html.tmpl,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- search.html.tmpl 25 May 2005 08:00:15 -0000 1.29
+++ search.html.tmpl 7 Jun 2005 22:51:47 -0000 1.30
@@ -7,9 +7,9 @@
<P>
-<FORM METHOD="POST" ENCTYPE="application/x-www-form-urlencoded">
+<FORM METHOD="post" ENCTYPE="application/x-www-form-urlencoded">
-<INPUT TYPE="hidden" NAME="action" VALUE="submit_search">
+<INPUT TYPE="hidden" NAME="action" VALUE="submit_search" />
<TABLE>
@@ -19,7 +19,7 @@
onmouseover="return create_window('\
Constrain the search on topic author, which may be wildcarded \
as joe* or joe*company*.')">(?)</a></FONT></TD>
- <TD><INPUT TYPE="text" NAME="sauthor" SIZE=50 MAXLENGTH=100></TD>
+ <TD><INPUT TYPE="text" NAME="sauthor" SIZE=50 MAXLENGTH=100 /></TD>
</TR>
[%# The reviewer input field #%]
@@ -28,7 +28,7 @@
onmouseover="return create_window('\
Constrain the search on topic reviewer, which may be wildcarded \
as paul* or paul*company*.')">(?)</a></FONT></TD>
- <TD><INPUT TYPE="text" NAME="sreviewer" SIZE=50 MAXLENGTH=100></TD>
+ <TD><INPUT TYPE="text" NAME="sreviewer" SIZE=50 MAXLENGTH=100 /></TD>
</TR>
[%# The Cc input field #%]
@@ -37,7 +37,7 @@
onmouseover="return create_window('\
Constrain the search on topic CC, which may be wildcarded \
as group* or group*company*.')">(?)</a></FONT></TD>
- <TD><INPUT TYPE="text" NAME="scc" SIZE=50 MAXLENGTH=100></TD>
+ <TD><INPUT TYPE="text" NAME="scc" SIZE=50 MAXLENGTH=100 /></TD>
</TR>
[%# The Bug id input field #%]
@@ -48,7 +48,7 @@
Constrain the search on the topic bugid. This field \
cannot be wildcarded.')">(?)</a></FONT>
</TD>
- <TD><INPUT TYPE="text" NAME="sbugid" SIZE=50 MAXLENGTH=100></TD>
+ <TD><INPUT TYPE="text" NAME="sbugid" SIZE=50 MAXLENGTH=100 /></TD>
</TR>
[% END %]
@@ -98,23 +98,23 @@
onmouseover="return create_window('\
Constrain the search on text contained in the title, description, \
comment, body and filename topic attributes. Text can be
wildcarded.')">(?)</a></FONT></TD>
- <TD><INPUT TYPE="text" NAME="stext" SIZE=50 MAXLENGTH=100></TD>
+ <TD><INPUT TYPE="text" NAME="stext" SIZE=50 MAXLENGTH=100 /></TD>
</TR>
<TR>
<TD> </TD>
<TD>in:
- [% IF enable_title %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="title" CHECKED>title [% END %]
- [% IF enable_description %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="description">description [% END %]
- [% IF enable_comment %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="comment">comment [% END %]
- [% IF enable_body %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="body">body [% END %]
- [% IF enable_filename %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="filename">filename[% END %]
+ [% IF enable_title %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="title" CHECKED />title [% END %]
+ [% IF enable_description %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="description" />description [% END %]
+ [% IF enable_comment %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="comment" />comment [% END %]
+ [% IF enable_body %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="body" />body [% END %]
+ [% IF enable_filename %]<INPUT TYPE="checkbox" NAME="text_group"
VALUE="filename" />filename[% END %]
</TD>
</TR>
</TABLE>
-<INPUT TYPE="submit" NAME=".submit" VALUE="Submit">
-<INPUT TYPE="hidden" NAME=".cgifields" VALUE="state_group">
-<INPUT TYPE="hidden" NAME=".cgifields" VALUE="text_group">
+<INPUT TYPE="submit" NAME=".submit" VALUE="Submit" />
+<INPUT TYPE="hidden" NAME=".cgifields" VALUE="state_group" />
+<INPUT TYPE="hidden" NAME=".cgifields" VALUE="text_group" />
</FORM>
Index: viewtopic.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/viewtopic.html.tmpl,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- viewtopic.html.tmpl 23 May 2005 11:54:00 -0000 1.33
+++ viewtopic.html.tmpl 7 Jun 2005 22:51:47 -0000 1.34
@@ -1,5 +1,5 @@
</head>
-<body charset="ISO-8859-1" vlink="purple"
onload="view_topic_on_load_handler();"
+<body vlink="purple" onload="view_topic_on_load_handler();"
bgcolor="#eeeeee" link="blue">
[%# Screen for displaying the heading information of a topic. The
Index: viewtopiccomments.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/viewtopiccomments.html.tmpl,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- viewtopiccomments.html.tmpl 2 Jun 2005 11:31:02 -0000 1.22
+++ viewtopiccomments.html.tmpl 7 Jun 2005 22:51:47 -0000 1.23
@@ -7,7 +7,7 @@
help = "x586.html" topicview = 0 topicproperties = 0 topiccomments = 1
topicinfo = 0 closehead = 1 %]
-<SCRIPT language="JavaScript">
+<SCRIPT type="text/javascript">
<!-- This function handles the three filter select boxes at the top of the
table.
function SelectFilter(post)
{
@@ -48,18 +48,18 @@
// -->
</SCRIPT>
-<FORM METHOD="POST" ENCTYPE="multipart/form-data" name="form">
-<INPUT TYPE="hidden" NAME="action" VALUE="change_comments_state">
-<INPUT TYPE="hidden" NAME="topic" VALUE="[% topic %]">
-
-<INPUT TYPE="hidden" NAME="scontext" VALUE="[% scontext %]">
-<INPUT TYPE="hidden" NAME="sauthor" VALUE="[% sauthor %]">
-<INPUT TYPE="hidden" NAME="sstate" VALUE="[% sstate %]">
+<FORM METHOD="post" ENCTYPE="multipart/form-data" name="form">
+<INPUT TYPE="hidden" NAME="action" VALUE="change_comments_state" />
+<INPUT TYPE="hidden" NAME="topic" VALUE="[% topic %]" />
+
+<INPUT TYPE="hidden" NAME="scontext" VALUE="[% scontext %]" />
+<INPUT TYPE="hidden" NAME="sauthor" VALUE="[% sauthor %]" />
+<INPUT TYPE="hidden" NAME="sstate" VALUE="[% sstate %]" />
<P><FONT size="5">Comments: </FONT>
-<BR>
+<BR/>
<TABLE>
<TR>
<TD ALIGN="right">Show authored by: </TD>
@@ -190,7 +190,7 @@
[%# Check to see if the topic is open or not #%]
[% IF topic_readonly == 0 %]
<P>
-<INPUT TYPE="submit" NAME="button" VALUE="Update">
+<INPUT TYPE="submit" NAME="button" VALUE="Update" />
[% END %]
</FORM>
Index: viewtopicinfo.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/viewtopicinfo.html.tmpl,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- viewtopicinfo.html.tmpl 23 May 2005 11:54:00 -0000 1.19
+++ viewtopicinfo.html.tmpl 7 Jun 2005 22:51:47 -0000 1.20
@@ -10,10 +10,10 @@
[% SET metric_input_exists = 0 %]
<form method="post" enctype="application/x-www-form-urlencoded" name="form">
-<input type="hidden" name="action" value="edit_topic_metrics">
-<input type="hidden" name="topic" value="[% topic %]">
-<input type="hidden" name="mode" value="[% mode %]">
-<input type="hidden" name="version" value="[% topic_version %]">
+<input type="hidden" name="action" value="edit_topic_metrics" />
+<input type="hidden" name="topic" value="[% topic %]" />
+<input type="hidden" name="mode" value="[% mode %]" />
+<input type="hidden" name="version" value="[% topic_version %]" />
<h3>Comment Metrics</h3>
@@ -77,7 +77,7 @@
[% FOREACH metric = topic_metrics %]
[% IF metric.enabled %]
[% metric_input_exists = 1 %]
- <td><input name="topic_metric" type="text" size="6" value="[%
metric.value %]"></td>
+ <td><input name="topic_metric" type="text" size="6" value="[%
metric.value %]"/></td>
[% ELSE %]
<td>[% metric.value %]</td>
[% END %]
@@ -117,12 +117,12 @@
[% IF metric.scope == 'author' || metric.scope == 'participant' %]
[% IF metric.enabled %]
[% metric_input_exists = 1 %]
- <td><input name="author_metric" type="text" value="[% metric.value
%]" size="6"></td>
+ <td><input name="author_metric" type="text" value="[% metric.value
%]" size="6"/></td>
[% ELSE %]
<td>[% metric.value %]</td>
[% END %]
[% ELSE %]
- <td><input name="author_metric" type="hidden"></td>
+ <td><input name="author_metric" type="hidden"/></td>
[% END %]
[% END %]
@@ -138,12 +138,12 @@
[% IF metric.scope != 'author' %]
[% IF metric.enabled != 0 %]
[% metric_input_exists = 1 %]
- <td><input name="reviewer_metric,[% reviewerindex %]" type="text"
value="[% metric.value %]" size="6"></td>
+ <td><input name="reviewer_metric,[% reviewerindex %]" type="text"
value="[% metric.value %]" size="6"/></td>
[% ELSE %]
<td>[% metric.value %]</td>
[% END %]
[% ELSE %]
- <td><input name="reviewer_metric,[% reviewerindex %]" type="hidden"></td>
+ <td><input name="reviewer_metric,[% reviewerindex %]"
type="hidden"/></td>
[% END %]
[% END %]
@@ -165,7 +165,7 @@
[% IF metric_input_exists == 1 %]
[%# Render the submit button #%]
<input type="submit" name="button" value="Update Metrics"
- onClick="return DeleteTopicConfirm();">
+ onClick="return DeleteTopicConfirm();"/>
[% END %]
</form>
Index: viewtopicproperties.html.tmpl
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/template/en/default/viewtopicproperties.html.tmpl,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- viewtopicproperties.html.tmpl 23 May 2005 11:54:00 -0000 1.18
+++ viewtopicproperties.html.tmpl 7 Jun 2005 22:51:47 -0000 1.19
@@ -7,7 +7,7 @@
topiccomments = 0 topicinfo = 0 topicproperties = 1 closehead = 1
help = "x608.html" %]
-<script language="JavaScript">
+<script type="text/javascript">
<!--
//
// This function will hit the user with a "are you sure" message box if they
@@ -35,10 +35,10 @@
[%# Create a form to allow the topic's properties to be changed #%]
<form method="post" enctype="application/x-www-form-urlencoded" name="form">
-<input type="hidden" name="action" value="edit_topic_properties">
-<input type="hidden" name="topic" value="[% topicid %]">
-<input type="hidden" name="mode" value="[% mode %]">
-<input type="hidden" name="version" value="[% topic_version %]">
+<input type="hidden" name="action" value="edit_topic_properties" />
+<input type="hidden" name="topic" value="[% topicid %]" />
+<input type="hidden" name="mode" value="[% mode %]" />
+<input type="hidden" name="version" value="[% topic_version %]" />
[%# Create a table illustrating the title, author, creation date, bug
ids, reviewers, number of lines and the current state, most of
@@ -57,7 +57,7 @@
[% IF topic_readonly != 0 %]
readonly
[% END %]
- maxlength="70">
+ maxlength="70"/>
</td>
</tr>
@@ -67,7 +67,7 @@
<input type="text" name="author" value="[% author | html_entity %]"
size="50" maxlength="80"
[%# Check to see if the topic is open or not #%]
- [% IF antispam_email || topic_readonly != 0 %]readonly[% END %]>
+ [% IF antispam_email || topic_readonly != 0 %]readonly[% END %] />
</td>
</tr>
@@ -81,7 +81,7 @@
<td>Bug IDs:</td>
<td>
<input type="text" name="bug_ids" value="[% bug_ids %]"
- size="30" maxlength="50" [% IF topic_readonly != 0 %]readonly[%
END %]>
+ size="30" maxlength="50" [% IF topic_readonly != 0 %]readonly[%
END %] />
Links:
[% FOREACH bug = bug_id_array %]
[% IF loop.count() != 1 %], [% END %]
@@ -97,7 +97,7 @@
<input type="text" name="reviewers" value="[% reviewers | html_entity %]"
size="50" maxlength="150"
[%# Check to see if the topic is open or not #%]
- [% IF antispam_email || topic_readonly != 0 %]readonly[% END %]>
+ [% IF antispam_email || topic_readonly != 0 %]readonly[% END %] />
</td>
</tr>
@@ -107,7 +107,7 @@
<input type="text" name="cc" value="[% cc | html_entity %]"
size="50" maxlength="150"
[%# Check to see if the topic is open or not #%]
- [% IF antispam_email || topic_readonly != 0 %]readonly[% END %]>
+ [% IF antispam_email || topic_readonly != 0 %]readonly[% END %] />
</td>
</tr>
@@ -135,12 +135,14 @@
[% IF topic_repository != '' %]
<tr class="tt1">
<td>Repository:</td>
+ <td>
[% FOREACH entry = repositories %]
[% IF entry == topic_repository %]
- <input type="hidden" name="repository" value="[%
topic_repository %]" readonly>
- <td>[% entry | html_entity %]</td>
+ <input type="hidden" name="repository" value="[%
topic_repository %]" readonly />
+ [% entry | html_entity %]
[% END %]
[% END %]
+ </td>
</tr>
[% END %]
@@ -166,15 +168,15 @@
[% ELSE %]
[% FOREACH project = projects %]
[% IF project.id == topic_projectid %]
- <input type="hidden" name="projectid" value="[% project.id %]">
- <input type="text" name="projectname" value="[% project.name |
html_entity %]" readonly>
+ <input type="hidden" name="projectid" value="[% project.id %]"
/>
+ <input type="text" name="projectname" value="[% project.name |
html_entity %]" readonly />
[% END %]
[% END %]
[% END %]
</td>
</tr>
[% ELSE %]
- <input type="hidden" name="projectid" value="[% topic_projectid %]">
+ <input type="hidden" name="projectid" value="[% topic_projectid %]" />
[% END %]
<tr class="tt1">
@@ -231,7 +233,7 @@
<tr>
<td colspan="2">
<input type="submit" name="button" value="Update Topic"
- onClick="return DeleteTopicConfirm();">
+ onClick="return DeleteTopicConfirm();" />
</td>
</tr>
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
Codestriker-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/codestriker-commits
