User: sits
Date: 08/02/26 00:32:18
Modified: . CHANGELOG
lib/Codestriker/Http Render.pm
Log:
* Make sure very long filenames don't move the diff display far to the
right of the view topic page. Fix suggested by
[EMAIL PROTECTED]
Index: CHANGELOG
===================================================================
RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v
retrieving revision 1.224
retrieving revision 1.225
diff -u -r1.224 -r1.225
--- CHANGELOG 21 Feb 2008 02:32:09 -0000 1.224
+++ CHANGELOG 26 Feb 2008 08:32:17 -0000 1.225
@@ -27,6 +27,10 @@
* Make sure if an invalid CGI parameter value is specified that its
value is encoded when displaying the generic error page. Reported
by [EMAIL PROTECTED]
+
+* Make sure very long filenames don't move the diff display far to the
+ right of the view topic page. Fix suggested by
+ [EMAIL PROTECTED]
Version 1.9.4
Index: Render.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Render.pm,v
retrieving revision 1.53
retrieving revision 1.54
diff -u -r1.53 -r1.54
--- Render.pm 13 Jun 2006 23:38:40 -0000 1.53
+++ Render.pm 26 Feb 2008 08:32:17 -0000 1.54
@@ -413,43 +413,48 @@
if ($file_url eq "") {
# Output the header without hyperlinking the filename.
- $cell = $query->td({-class=>'file', -colspan=>'3'},
- "Diff for ",
- $query->a({name=>$filename},
- $filename),
- $revision_text);
+ $cell = "Diff for " .
+ $query->a({name=>$filename},
+ $filename) .
+ $revision_text;
}
else {
# Link the filename to the repository system with more information
# about it.
- $cell = $query->td({-class=>'file', -colspan=>'3'},
- "Diff for ",
- $query->a({href=>$file_url,
- name=>$filename},
- $filename),
- $revision_text);
+ $cell = "Diff for " .
+ $query->a({href=>$file_url,
+ name=>$filename},
+ $filename) .
+ $revision_text;
}
# Output the "back to contents" link and some browsing links
# for visiting the previous and next file (<<, >>), in
# addition to the "add file-level comment" link.
- print $query->Tr($cell, # = file header
- $query->td({-class=>'file', align=>'right'},
- "$add_file_level_comment_text ",
- ($bwd_url ne "" ?
$query->a({href=>$bwd_url},"[<<]") : ""),
- $query->a({href=>$contents_url},"[Top]"),
- ($fwd_url ne "" ?
$query->a({href=>$fwd_url},"[>>]") : "")));
+ print $query->Tr($query->td({-class=>'file', -colspan=>'4'},
+ $query->table({-width=>'100%'},
+ $query->Tr(
+ $query->td({align=>'left'}, $cell),
+ $query->td({align=>'right'},
+
"$add_file_level_comment_text ",
+ ($bwd_url ne "" ?
$query->a({href=>$bwd_url},"[<<]") : ""),
+
$query->a({href=>$contents_url},"[Top]"),
+ ($fwd_url ne "" ?
$query->a({href=>$fwd_url},"[>>]") : ""))))));
} else {
# No match in repository, or a new file.
- print $query->Tr($query->td({-class=>'file', -colspan=>'3'},
- "File ",
- $query->a({name=>$filename},$filename)),
- $query->td({-class=>'file', align=>'right'},
- "$add_file_level_comment_text ",
- ($bwd_url ne "" ?
$query->a({href=>$bwd_url},"[<<]") : ""),
- $query->a({href=>$contents_url},"[Top]"),
- ($fwd_url ne "" ?
$query->a({href=>$fwd_url},"[>>]") : "")));
+ print $query->Tr($query->td({-class=>'file', -colspan=>'4'},
+ $query->table({-width=>'100%'},
+ $query->Tr(
+ $query->td({align=>'left'},
+ "File ",
+
$query->a({name=>$filename},
+ $filename)),
+ $query->td({align=>'right'},
+
"$add_file_level_comment_text ",
+ ($bwd_url ne "" ?
$query->a({href=>$bwd_url},"[<<]") : ""),
+
$query->a({href=>$contents_url},"[Top]"),
+ ($fwd_url ne "" ?
$query->a({href=>$fwd_url},"[>>]") : ""))))));
}
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Codestriker-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/codestriker-commits
