Hi Marc, On Tue, Jun 22, 2010 at 2:58 PM, Marc Fournier <marc.fourn...@camptocamp.com> wrote: > Hello, > >> On Fri, Jun 11, 2010 at 10:51:03AM +0200, Florian Forster wrote: >> > >> > I'm currently thinking about moving information from the type instance >> > to the plugin instance. [...] >> > >> > If we move some of the information into the plugin instance, the data is >> > structured better: >> > >> > host/varnish-default-storage-file/... >> > .../total_requests >> > .../requests-outstanding >> > .../bytes-allocated >> > .../bytes-free >> > host/varnish-default-storage-mem/... >> > .../total_requests >> > .../requests-outstanding >> > .../bytes-outstanding >> > .../bytes-allocated >> > .../bytes-free >> > host/varnish-default-storage-synth/... >> > .../total_requests >> > .../requests-outstanding >> > .../bytes-outstanding >> > .../bytes-allocated >> > .../bytes-free >> >> You'll find an implementation suggestion in this branch: >> >> http://github.com/mfournier/collectd/commits/varnish-data-reorg > > As requested, I changed the strncat/sstrncpy functions for one ssnprintf. > The resulting behaviour remains the same as before. > > I also pushed another patch adding a whitespace in front of each opening > bracket, as it seems to be the coding style used in the rest of the > project. >
Excellent, I think Florian should integrate these changes to the jr/varnish branch :) Thanks for your help :) -- Jérôme _______________________________________________ collectd mailing list collectd@verplant.org http://mailman.verplant.org/listinfo/collectd