Hi,
Collectd version 5.5.
source code: git clone from github with branch master.
Plugins: memory rrdtool
rrdtool plugin config:
<Plugin rrdtool>
DataDir "/opt/collectd/var/lib/collectd/rrd"
CreateFilesAsync false
CacheTimeout 120
CacheFlush 900
WritesPerSecond 50
</Plugin>
memory plugin config:
<Plugin "memory">
ValuesAbsolute true
ValuesPercentage true
</Plugin>
but I get this rrdinfo, when i check memory-free.rrd file.
[longeek@longeek src]$ rrdinfo
/opt/collectd/var/lib/collectd/rrd/longeek/memory/memory-free.rrd | more
filename =
"/opt/collectd/var/lib/collectd/rrd/longeek/memory/memory-free.rrd"
rrd_version = "0003"
step = 2
last_update = 1448010303
header_size = 3496
ds[value].index = 0
ds[value].type = "GAUGE" //BUG!!!
ds[value].minimal_heartbeat = 4
ds[value].min = 0.0000000000e+00
ds[value].max = 2.8147497671e+14
ds[value].last_ds = "117870592"
ds[value].value = 1.1787059200e+08
ds[value].unknown_sec = 0
##################
I check memory.c source:
168 #define MEMORY_SUBMIT(...) do { \
169 >---if (values_absolute) \
170 >--->---plugin_dispatch_multivalue (vl, 0, DS_TYPE_GAUGE, __VA_ARGS__,
NULL); \
171 >---if (values_percentage) \
172 >--->---plugin_dispatch_multivalue (vl, 1, DS_TYPE_GAUGE, __VA_ARGS__,
NULL); \
173 } while (0)
###################
I think this is a bug!!! ok?
Best Regards,
Lawrency Meng
men...@inspur.com
From ef36b43fdc560b1cc0c21c9fc1afd4cff9a37060 Mon Sep 17 00:00:00 2001
From: Lawrency Meng <men...@inspur.com>
Date: Fri, 20 Nov 2015 17:22:25 +0800
Subject: [PATCH] Fix memory plugin rrd DS type with absolute config
Signed-off-by: Lawrency Meng <men...@inspur.com>
---
src/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/memory.c b/src/memory.c
index fb2f3d3..b7805ba 100644
--- a/src/memory.c
+++ b/src/memory.c
@@ -160,7 +160,7 @@ static int memory_init (void)
#define MEMORY_SUBMIT(...) do { \
if (values_absolute) \
- plugin_dispatch_multivalue (vl, 0, DS_TYPE_GAUGE, __VA_ARGS__, NULL); \
+ plugin_dispatch_multivalue (vl, 0, DS_TYPE_ABSOLUTE, __VA_ARGS__, NULL); \
if (values_percentage) \
plugin_dispatch_multivalue (vl, 1, DS_TYPE_GAUGE, __VA_ARGS__, NULL); \
} while (0)
--
1.8.3.1
_______________________________________________
collectd mailing list
collectd@verplant.org
http://mailman.verplant.org/listinfo/collectd
