Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package chromium for openSUSE:Factory 
checked in at 2021-01-26 14:45:05
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/chromium (Old)
 and      /work/SRC/openSUSE:Factory/.chromium.new.28504 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "chromium"

Tue Jan 26 14:45:05 2021 rev:281 rq:866254 version:88.0.4324.96

Changes:
--------
--- /work/SRC/openSUSE:Factory/chromium/chromium.changes        2021-01-19 
16:00:10.567196928 +0100
+++ /work/SRC/openSUSE:Factory/.chromium.new.28504/chromium.changes     
2021-01-26 14:49:29.999657179 +0100
@@ -1,0 +2,49 @@
+Sat Jan 23 10:09:14 UTC 2021 - Callum Farmer <[email protected]>
+
+- Update to 88.0.4324.96 bsc#1181137
+  - CVE-2021-21117: Insufficient policy enforcement in Cryptohome
+  - CVE-2021-21118: Insufficient data validation in V8
+  - CVE-2021-21119: Use after free in Media
+  - CVE-2021-21120: Use after free in WebSQL
+  - CVE-2021-21121: Use after free in Omnibox
+  - CVE-2021-21122: Use after free in Blink
+  - CVE-2021-21123: Insufficient data validation in File System API
+  - CVE-2021-21124: Potential user after free in Speech Recognizer
+  - CVE-2021-21125: Insufficient policy enforcement in File System API
+  - CVE-2020-16044: Use after free in WebRTC
+  - CVE-2021-21126: Insufficient policy enforcement in extensions
+  - CVE-2021-21127: Insufficient policy enforcement in extensions
+  - CVE-2021-21128: Heap buffer overflow in Blink
+  - CVE-2021-21129: Insufficient policy enforcement in File System API
+  - CVE-2021-21130: Insufficient policy enforcement in File System API
+  - CVE-2021-21131: Insufficient policy enforcement in File System API
+  - CVE-2021-21132: Inappropriate implementation in DevTools
+  - CVE-2021-21133: Insufficient policy enforcement in Downloads
+  - CVE-2021-21134: Incorrect security UI in Page Info
+  - CVE-2021-21135: Inappropriate implementation in Performance API
+  - CVE-2021-21136: Insufficient policy enforcement in WebView
+  - CVE-2021-21137: Inappropriate implementation in DevTools
+  - CVE-2021-21138: Use after free in DevTools
+  - CVE-2021-21139: Inappropriate implementation in iframe sandbox
+  - CVE-2021-21140: Uninitialized Use in USB
+  - CVE-2021-21141: Insufficient policy enforcement in File System API
+- Added patches:
+  - chromium-88-compiler.patch
+  - chromium-88-ozone-deps.patch
+  - chromium-88-ityp-include.patch
+  - chromium-88-AXTreeFormatter-include.patch
+  - chromium-88-BookmarkModelObserver-include.patch
+  - chromium-88-federated_learning-include.patch
+  - chromium-88-ideographicSpaceCharacter.patch
+  - chromium-88-StringPool-include.patch
+  - chromium-88-dawn-static.patch
+  - chromium-88-CompositorFrameReporter-dcheck.patch
+- Removed patches:
+  - gpu-timeout.patch
+  - chromium-87-compiler.patch
+  - chromium-87-ServiceWorkerContainerHost-crash.patch
+  - chromium-87-ozone-deps.patch
+  - chromium-87-v8-icu68.patch
+  - chromium-87-icu68.patch
+
+-------------------------------------------------------------------

Old:
----
  chromium-87-ServiceWorkerContainerHost-crash.patch
  chromium-87-compiler.patch
  chromium-87-icu68.patch
  chromium-87-ozone-deps.patch
  chromium-87-v8-icu68.patch
  chromium-87.0.4280.141.tar.xz
  gpu-timeout.patch

New:
----
  chromium-88-AXTreeFormatter-include.patch
  chromium-88-BookmarkModelObserver-include.patch
  chromium-88-CompositorFrameReporter-dcheck.patch
  chromium-88-StringPool-include.patch
  chromium-88-compiler.patch
  chromium-88-dawn-static.patch
  chromium-88-federated_learning-include.patch
  chromium-88-ideographicSpaceCharacter.patch
  chromium-88-ityp-include.patch
  chromium-88-ozone-deps.patch
  chromium-88.0.4324.96.tar.xz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ chromium.spec ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.211671099 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.215671104 +0100
@@ -49,7 +49,7 @@
 %endif
 %bcond_with clang
 Name:           chromium
-Version:        87.0.4280.141
+Version:        88.0.4324.96
 Release:        0
 Summary:        Google's open source browser project
 License:        BSD-3-Clause AND LGPL-2.1-or-later
@@ -73,7 +73,6 @@
 Patch5:         chromium-system-libusb.patch
 Patch6:         gcc-enable-lto.patch
 Patch7:         chromium-fix-char_traits.patch
-Patch8:         gpu-timeout.patch
 Patch9:         build-with-pipewire-0.3.patch
 # Do not use unrar code, it is non-free
 Patch10:        chromium-norar.patch
@@ -87,7 +86,7 @@
 Patch51:        chromium-79-gcc-protobuf-alignas.patch
 Patch52:        chromium-80-QuicStreamSendBuffer-deleted-move-constructor.patch
 Patch53:        chromium-84-blink-disable-clang-format.patch
-Patch54:        chromium-87-compiler.patch
+Patch54:        chromium-88-compiler.patch
 Patch55:        chromium-86-ConsumeDurationNumber-constexpr.patch
 Patch56:        chromium-86-ImageMemoryBarrierData-init.patch
 Patch57:        chromium-86-nearby-explicit.patch
@@ -96,13 +95,18 @@
 Patch61:        chromium-gcc11.patch
 Patch62:        chromium-87-CursorFactory-include.patch
 Patch63:        chromium-87-openscreen-include.patch
-Patch64:        chromium-87-ServiceWorkerContainerHost-crash.patch
 Patch65:        chromium-88-vaapi-attribute.patch
-Patch66:        chromium-87-ozone-deps.patch
+Patch66:        chromium-88-ozone-deps.patch
 Patch67:        chromium-87-webcodecs-deps.patch
 Patch68:        chromium-lp152-missing-includes.patch
-Patch69:        chromium-87-v8-icu68.patch
-Patch70:        chromium-87-icu68.patch
+Patch71:        chromium-88-ityp-include.patch
+Patch72:        chromium-88-AXTreeFormatter-include.patch
+Patch73:        chromium-88-BookmarkModelObserver-include.patch
+Patch74:        chromium-88-federated_learning-include.patch
+Patch75:        chromium-88-ideographicSpaceCharacter.patch
+Patch76:        chromium-88-StringPool-include.patch
+Patch77:        chromium-88-dawn-static.patch
+Patch78:        chromium-88-CompositorFrameReporter-dcheck.patch
 # Google seem not too keen on merging this but GPU accel is quite important
 #  https://chromium-review.googlesource.com/c/chromium/src/+/532294
 #  
https://github.com/saiarcot895/chromium-ubuntu-build/tree/master/debian/patches
@@ -380,7 +384,9 @@
     third_party/dom_distiller_js
     third_party/emoji-segmenter
     third_party/flatbuffers
+    third_party/fusejs/dist
     third_party/libgifcodec
+    third_party/libxcb-keysyms/keysyms
     third_party/glslang
     third_party/google_input_tools
     third_party/google_input_tools/third_party/closure_library
@@ -408,6 +414,7 @@
     third_party/libsync
     third_party/libudev
     third_party/libwebm
+    third_party/libx11/src
     third_party/libxml/chromium
     third_party/libyuv
     third_party/lottie
@@ -491,6 +498,7 @@
     third_party/widevine
     third_party/woff2
     third_party/wuffs
+    third_party/x11proto
     third_party/xcbproto
     third_party/zxcvbn-cpp
     third_party/zlib/google
@@ -790,6 +798,8 @@
 
 %fdupes %{buildroot}
 
+
+
 %files
 %license LICENSE
 %doc AUTHORS

++++++ build-with-pipewire-0.3.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.263671169 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.263671169 +0100
@@ -782,7 +782,7 @@
 +++ chromium-83.0.4103.116/third_party/webrtc/webrtc.gni
 @@ -114,6 +114,10 @@ declare_args() {
    # supported Ubuntu and Debian distributions.
-   rtc_use_pipewire = is_desktop_linux && use_sysroot
+   rtc_use_pipewire = is_linux && use_sysroot
  
 +  # Sets the pipewire pkg-config version to use if rtc_use_pipewire is true
 +  rtc_use_pipewire_version = "0.3"

++++++ chromium-86-nearby-explicit.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.295671213 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.295671213 +0100
@@ -4,13 +4,13 @@
 Subject: [PATCH] GCC: remove explicit from AtomicReference constructor
 
 ---
- .../nearby/src/cpp/platform_v2/public/atomic_reference.h        | 2 +-
+ .../nearby/src/cpp/platform/public/atomic_reference.h        | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-diff --git a/third_party/nearby/src/cpp/platform_v2/public/atomic_reference.h 
b/third_party/nearby/src/cpp/platform_v2/public/atomic_reference.h
+diff --git a/third_party/nearby/src/cpp/platform/public/atomic_reference.h 
b/third_party/nearby/src/cpp/platform/public/atomic_reference.h
 index 5742724..bbb8c01 100644
---- a/third_party/nearby/src/cpp/platform_v2/public/atomic_reference.h
-+++ b/third_party/nearby/src/cpp/platform_v2/public/atomic_reference.h
+--- a/third_party/nearby/src/cpp/platform/public/atomic_reference.h
++++ b/third_party/nearby/src/cpp/platform/public/atomic_reference.h
 @@ -37,7 +37,7 @@ class AtomicReference<T, std::enable_if_t<sizeof(T) <= 
sizeof(std::uint32_t) &&
      final {
   public:

++++++ chromium-86-nearby-include.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.307671229 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.307671229 +0100
@@ -4,15 +4,15 @@
 Subject: [PATCH] IWYU: memcpy is defined in cstring
 
 ---
- third_party/nearby/src/cpp/platform_v2/base/byte_array.h | 1 +
+ third_party/nearby/src/cpp/platform/base/byte_array.h | 1 +
  1 file changed, 1 insertion(+)
 
-diff --git a/third_party/nearby/src/cpp/platform_v2/base/byte_array.h 
b/third_party/nearby/src/cpp/platform_v2/base/byte_array.h
+diff --git a/third_party/nearby/src/cpp/platform/base/byte_array.h 
b/third_party/nearby/src/cpp/platform/base/byte_array.h
 index ee5d0eb..4b1d79b 100644
---- a/third_party/nearby/src/cpp/platform_v2/base/byte_array.h
-+++ b/third_party/nearby/src/cpp/platform_v2/base/byte_array.h
-@@ -17,6 +17,7 @@
- 
+--- a/third_party/nearby/src/cpp/platform/base/byte_array.h
++++ b/third_party/nearby/src/cpp/platform/base/byte_array.h
+@@ -18,6 +18,7 @@
+ #include <algorithm>
  #include <array>
  #include <cstdint>
 +#include <cstring>

++++++ chromium-88-AXTreeFormatter-include.patch ++++++
>From 6e402d97c2dec5726f37e95f97b7f7e12b1d3b1d Mon Sep 17 00:00:00 2001
From: Jose Dapena Paz <[email protected]>
Date: Wed, 11 Nov 2020 11:02:13 +0100
Subject: [PATCH] IWYU: include headers for std::vector and std::unique_ptr in 
AXTreeFormatter

Fix these build errors with libstdc++:
../../ui/accessibility/platform/inspect/tree_formatter.h:35:12: error: 
???std::vector??? has not been declared
../../ui/accessibility/platform/inspect/tree_formatter.h:61:16: error: 
???unique_ptr??? in namespace ???std??? does not name a template type

Bug: 957519
Change-Id: I402ac0644255b3cd4932ff2fe72d999b125a7895
---

diff --git a/ui/accessibility/platform/inspect/tree_formatter.h 
b/ui/accessibility/platform/inspect/tree_formatter.h
index 4a70a4d..bb23768 100644
--- a/ui/accessibility/platform/inspect/tree_formatter.h
+++ b/ui/accessibility/platform/inspect/tree_formatter.h
@@ -5,6 +5,9 @@
 #ifndef UI_ACCESSIBILITY_PLATFORM_INSPECT_TREE_FORMATTER_H_
 #define UI_ACCESSIBILITY_PLATFORM_INSPECT_TREE_FORMATTER_H_
 
+#include <memory>
+#include <vector>
+
 #include "ui/accessibility/platform/inspect/inspect.h"
 
 #include "ui/gfx/native_widget_types.h"
++++++ chromium-88-BookmarkModelObserver-include.patch ++++++
>From 127ec3b1bf26ab37f2ae8333f284008868756274 Mon Sep 17 00:00:00 2001
From: Stephan Hartmann <[email protected]>
Date: Sat, 21 Nov 2020 15:59:23 +0000
Subject: [PATCH] IWYU: size_t is defined stddef.h

Change-Id: I4400ac7c6004b49ec6e72c44f2754e2166642f88
---

diff --git a/components/bookmarks/browser/bookmark_model_observer.h 
b/components/bookmarks/browser/bookmark_model_observer.h
index 69c40e7..0e5eb96 100644
--- a/components/bookmarks/browser/bookmark_model_observer.h
+++ b/components/bookmarks/browser/bookmark_model_observer.h
@@ -7,6 +7,8 @@
 
 #include <set>
 
+#include <stddef.h>
+
 class GURL;
 
 namespace bookmarks {
++++++ chromium-88-CompositorFrameReporter-dcheck.patch ++++++
>From 56c654a91600e3bf254aa9f66c1151b0850b6ee4 Mon Sep 17 00:00:00 2001
From: Jose Dapena Paz <[email protected]>
Date: Wed, 11 Nov 2020 10:24:47 +0100
Subject: [PATCH] GCC: do not pass unique_ptr to DCHECK_NE, but the actual 
pointer, in CompositorFrameReporter

DCHECK_NE comparison requires CheckOpValueStr to be defined for the
type, or providing an output stream operator. A unique_ptr does not
provide any.

Compilation in GCC is failing in CompositorFrameReporter because of
this:
../../cc/metrics/compositor_frame_reporter.cc: In member function ???void 
cc::CompositorFrameReporter::ReportEventLatencyHistograms() const???:
../../base/check_op.h:224:59: error: no matching function for call to 
???CheckOpValueStr(const std::unique_ptr<cc::EventMetrics>&)???

Fixed comparing the result of get() method for unique_ptr instead of
the unique_ptr.

Bug: 819294
Change-Id: I11103d1867c7196c1de92e72f9f12dcfd31c29f1

(updated to use DCHECK as suggested in comments)
---

diff --git a/cc/metrics/compositor_frame_reporter.cc 
b/cc/metrics/compositor_frame_reporter.cc
index 725beb0..fafd0f3 100644
--- a/cc/metrics/compositor_frame_reporter.cc
+++ b/cc/metrics/compositor_frame_reporter.cc
@@ -686,7 +686,7 @@
 
 void CompositorFrameReporter::ReportEventLatencyHistograms() const {
   for (const auto& event_metrics : events_metrics_) {
-    DCHECK_NE(event_metrics, nullptr);
+    DCHECK(event_metrics);
     const std::string histogram_base_name =
         GetEventLatencyHistogramBaseName(*event_metrics);
     const int event_type_index = static_cast<int>(event_metrics->type());
++++++ chromium-88-StringPool-include.patch ++++++
>From 372366b4180533f27d3250a50810828370d697b0 Mon Sep 17 00:00:00 2001
From: Stephan Hartmann <[email protected]>
Date: Sat, 21 Nov 2020 16:12:18 +0000
Subject: [PATCH] IWYU: include limits for std::numeric_limits

Change-Id: Ia5226e1432a622f4f4abc8f1b18bcab8638a73c6
---

diff --git a/src/trace_processor/containers/string_pool.h 
b/src/trace_processor/containers/string_pool.h
index 11ae91c..58c6db2 100644
--- a/third_party/perfetto/src/trace_processor/containers/string_pool.h
+++ b/third_party/perfetto/src/trace_processor/containers/string_pool.h
@@ -22,6 +22,7 @@
 
 #include <unordered_map>
 #include <vector>
+#include <limits>
 
 #include "perfetto/ext/base/optional.h"
 #include "perfetto/ext/base/paged_memory.h"
++++++ chromium-87-compiler.patch -> chromium-88-compiler.patch ++++++
--- /work/SRC/openSUSE:Factory/chromium/chromium-87-compiler.patch      
2020-11-23 18:38:55.700649473 +0100
+++ /work/SRC/openSUSE:Factory/.chromium.new.28504/chromium-88-compiler.patch   
2021-01-26 14:45:08.823292115 +0100
@@ -1,14 +1,14 @@
 From f4d0b0eb899005b4b8b6388e1d8bb82cc0018fc8 Mon Sep 17 00:00:00 2001
 From: Mike Gilbert <[email protected]>
-Date: Thu, 1 Oct 2020 18:14:51 +0000
+Date: Sun, 15 Nov 2020 08:37:23 +0000
 Subject: [PATCH] Disable various compiler configs
 
 ---
- build/config/compiler/BUILD.gn | 71 ++++++++--------------------------
- 1 file changed, 17 insertions(+), 54 deletions(-)
+ build/config/compiler/BUILD.gn | 52 +++++++++++-----------------------
+ 1 file changed, 17 insertions(+), 35 deletions(-)
 
 diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
-index 4f6461b..b5d2c77 100644
+index 9d66490..a2bc09e 100644
 --- a/build/config/compiler/BUILD.gn
 +++ b/build/config/compiler/BUILD.gn
 @@ -254,8 +254,6 @@ config("compiler") {
@@ -20,7 +20,7 @@
      ":compiler_codegen",
      ":compiler_deterministic",
    ]
-@@ -480,36 +478,6 @@ config("compiler") {
+@@ -478,17 +476,6 @@ config("compiler") {
      ldflags += [ "-Wl,-z,keep-text-section-prefix" ]
    }
  
@@ -33,31 +33,12 @@
 -      "-mllvm",
 -      "-instcombine-lower-dbg-declare=0",
 -    ]
--
--    # Pinned clang has enable-dse-memoryssa enabled by default but it's 
broken,
--    # so we have to force it off.
--    # Trunk clang has it disabled by default but it might work, so we force it
--    # on so the ToT bots can check if it works now.
--    if (!llvm_force_head_revision) {
--      cflags += [
--        # TODO(https://crbug.com/1127713): Investigate, remove.
--        "-mllvm",
--        "-enable-dse-memoryssa=false",
--      ]
--    }
--    if (llvm_force_head_revision) {
--      cflags += [
--        # TODO(https://crbug.com/1127713): Investigate, remove.
--        "-mllvm",
--        "-enable-dse-memoryssa=true",
--      ]
--    }
 -  }
 -
    # C11/C++11 compiler flags setup.
    # ---------------------------
    if (is_linux || is_chromeos || is_android || (is_nacl && is_clang) ||
-@@ -1571,7 +1539,7 @@ config("chromium_code") {
+@@ -1574,7 +1561,7 @@ config("chromium_code") {
        defines = [ "_HAS_NODISCARD" ]
      }
    } else {
@@ -66,7 +47,7 @@
      if (treat_warnings_as_errors) {
        cflags += [ "-Werror" ]
  
-@@ -1580,10 +1548,6 @@ config("chromium_code") {
+@@ -1583,10 +1570,6 @@ config("chromium_code") {
        # well.
        ldflags = [ "-Werror" ]
      }
@@ -77,7 +58,7 @@
  
      # In Chromium code, we define __STDC_foo_MACROS in order to get the
      # C99 macros on Mac and Linux.
-@@ -1592,15 +1556,6 @@ config("chromium_code") {
+@@ -1595,15 +1578,6 @@ config("chromium_code") {
        "__STDC_FORMAT_MACROS",
      ]
  
@@ -93,7 +74,7 @@
      if (is_mac) {
        cflags_objc = [ "-Wobjc-missing-property-synthesis" ]
        cflags_objcc = [ "-Wobjc-missing-property-synthesis" ]
-@@ -1998,7 +1953,8 @@ config("default_stack_frames") {
+@@ -2006,7 +1980,8 @@ config("default_stack_frames") {
  }
  
  # Default "optimization on" config.
@@ -103,7 +84,7 @@
    if (is_win) {
      if (chrome_pgo_phase != 2) {
        # Favor size over speed, /O1 must be before the common flags.
-@@ -2033,7 +1989,8 @@ config("optimize") {
+@@ -2041,7 +2016,8 @@ config("optimize") {
  }
  
  # Turn off optimizations.
@@ -113,7 +94,7 @@
    if (is_win) {
      cflags = [
        "/Od",  # Disable optimization.
-@@ -2073,7 +2030,8 @@ config("no_optimize") {
+@@ -2081,7 +2057,8 @@ config("no_optimize") {
  # Turns up the optimization level. On Windows, this implies whole program
  # optimization and link-time code generation which is very expensive and 
should
  # be used sparingly.
@@ -123,7 +104,7 @@
    if (is_nacl && is_nacl_irt) {
      # The NaCl IRT is a special case and always wants its own config.
      # Various components do:
-@@ -2105,7 +2063,8 @@ config("optimize_max") {
+@@ -2113,7 +2090,8 @@ config("optimize_max") {
  #
  # TODO(crbug.com/621335) - rework how all of these configs are related
  # so that we don't need this disclaimer.
@@ -133,7 +114,7 @@
    if (is_nacl && is_nacl_irt) {
      # The NaCl IRT is a special case and always wants its own config.
      # Various components do:
-@@ -2130,7 +2089,8 @@ config("optimize_speed") {
+@@ -2138,7 +2116,8 @@ config("optimize_speed") {
    }
  }
  
@@ -143,7 +124,7 @@
    cflags = [ "-O1" ] + common_optimize_on_cflags
    ldflags = common_optimize_on_ldflags
    visibility = [ ":default_optimization" ]
-@@ -2247,7 +2207,8 @@ config("win_pdbaltpath") {
+@@ -2267,7 +2246,8 @@ config("win_pdbaltpath") {
  }
  
  # Full symbols.
@@ -153,7 +134,7 @@
    if (is_win) {
      if (is_clang) {
        cflags = [ "/Z7" ]  # Debug information in the .obj files.
-@@ -2355,7 +2316,8 @@ config("symbols") {
+@@ -2365,7 +2345,8 @@ config("symbols") {
  # Minimal symbols.
  # This config guarantees to hold symbol for stack trace which are shown to 
user
  # when crash happens in unittests running on buildbot.
@@ -163,7 +144,7 @@
    if (is_win) {
      # Functions, files, and line tables only.
      cflags = []
-@@ -2408,7 +2370,8 @@ config("minimal_symbols") {
+@@ -2418,7 +2399,8 @@ config("minimal_symbols") {
  # This configuration contains function names only. That is, the compiler is
  # told to not generate debug information and the linker then just puts 
function
  # names in the final debug information.

++++++ chromium-88-dawn-static.patch ++++++
>From 75a1f5234e4b544b4d16eddb995d39685da21361 Mon Sep 17 00:00:00 2001
From: Ivan Murashov <[email protected]>
Date: Fri, 20 Nov 2020 09:38:56 +0000
Subject: [PATCH] Remove storage class specifier for the explicit template 
specialization

According to the http://www.eel.is/c++draft/temp.expl.spec:
An explicit specialization shall not use a storage-class-specifier
other than thread_local.
Clang doesn't claims about it, but GCC does.
An error example for GCC 8.4.0:
gen/third_party/dawn/src/dawn_wire/client/ApiObjects_autogen.h:25:5:
error: explicit template specialization cannot have a storage class

Bug: dawn:384
Change-Id: Iaf86722a943d19c9796a7f112885666ac88f20ca
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/33480
Commit-Queue: Corentin Wallez <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
---

diff --git a/third_party/dawn/generator/templates/dawn_wire/client/ApiObjects.h 
b/third_party/dawn/generator/templates/dawn_wire/client/ApiObjects.h
index 0d8421b..bbf9817 100644
--- a/third_party/dawn/generator/templates/dawn_wire/client/ApiObjects.h
+++ b/third_party/dawn/generator/templates/dawn_wire/client/ApiObjects.h
@@ -21,7 +21,9 @@
 namespace dawn_wire { namespace client {
 
     template <typename T>
-    static constexpr ObjectType ObjectTypeToTypeEnum = 
static_cast<ObjectType>(-1);
+    struct ObjectTypeToTypeEnum {
+        static constexpr ObjectType value = static_cast<ObjectType>(-1);
+    };
 
     {% for type in by_category["object"] %}
         {% set Type = type.name.CamelCase() %}
@@ -41,7 +43,9 @@
         }
 
         template <>
-        static constexpr ObjectType 
ObjectTypeToTypeEnum<{{type.name.CamelCase()}}> = 
ObjectType::{{type.name.CamelCase()}};
+        struct ObjectTypeToTypeEnum<{{Type}}> {
+            static constexpr ObjectType value = ObjectType::{{Type}};
+        };
 
     {% endfor %}
 }}  // namespace dawn_wire::client
diff --git a/third_party/dawn/src/dawn_wire/client/Device.h 
b/third_party/dawn/src/dawn_wire/client/Device.h
index eef03a5..a0036a4 100644
--- a/third_party/dawn/src/dawn_wire/client/Device.h
+++ b/third_party/dawn/src/dawn_wire/client/Device.h
@@ -65,7 +65,7 @@
 
         template <typename T>
         void TrackObject(T* object) {
-            mObjects[ObjectTypeToTypeEnum<T>].Append(object);
+            mObjects[ObjectTypeToTypeEnum<T>::value].Append(object);
         }
 
         void CancelCallbacksForDisconnect() override;
++++++ chromium-88-federated_learning-include.patch ++++++
>From bcb20babee602b55fe4bd026e13a41d10b89632f Mon Sep 17 00:00:00 2001
From: Stephan Hartmann <[email protected]>
Date: Sat, 21 Nov 2020 15:55:02 +0000
Subject: [PATCH] IWYU: include limits for std::numeric_limits

Change-Id: I1b6b07ebb397a29c84d3ed51ae41523e3ecab497
---

diff --git a/components/federated_learning/floc_constants.cc 
b/components/federated_learning/floc_constants.cc
index df66e5d..2eb50f1 100644
--- a/components/federated_learning/floc_constants.cc
+++ b/components/federated_learning/floc_constants.cc
@@ -4,6 +4,8 @@
 
 #include "components/federated_learning/floc_constants.h"
 
+#include <limits>
+
 namespace federated_learning {
 
 // This is only for experimentation and won't be served to websites.
++++++ chromium-88-ideographicSpaceCharacter.patch ++++++
>From 75ff882bb5f2fcd14431e65fa638ae72bdb47086 Mon Sep 17 00:00:00 2001
From: Stephan Hartmann <[email protected]>
Date: Sun, 15 Nov 2020 14:31:23 +0000
Subject: [PATCH] fix ideographicSpaceCharacter constant for system icu

https://chromium-review.googlesource.com/c/chromium/src/+/1687411
renamed ideographicSpaceCharacter to kIdeographicSpaceCharacter.
---
 third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc 
b/third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc
index fb8ab05..5d4ea13 100644
--- a/third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc
+++ b/third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc
@@ -432,7 +432,7 @@ String TextCodecICU::Decode(const char* bytes,
   // ICU decodes it as U+E5E5.
   if (!strcmp(encoding_.GetName(), "GBK")) {
     if (EqualIgnoringASCIICase(encoding_.GetName(), "gb18030"))
-      resultString.Replace(0xE5E5, ideographicSpaceCharacter);
+      resultString.Replace(0xE5E5, kIdeographicSpaceCharacter);
     // Make GBK compliant to the encoding spec and align with GB18030
     resultString.Replace(0x01F9, 0xE7C8);
     // FIXME: Once https://www.w3.org/Bugs/Public/show_bug.cgi?id=28740#c3
-- 
2.26.2

++++++ chromium-88-ityp-include.patch ++++++
>From bc383a5dd7fa8f2b535f28815fd6932fbc0d2a45 Mon Sep 17 00:00:00 2001
From: Stephan Hartmann <[email protected]>
Date: Wed, 28 Oct 2020 16:00:35 +0000
Subject: [PATCH] IWYU: include stddef.h for size_t

---
 third_party/dawn/src/common/ityp_array.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/third_party/dawn/src/common/ityp_array.h 
b/third_party/dawn/src/common/ityp_array.h
index 48e080f..c784198 100644
--- a/third_party/dawn/src/common/ityp_array.h
+++ b/third_party/dawn/src/common/ityp_array.h
@@ -21,6 +21,8 @@
 #include <array>
 #include <type_traits>
 
+#include <stddef.h>
+
 namespace ityp {
 
     // ityp::array is a helper class that wraps std::array with the 
restriction that
-- 
2.26.2

++++++ chromium-87-ozone-deps.patch -> chromium-88-ozone-deps.patch ++++++
--- /work/SRC/openSUSE:Factory/chromium/chromium-87-ozone-deps.patch    
2020-11-23 18:38:55.776649551 +0100
+++ /work/SRC/openSUSE:Factory/.chromium.new.28504/chromium-88-ozone-deps.patch 
2021-01-26 14:45:09.603293322 +0100
@@ -1,15 +1,39 @@
-diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
-index 3f89c70..0df6490 100644
---- a/chrome/browser/BUILD.gn
-+++ b/chrome/browser/BUILD.gn
-@@ -5056,7 +5056,9 @@ static_library("browser") {
-       "chrome_browser_main_extra_parts_ozone.cc",
-       "chrome_browser_main_extra_parts_ozone.h",
-     ]
--    deps += [ "//ui/ozone" ]
-+    if (use_ozone) {
-+      deps += [ "//ui/ozone" ]
-+    }
-   }
+From a5a6050ed551972faaaa65ebc2b4e7e1958738a1 Mon Sep 17 00:00:00 2001
+From: Stephan Hartmann <[email protected]>
+Date: Fri, 6 Nov 2020 16:17:30 +0000
+Subject: [PATCH] fix building without Ozone
+
+When building with use_x11=true and use_ozone=false build fails,
+because features::IsUsingOzonePlatform() is not defined:
+
+../../content/browser/gpu/gpu_internals_ui.cc: In function
+'std::unique_ptr<base::ListValue>
+content::{anonymous}::GpuMemoryBufferInfo(const gfx::GpuExtraInfo&)'
+../../content/browser/gpu/gpu_internals_ui.cc:397:18: error:
+'IsUsingOzonePlatform' is not a member of 'features'
+  397 |   if (!features::IsUsingOzonePlatform()) {
+      |                  ^~~~~~~~~~~~~~~~~~~~
+---
+ content/browser/gpu/gpu_internals_ui.cc | 7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/content/browser/gpu/gpu_internals_ui.cc 
b/content/browser/gpu/gpu_internals_ui.cc
+index 4f07186..01dfcbf 100644
+--- a/content/browser/gpu/gpu_internals_ui.cc
++++ b/content/browser/gpu/gpu_internals_ui.cc
+@@ -394,7 +394,12 @@ std::unique_ptr<base::ListValue> GpuMemoryBufferInfo(
  
-   if (enable_background_mode) {
+   gpu::GpuMemoryBufferConfigurationSet native_config;
+ #if defined(USE_X11)
+-  if (!features::IsUsingOzonePlatform()) {
++#if defined(USE_OZONE)
++  const auto is_using_ozone_platform = features::IsUsingOzonePlatform();
++#else
++  const auto is_using_ozone_platform = false;
++#endif
++  if (!is_using_ozone_platform) {
+     for (const auto& config : gpu_extra_info.gpu_memory_buffer_support_x11) {
+       native_config.emplace(config);
+     }
+-- 
+2.26.2

++++++ chromium-87.0.4280.141.tar.xz -> chromium-88.0.4324.96.tar.xz ++++++
/work/SRC/openSUSE:Factory/chromium/chromium-87.0.4280.141.tar.xz 
/work/SRC/openSUSE:Factory/.chromium.new.28504/chromium-88.0.4324.96.tar.xz 
differ: char 26, line 1

++++++ chromium-gcc11.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.467671448 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.467671448 +0100
@@ -1,15 +1,3 @@
-diff --git 
a/third_party/abseil-cpp/absl/synchronization/internal/graphcycles.cc 
b/third_party/abseil-cpp/absl/synchronization/internal/graphcycles.cc
-index 19f9aab5b..8073637e9 100644
---- a/third_party/abseil-cpp/absl/synchronization/internal/graphcycles.cc
-+++ b/third_party/abseil-cpp/absl/synchronization/internal/graphcycles.cc
-@@ -35,6 +35,7 @@
- 
- #include "absl/synchronization/internal/graphcycles.h"
- 
-+#include <limits>
- #include <algorithm>
- #include <array>
- #include "absl/base/internal/hide_ptr.h"
 diff --git a/third_party/angle/src/libANGLE/HandleAllocator.cpp 
b/third_party/angle/src/libANGLE/HandleAllocator.cpp
 index 013f1dfb2..3ce63c192 100644
 --- a/third_party/angle/src/libANGLE/HandleAllocator.cpp
@@ -137,24 +125,3 @@
  #include "components/bookmarks/browser/base_bookmark_model_observer.h"
  
  namespace bookmarks {
-diff -up chromium-87.0.4280.88/net/dns/dns_server_iterator.h.missing-cstddef 
chromium-87.0.4280.88/net/dns/dns_server_iterator.h
---- chromium-87.0.4280.88/net/dns/dns_server_iterator.h.missing-cstddef        
2020-12-15 15:35:38.935281593 -0500
-+++ chromium-87.0.4280.88/net/dns/dns_server_iterator.h        2020-12-15 
15:35:59.408368520 -0500
-@@ -5,6 +5,7 @@
- #ifndef NET_DNS_DNS_SERVER_ITERATOR_H_
- #define NET_DNS_DNS_SERVER_ITERATOR_H_
- 
-+#include <cstddef>
- #include <vector>
- 
- #include "net/base/net_export.h"
-diff -up 
chromium-87.0.4280.88/components/federated_learning/floc_constants.cc.missing-limits
 chromium-87.0.4280.88/components/federated_learning/floc_constants.cc
---- 
chromium-87.0.4280.88/components/federated_learning/floc_constants.cc.missing-limits
       2020-12-16 13:51:38.675421401 -0500
-+++ chromium-87.0.4280.88/components/federated_learning/floc_constants.cc      
2020-12-16 13:51:50.625467423 -0500
-@@ -3,6 +3,7 @@
- // found in the LICENSE file.
- 
- #include "components/federated_learning/floc_constants.h"
-+#include <limits>
- 
- namespace federated_learning {

++++++ chromium-lp152-missing-includes.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.483671469 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.483671469 +0100
@@ -7,5 +7,4 @@
 +#include <vector>
  #include <string>
 
- #include "base/macros.h"
-
+ #include "base/gtest_prod_util.h"

++++++ chromium-norar.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.495671486 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.495671486 +0100
@@ -2,10 +2,10 @@
 ===================================================================
 --- chromium-86.0.4240.75.orig/chrome/common/safe_browsing/BUILD.gn
 +++ chromium-86.0.4240.75/chrome/common/safe_browsing/BUILD.gn
-@@ -43,39 +43,6 @@ if (safe_browsing_mode == 1) {
+@@ -43,38 +43,6 @@
      public_deps = [ "//components/safe_browsing/core:csd_proto" ]
    }
- 
+
 -  source_set("rar_analyzer") {
 -    sources = [
 -      "rar_analyzer.cc",
@@ -38,10 +38,9 @@
 -
 -    public_deps = [ "//components/safe_browsing/core:csd_proto" ]
 -  }
--
-   source_set("disk_image_type_sniffer_mac") {
-     sources = [
-       "disk_image_type_sniffer_mac.cc",
+
+   if (is_mac) {
+     source_set("disk_image_type_sniffer_mac") {
 @@ -138,7 +105,6 @@ source_set("safe_browsing") {
        ":archive_analyzer_results",
        ":binary_feature_extractor",


++++++ chromium-vaapi.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.511671507 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.511671507 +0100
@@ -1,17 +1,7 @@
-Index: chromium-86.0.4240.75/chrome/browser/about_flags.cc
-===================================================================
---- chromium-86.0.4240.75.orig/chrome/browser/about_flags.cc
-+++ chromium-86.0.4240.75/chrome/browser/about_flags.cc
-@@ -2647,7 +2647,7 @@ const FeatureEntry kFeatureEntries[] = {
-         "disable-accelerated-video-decode",
-         flag_descriptions::kAcceleratedVideoDecodeName,
-         flag_descriptions::kAcceleratedVideoDecodeDescription,
--        kOsMac | kOsWin | kOsCrOS | kOsAndroid,
-+        kOsMac | kOsWin | kOsCrOS | kOsAndroid | kOsLinux,
-         SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedVideoDecode),
-     },
- #endif  // defined(OS_LINUX) && !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
-@@ -3112,10 +3112,10 @@ const FeatureEntry kFeatureEntries[] = {
+diff -up chromium-88.0.4324.11/chrome/browser/about_flags.cc.accel-mjpeg 
chromium-88.0.4324.11/chrome/browser/about_flags.cc
+--- chromium-88.0.4324.11/chrome/browser/about_flags.cc.accel-mjpeg    
2020-11-19 20:51:19.000000000 -0500
++++ chromium-88.0.4324.11/chrome/browser/about_flags.cc        2020-11-30 
16:14:32.393366384 -0500
+@@ -3309,12 +3309,12 @@ const FeatureEntry kFeatureEntries[] = {
       flag_descriptions::kWebXrForceRuntimeDescription, kOsDesktop,
       MULTI_VALUE_TYPE(kWebXrForceRuntimeChoices)},
  #endif  // ENABLE_VR
@@ -22,42 +12,48 @@
 -     flag_descriptions::kAcceleratedMjpegDecodeDescription, kOsCrOS,
 +     flag_descriptions::kAcceleratedMjpegDecodeDescription, kOsCrOS | 
kOsLinux,
       SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedMjpegDecode)},
- #endif  // OS_CHROMEOS
+-#endif  // OS_CHROMEOS
++#endif  // OS_CHROMEOS || OS_LINUX
      {"system-keyboard-lock", flag_descriptions::kSystemKeyboardLockName,
-Index: chromium-86.0.4240.75/chrome/browser/flag_descriptions.cc
-===================================================================
---- chromium-86.0.4240.75.orig/chrome/browser/flag_descriptions.cc
-+++ chromium-86.0.4240.75/chrome/browser/flag_descriptions.cc
-@@ -3519,15 +3519,20 @@ const char kVideoToolboxVp9DecodingDescr
+      flag_descriptions::kSystemKeyboardLockDescription, kOsDesktop,
+      FEATURE_VALUE_TYPE(features::kSystemKeyboardLock)},
+diff -up chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc.accel-mjpeg 
chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc
+--- chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc.accel-mjpeg      
2020-11-30 16:14:32.393366384 -0500
++++ chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc  2020-11-30 
16:20:50.174195910 -0500
+@@ -3572,9 +3572,9 @@ const char kVideoToolboxVp9DecodingDescr
  
  #endif
  
 -// Chrome OS 
-------------------------------------------------------------------
-+// Chrome OS & 
Linux------------------------------------------------------------
++// Chrome OS and Linux 
---------------------------------------------------------
  
 -#if defined(OS_CHROMEOS)
-+#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID))
++#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID)) 
  
  const char kAcceleratedMjpegDecodeName[] =
      "Hardware-accelerated mjpeg decode for captured frame";
- const char kAcceleratedMjpegDecodeDescription[] =
+@@ -3582,6 +3582,12 @@ const char kAcceleratedMjpegDecodeDescri
      "Enable hardware-accelerated mjpeg decode for captured frame where "
      "available.";
+ 
 +#endif
 +
 +// Chrome OS 
-------------------------------------------------------------------
 +
 +#if defined(OS_CHROMEOS)
++
+ const char kAllowDisableMouseAccelerationName[] =
+     "Allow disabling mouse acceleration";
+ const char kAllowDisableMouseAccelerationDescription[] =
+diff -up chromium-88.0.4324.11/chrome/browser/flag_descriptions.h.accel-mjpeg 
chromium-88.0.4324.11/chrome/browser/flag_descriptions.h
+--- chromium-88.0.4324.11/chrome/browser/flag_descriptions.h.accel-mjpeg       
2020-11-30 16:14:32.394366389 -0500
++++ chromium-88.0.4324.11/chrome/browser/flag_descriptions.h   2020-11-30 
16:22:13.831601058 -0500
+@@ -2068,13 +2068,19 @@ extern const char kVideoToolboxVp9Decodi
  
- const char kAggregatedMlAppRankingName[] = "Rank suggested apps with ML.";
- const char kAggregatedMlAppRankingDescription[] =
-Index: chromium-86.0.4240.75/chrome/browser/flag_descriptions.h
-===================================================================
---- chromium-86.0.4240.75.orig/chrome/browser/flag_descriptions.h
-+++ chromium-86.0.4240.75/chrome/browser/flag_descriptions.h
-@@ -2028,11 +2028,15 @@ extern const char kVideoToolboxVp9Decodi
+ #endif  // defined(OS_MAC)
  
- // Chrome OS 
------------------------------------------------------------------
+-// Chrome OS 
------------------------------------------------------------------
++// Chrome OS and Linux 
--------------------------------------------------------
  
 -#if defined(OS_CHROMEOS)
 +#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID))
@@ -67,20 +63,9 @@
  
 +#endif
 +
++// Chrome OS 
------------------------------------------------------------------
++
 +#if defined(OS_CHROMEOS)
 +
- extern const char kAggregatedMlAppRankingName[];
- extern const char kAggregatedMlAppRankingDescription[];
- 
-Index: chromium-86.0.4240.75/gpu/config/software_rendering_list.json
-===================================================================
---- chromium-86.0.4240.75.orig/gpu/config/software_rendering_list.json
-+++ chromium-86.0.4240.75/gpu/config/software_rendering_list.json
-@@ -353,6 +353,7 @@
-           "gl_renderer": ".*SVGA3D.*"
-         }
-       ],
-+      "vendor_id": "0x10de",
-       "features": [
-         "all"
-       ]
+ extern const char kAllowDisableMouseAccelerationName[];
+ extern const char kAllowDisableMouseAccelerationDescription[];

++++++ gcc-enable-lto.patch ++++++
--- /var/tmp/diff_new_pack.AvZZ4T/_old  2021-01-26 14:49:40.539671545 +0100
+++ /var/tmp/diff_new_pack.AvZZ4T/_new  2021-01-26 14:49:40.539671545 +0100
@@ -8,9 +8,9 @@
  
 +  gcc_lto = false
 +
-   # Whether we're a traditional desktop unix.
-   is_desktop_linux = current_os == "linux"
- 
+   # Set to true when compiling with the Clang compiler.
+   is_clang = current_os != "linux" ||
+              (current_cpu != "s390x" && current_cpu != "s390" &&
 @@ -441,6 +443,12 @@ default_compiler_configs = [
    "//build/config/sanitizers:default_sanitizer_flags",
  ]
@@ -44,12 +44,12 @@
 --- chromium-85.0.4183.69.orig/sandbox/linux/BUILD.gn
 +++ chromium-85.0.4183.69/sandbox/linux/BUILD.gn
 @@ -250,6 +250,9 @@ component("seccomp_bpf") {
-     "//base/third_party/dynamic_annotations",
+     "//build:chromeos_buildflags",
      "//sandbox:sandbox_buildflags",
    ]
 +  if (gcc_lto) {
 +    configs -= [ "//build/config/compiler:gcc_lto" ]
 +  }
  
-   if (is_nacl_nonsfi) {
-     cflags = [ "-fgnu-inline-asm" ]
+   if (is_android) {
+     sources += [

Reply via email to