Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package virtualbox for openSUSE:Factory
checked in at 2021-02-01 14:41:25
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/virtualbox (Old)
and /work/SRC/openSUSE:Factory/.virtualbox.new.28504 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virtualbox"
Mon Feb 1 14:41:25 2021 rev:211 rq:867573 version:6.1.18
Changes:
--------
--- /work/SRC/openSUSE:Factory/virtualbox/virtualbox.changes 2021-01-27
18:56:45.744296690 +0100
+++ /work/SRC/openSUSE:Factory/.virtualbox.new.28504/virtualbox.changes
2021-02-01 14:41:26.896645823 +0100
@@ -1,0 +2,5 @@
+Sat Jan 23 21:28:37 UTC 2021 - Larry Finger <larry.fin...@gmail.com>
+- Fix additional problem with modal dialog parent.
+ Fixes CVE-2021-2074, boo#1181197 and CVE-2021-2129, boo#1181198.
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ vb-6.1.16-modal-dialog-parent.patch ++++++
--- /var/tmp/diff_new_pack.IsGimP/_old 2021-02-01 14:41:28.640648323 +0100
+++ /var/tmp/diff_new_pack.IsGimP/_new 2021-02-01 14:41:28.644648328 +0100
@@ -1,7 +1,7 @@
-Index:
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsExtension.cpp
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsExtension.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsExtension.cpp
-+++
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsExtension.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsExtension.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsExtension.cpp
@@ -16,6 +16,7 @@
*/
@@ -19,10 +19,10 @@
QString strFilePath;
if (!fileNames.isEmpty())
-Index:
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp
-+++
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/widgets/UIFilePathSelector.cpp
@@ -397,10 +397,10 @@ void UIFilePathSelector::selectPath()
switch (m_enmMode)
{
@@ -45,10 +45,10 @@
}
/* Do nothing if nothing chosen: */
-Index:
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/widgets/UIEmptyFilePathSelector.cpp
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/widgets/UIEmptyFilePathSelector.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/widgets/UIEmptyFilePathSelector.cpp
-+++
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/widgets/UIEmptyFilePathSelector.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/widgets/UIEmptyFilePathSelector.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/widgets/UIEmptyFilePathSelector.cpp
@@ -232,16 +232,16 @@ void UIEmptyFilePathSelector::choose()
switch (mMode)
{
@@ -69,10 +69,10 @@
}
if (path.isEmpty())
return;
-Index:
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp
-+++
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp
@@ -438,7 +438,7 @@ void UIMediumSelector::sltButtonLeaveEmp
void UIMediumSelector::sltAddMedium()
@@ -82,10 +82,10 @@
if (uMediumID.isNull())
return;
repopulateTreeWidget();
-Index: VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
+Index: VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
-+++ VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
++++ VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp
@@ -3197,7 +3197,7 @@ void UICommon::updateMachineStorage(cons
}
else if (target.type ==
UIMediumTarget::UIMediumTargetType_WithFileDialog)
@@ -95,10 +95,10 @@
strMachineFolder, false /* fUseLastFolder */);
}
else if(target.type ==
UIMediumTarget::UIMediumTargetType_CreateAdHocVISO)
-Index:
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp
-+++
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp
@@ -486,7 +486,7 @@ void UIMediumManagerWidget::sltHandleMac
void UIMediumManagerWidget::sltAddMedium()
{
@@ -108,10 +108,10 @@
strDefaultMachineFolder, true
/* use most recent medium folder */);
}
-Index:
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp
===================================================================
----
VirtualBox-6.1.16.orig/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp
-+++
VirtualBox-6.1.16/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp
@@ -3958,7 +3958,7 @@ void UIMachineSettingsStorage::sltChoose
{
const QString
strMachineFolder(QFileInfo(m_strMachineSettingsFilePath).absolutePath());
@@ -121,3 +121,38 @@
if (uMediumId.isNull())
return;
m_pMediumIdHolder->setId(uMediumId);
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.cpp
+===================================================================
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.cpp
+@@ -1176,7 +1176,7 @@ void UIExtraDataManagerWindow::sltSave()
+ /* Compose initial file-name: */
+ const QString strInitialFileName =
QDir(uiCommon().homeFolder()).absoluteFilePath(QString("%1_ExtraData.xml").arg(currentChooserName()));
+ /* Open file-save dialog to choose file to save extra-data into: */
+- const QString strFileName =
QIFileDialog::getSaveFileName(strInitialFileName, "XML files (*.xml)", this,
++ const QString strFileName =
QIFileDialog::getSaveFileName(strInitialFileName, "XML files (*.xml)",
QApplication::activeWindow(),
+ "Choose file to
save extra-data into..", 0, true, true);
+ /* Make sure file-name was chosen: */
+ if (strFileName.isEmpty())
+@@ -1263,7 +1263,7 @@ void UIExtraDataManagerWindow::sltLoad()
+ /* Compose initial file-name: */
+ const QString strInitialFileName =
QDir(uiCommon().homeFolder()).absoluteFilePath(QString("%1_ExtraData.xml").arg(currentChooserName()));
+ /* Open file-open dialog to choose file to open extra-data into: */
+- const QString strFileName =
QIFileDialog::getOpenFileName(strInitialFileName, "XML files (*.xml)", this,
++ const QString strFileName =
QIFileDialog::getOpenFileName(strInitialFileName, "XML files (*.xml)",
QApplication::activeWindow(),
+ "Choose file to
load extra-data from..");
+ /* Make sure file-name was chosen: */
+ if (strFileName.isEmpty())
+Index:
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/widgets/UILineTextEdit.cpp
+===================================================================
+---
VirtualBox-6.1.18.orig/src/VBox/Frontends/VirtualBox/src/widgets/UILineTextEdit.cpp
++++
VirtualBox-6.1.18/src/VBox/Frontends/VirtualBox/src/widgets/UILineTextEdit.cpp
+@@ -78,7 +78,7 @@ void UITextEditor::retranslateUi()
+
+ void UITextEditor::open()
+ {
+- QString fileName =
QIFileDialog::getOpenFileName(uiCommon().documentsPath(), tr("Text (*.txt);;All
(*.*)"), this, tr("Select a file to open..."));
++ QString fileName =
QIFileDialog::getOpenFileName(uiCommon().documentsPath(), tr("Text (*.txt);;All
(*.*)"), QApplication::activeWindow(), tr("Select a file to open..."));
+ if (!fileName.isEmpty())
+ {
+ QFile file(fileName);
