Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package gnome-maps for openSUSE:Factory checked in at 2021-02-18 20:39:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-maps (Old) and /work/SRC/openSUSE:Factory/.gnome-maps.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-maps" Thu Feb 18 20:39:19 2021 rev:57 rq:872513 version:3.38.4 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-maps/gnome-maps.changes 2021-01-15 19:44:51.901900047 +0100 +++ /work/SRC/openSUSE:Factory/.gnome-maps.new.28504/gnome-maps.changes 2021-02-18 20:49:56.815299707 +0100 @@ -1,0 +2,12 @@ +Sat Feb 13 16:48:15 UTC 2021 - Bj??rn Lie <bjorn....@gmail.com> + +- Update to version 3.38.4: + + Fix a bug resulting in writing a broken last view position on + exit in some circumstances. + + Fix a bug preventing wrapping around at the date line with dark + tiles. + + Fix a bug causing hanging in cases when dragging around route + markers. + + Updated translations. + +------------------------------------------------------------------- Old: ---- gnome-maps-3.38.3.tar.xz New: ---- gnome-maps-3.38.4.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-maps.spec ++++++ --- /var/tmp/diff_new_pack.gUvDac/_old 2021-02-18 20:49:57.347300227 +0100 +++ /var/tmp/diff_new_pack.gUvDac/_new 2021-02-18 20:49:57.351300231 +0100 @@ -17,7 +17,7 @@ Name: gnome-maps -Version: 3.38.3 +Version: 3.38.4 Release: 0 Summary: Maps Application for GNOME License: GPL-2.0-or-later ++++++ gnome-maps-3.38.3.tar.xz -> gnome-maps-3.38.4.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-maps-3.38.3/NEWS new/gnome-maps-3.38.4/NEWS --- old/gnome-maps-3.38.3/NEWS 2021-01-09 14:47:08.933076600 +0100 +++ new/gnome-maps-3.38.4/NEWS 2021-02-12 22:35:49.923100000 +0100 @@ -1,3 +1,19 @@ +3.38.4 - Feb 12, 2021 +========================= + +Changes since 3.38.3 + - Fix a bug resulting in writing a broken last view position on exit in + some circumstances + - Fix a bug preventing wrapping around at the date line with dark tiles + - Fix a bug causing hanging in cases when dragging around route markers + +Added/updated/fixed translations + - Norwegian Bokm??l + +All contributors to this release +Kjartan Maraas <kmar...@gnome.org> +Marcus Lundblad <m...@update.uu.se> + 3.38.3 - Jan 9, 2021 ========================= diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-maps-3.38.3/data/org.gnome.Maps.appdata.xml.in new/gnome-maps-3.38.4/data/org.gnome.Maps.appdata.xml.in --- old/gnome-maps-3.38.3/data/org.gnome.Maps.appdata.xml.in 2021-01-09 14:47:08.941075800 +0100 +++ new/gnome-maps-3.38.4/data/org.gnome.Maps.appdata.xml.in 2021-02-12 22:35:49.935099000 +0100 @@ -42,6 +42,13 @@ </screenshot> </screenshots> <releases> + <release date="2021-02-12" version="3.38.4"> + <ul> + <li>Fix a bug resulting in writing a broken last view position on exit in some circumstances</li> + <li>Fix a bug preventing wrapping around at the date line with dark tiles</li> + <li>Fix a bug causing hanging in cases when dragging around route markers</li> + </ul> + </release> <release date="2021-01-09" version="3.38.3"> <ul> <li>Fix a bug where place details gets lost after searching again for the same place</li> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-maps-3.38.3/meson.build new/gnome-maps-3.38.4/meson.build --- old/gnome-maps-3.38.3/meson.build 2021-01-09 14:47:08.969073500 +0100 +++ new/gnome-maps-3.38.4/meson.build 2021-02-12 22:35:49.975095500 +0100 @@ -1,5 +1,5 @@ project('gnome-maps', 'c', - version: '3.38.3', + version: '3.38.4', license: 'GPL2+' ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-maps-3.38.3/po/nb.po new/gnome-maps-3.38.4/po/nb.po --- old/gnome-maps-3.38.3/po/nb.po 2021-01-09 14:47:08.985072100 +0100 +++ new/gnome-maps-3.38.4/po/nb.po 2021-02-12 22:35:49.987094600 +0100 @@ -9,8 +9,8 @@ msgstr "" "Project-Id-Version: gnome-maps 3.38.x\n" "Report-Msgid-Bugs-To: https://gitlab.gnome.org/GNOME/gnome-maps/issues\n" -"POT-Creation-Date: 2020-09-16 21:00+0000\n" -"PO-Revision-Date: 2020-12-04 15:36+0100\n" +"POT-Creation-Date: 2021-01-15 22:25+0000\n" +"PO-Revision-Date: 2021-01-25 15:53+0100\n" "Last-Translator: Kjartan Maraas <kmar...@gnome.org>\n" "Language-Team: Norwegian bokm??l <i18n...@lister.ping.uio.no>\n" "Language: nb\n" @@ -57,7 +57,7 @@ "Du kan ogs?? s??ke etter en bestemt type sted, som f.eks. ??Pub n??r Main " "Street, Boston?? eller ??Hoteller n??r Alexanderplatz, Berlin??." -#: data/org.gnome.Maps.appdata.xml.in:159 +#: data/org.gnome.Maps.appdata.xml.in:182 msgid "The GNOME Project" msgstr "GNOME prosjektet" @@ -483,7 +483,7 @@ msgid "Maps is offline!" msgstr "Kart er frakoblet!" -#: data/ui/main-window.ui:122 +#: data/ui/main-window.ui:123 msgid "" "Maps need an active internet connection to function properly, but one can???t " "be found." @@ -491,7 +491,7 @@ "Kart trenger en aktiv internettforbindelse for ?? fungere, men ingen ble " "funnet." -#: data/ui/main-window.ui:130 +#: data/ui/main-window.ui:131 msgid "Check your connection and proxy settings." msgstr "Sjekk tilkobling og innstillinger for proxy." @@ -651,6 +651,11 @@ msgid "No results found" msgstr "Ingen resultater funnet" +#: data/ui/place-popover.ui:66 src/checkInDialog.js:280 src/checkIn.js:162 +#: src/osmEditDialog.js:550 +msgid "An error has occurred" +msgstr "Det har oppst??tt en feil" + #. Translators: This is a tooltip #: data/ui/route-entry.ui:20 msgid "Drag to change order of the route" @@ -856,10 +861,6 @@ msgid "Write an optional message to check in to %s." msgstr "Skriv en valgfri melding for ?? sjekke inn ved %s." -#: src/checkInDialog.js:280 src/checkIn.js:162 src/osmEditDialog.js:550 -msgid "An error has occurred" -msgstr "Det har oppst??tt en feil" - #. Translators: %s is the place name that user wanted to check-in #: src/checkIn.js:144 #, javascript-format @@ -994,15 +995,15 @@ msgid "Search provided by %s using %s" msgstr "S??k tilbys av %s ved bruk av %s" -#: src/mapView.js:466 +#: src/mapView.js:478 msgid "File type is not supported" msgstr "Filtypen er ikke st??ttet" -#: src/mapView.js:473 +#: src/mapView.js:485 msgid "Failed to open layer" msgstr "Klarte ikke ?? ??pne lag" -#: src/mapView.js:509 +#: src/mapView.js:521 msgid "Failed to open GeoURI" msgstr "Klarte ikke ?? ??pne GeoURI" @@ -1224,7 +1225,7 @@ #: src/osmEditDialog.js:205 src/translations.js:381 msgid "Unitarian Universalism" -msgstr "" +msgstr "Unitarisk universalisme" #: src/osmEditDialog.js:206 src/translations.js:382 msgid "Voodoo" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-maps-3.38.3/src/mapView.js new/gnome-maps-3.38.4/src/mapView.js --- old/gnome-maps-3.38.3/src/mapView.js 2021-01-09 14:47:09.001070700 +0100 +++ new/gnome-maps-3.38.4/src/mapView.js 2021-02-12 22:35:49.999093500 +0100 @@ -164,6 +164,9 @@ Application.geoclue.connect('notify::state', this._updateUserLocation.bind(this)); this._connectRouteSignals(); + + // set dark background if we start up in dark theme + this._setBackgroundPatternIfNeeded(); } _initScale(view) { @@ -192,6 +195,8 @@ view.horizontal_wrap = true; view.connect('notify::latitude', this._onViewMoved.bind(this)); + view.connect('notify::longitude', + () => this._setBackgroundPatternIfNeeded()); // switching map type will set view min-zoom-level from map source view.connect('notify::min-zoom-level', () => { if (view.min_zoom_level < MapMinZoom) { @@ -214,12 +219,6 @@ this._gtkSettings = Gtk.Settings.get_default(); this._gtkSettings.connect('notify::gtk-application-prefer-dark-theme', this._onPreferDarkThemeChanged.bind(this)); - // set dark background if we start up in dark theme - if (this._gtkSettings.gtk_application_prefer_dark_theme) { - if (!this._darkBackgroud) - this._createDarkBackground(); - view.set_background_pattern(this._darkBackground); - } this._initScale(view); return view; @@ -246,16 +245,29 @@ this._darkBackground.invalidate(); } - _onPreferDarkThemeChanged() { - if (this._gtkSettings.gtk_application_prefer_dark_theme) { + _isWrappingAround() { + let bbox = this.view.get_bounding_box(); + + return bbox.left > bbox.right; + } + + _setBackgroundPatternIfNeeded() { + if (this._gtkSettings.gtk_application_prefer_dark_theme && + !this._isWrappingAround()) { if (!this._darkBackgroud) this._createDarkBackground(); this.view.set_background_pattern(this._darkBackground); - } else { + this._customBackgroundSet = true; + } else if (this._customBackgroundSet) { this.view.background_pattern = null; + this._customBackgroundSet = false; } } + _onPreferDarkThemeChanged() { + this._setBackgroundPatternIfNeeded(); + } + _onNightModeChanged() { if (this._mapType === MapType.STREET) { let overlay_sources = this.view.get_overlay_sources(); @@ -578,9 +590,19 @@ } _storeLocation() { - Application.settings.set('zoom-level', this.view.zoom_level); + let zoom = this.view.zoom_level; let location = [this.view.latitude, this.view.longitude]; - Application.settings.set('last-viewed-location', location); + + /* protect agains situations where the Champlain view was already + * disposed, in this case zoom will be set to the GObject property + * getter + */ + if (!isNaN(zoom)) { + Application.settings.set('zoom-level', zoom); + Application.settings.set('last-viewed-location', location); + } else { + Utils.debug('Failed to extract location to store'); + } } _goToStoredLocation() { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-maps-3.38.3/src/sidebar.js new/gnome-maps-3.38.4/src/sidebar.js --- old/gnome-maps-3.38.3/src/sidebar.js 2021-01-09 14:47:09.005070400 +0100 +++ new/gnome-maps-3.38.4/src/sidebar.js 2021-02-12 22:35:49.999093500 +0100 @@ -257,7 +257,8 @@ let nextPlaceEntry = this._entryList.get_row_at_index(index + 1).get_child().entry; - nextPlaceEntry.grab_focus(); + if (!nextPlaceEntry.place) + nextPlaceEntry.grab_focus(); } }