Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-registration for openSUSE:Factory checked in at 2021-02-26 21:58:40 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-registration (Old) and /work/SRC/openSUSE:Factory/.yast2-registration.new.2378 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-registration" Fri Feb 26 21:58:40 2021 rev:69 rq:873752 version:4.3.20 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-registration/yast2-registration.changes 2021-01-20 18:24:51.399372283 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-registration.new.2378/yast2-registration.changes 2021-02-26 21:58:42.079781293 +0100 @@ -1,0 +2,14 @@ +Mon Feb 15 17:39:06 UTC 2021 - Josef Reidinger <[email protected]> + +- Adapted unit test to recent changes in Yast::Report (related to + bsc#1179893). +- 4.3.20 + +------------------------------------------------------------------- +Mon Feb 8 17:06:54 UTC 2021 - Ladislav Slez??k <[email protected]> + +- Log details about the imported SSL certificate during migration + (related to bsc#1179464) +- 4.3.19 + +------------------------------------------------------------------- Old: ---- yast2-registration-4.3.18.tar.bz2 New: ---- yast2-registration-4.3.20.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-registration.spec ++++++ --- /var/tmp/diff_new_pack.ogCbUw/_old 2021-02-26 21:58:43.555782590 +0100 +++ /var/tmp/diff_new_pack.ogCbUw/_new 2021-02-26 21:58:43.559782593 +0100 @@ -17,7 +17,7 @@ Name: yast2-registration -Version: 4.3.18 +Version: 4.3.20 Release: 0 Summary: YaST2 - Registration Module License: GPL-2.0-only ++++++ yast2-registration-4.3.18.tar.bz2 -> yast2-registration-4.3.20.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/.github/workflows/ci.yml new/yast2-registration-4.3.20/.github/workflows/ci.yml --- old/yast2-registration-4.3.18/.github/workflows/ci.yml 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/.github/workflows/ci.yml 2021-02-19 13:19:31.000000000 +0100 @@ -13,7 +13,7 @@ steps: - name: Git Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 # just for easier debugging... - name: Inspect Installed Packages @@ -38,7 +38,7 @@ steps: - name: Git Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Rubocop run: rake check:rubocop @@ -50,7 +50,7 @@ steps: - name: Git Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Package Build run: yast-ci-ruby -o package @@ -62,7 +62,7 @@ steps: - name: Git Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Yardoc run: rake check:doc @@ -76,7 +76,7 @@ steps: - name: Git Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v2 - name: Perl Syntax run: yast-ci-ruby -o perl_syntax diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/package/yast2-registration.changes new/yast2-registration-4.3.20/package/yast2-registration.changes --- old/yast2-registration-4.3.18/package/yast2-registration.changes 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/package/yast2-registration.changes 2021-02-19 13:19:31.000000000 +0100 @@ -1,4 +1,18 @@ ------------------------------------------------------------------- +Mon Feb 15 17:39:06 UTC 2021 - Josef Reidinger <[email protected]> + +- Adapted unit test to recent changes in Yast::Report (related to + bsc#1179893). +- 4.3.20 + +------------------------------------------------------------------- +Mon Feb 8 17:06:54 UTC 2021 - Ladislav Slez??k <[email protected]> + +- Log details about the imported SSL certificate during migration + (related to bsc#1179464) +- 4.3.19 + +------------------------------------------------------------------- Tue Jan 19 14:27:15 UTC 2021 - Ladislav Slez??k <[email protected]> - Catch exceptions during cloning, display an error popup diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/package/yast2-registration.spec new/yast2-registration-4.3.20/package/yast2-registration.spec --- old/yast2-registration-4.3.18/package/yast2-registration.spec 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/package/yast2-registration.spec 2021-02-19 13:19:31.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-registration -Version: 4.3.18 +Version: 4.3.20 Release: 0 Summary: YaST2 - Registration Module License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/src/lib/registration/clients/inst_migration_repos.rb new/yast2-registration-4.3.20/src/lib/registration/clients/inst_migration_repos.rb --- old/yast2-registration-4.3.18/src/lib/registration/clients/inst_migration_repos.rb 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/src/lib/registration/clients/inst_migration_repos.rb 2021-02-19 13:19:31.000000000 +0100 @@ -15,6 +15,8 @@ require "yast" require "yast/suse_connect" require "registration/sw_mgmt" +require "registration/ssl_certificate" +require "registration/ssl_certificate_details" module Registration module Clients @@ -59,6 +61,7 @@ if File.exist?(cert_file) log.info("Importing the SSL certificate from the old system: (#{prefix})#{file} ...") cert = SslCertificate.load_file(cert_file) + log_certificate(cert) target_path = File.join(SslCertificate::INSTSYS_CERT_DIR, File.basename(cert_file)) cert.import_to_instsys(target_path) else @@ -66,6 +69,18 @@ end end end + + # Log the certificate details + # @param cert [Registration::SslCertificate] the SSL certificate + def log_certificate(cert) + # log also the dates + log.info("#{SslCertificateDetails.new(cert).summary}\n" \ + "Issued on: #{cert.issued_on}\nExpires on: #{cert.expires_on}") + + # log a warning for expired certificate + expires = cert.x509_cert.not_after.localtime + log.warn("The certificate has EXPIRED! (#{expires})") if expires < Time.now + end end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/test/inst_scc_test.rb new/yast2-registration-4.3.20/test/inst_scc_test.rb --- old/yast2-registration-4.3.18/test/inst_scc_test.rb 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/test/inst_scc_test.rb 2021-02-19 13:19:31.000000000 +0100 @@ -56,6 +56,7 @@ end it "switchs to manual registration when aborting selection of url" do + allow(Yast::Report).to receive(:Error) # User cancels the selection of registration url expect_any_instance_of(Registration::UI::RegistrationUpdateDialog).to receive( :init_registration diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/test/migration_repos_workflow_spec.rb new/yast2-registration-4.3.20/test/migration_repos_workflow_spec.rb --- old/yast2-registration-4.3.18/test/migration_repos_workflow_spec.rb 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/test/migration_repos_workflow_spec.rb 2021-02-19 13:19:31.000000000 +0100 @@ -211,6 +211,7 @@ end it "reports error and indicates needed rollback when upgrading a product fails" do + expect(Yast::Report).to receive(:Error) # installed SLES12 allow(Registration::SwMgmt).to receive(:installed_products) .and_return([load_yaml_fixture("products_legacy_installation.yml")[1]]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/test/registration/clients/scc_auto_test.rb new/yast2-registration-4.3.20/test/registration/clients/scc_auto_test.rb --- old/yast2-registration-4.3.18/test/registration/clients/scc_auto_test.rb 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/test/registration/clients/scc_auto_test.rb 2021-02-19 13:19:31.000000000 +0100 @@ -85,6 +85,8 @@ before do Y2Packager::MediumType.type = :online allow(Y2Packager::ProductControlProduct).to receive(:products).and_return("SLES") + # clean cache + ::Registration::Storage::Cache.instance.addon_services = [] end it "just returns true if config is not set to register and mode is not update" do @@ -96,9 +98,14 @@ it "initializes software managent in normal mode" do config.do_registration = true + allow(subject).to receive(:register_addons) # do not test addons here. It is done below allow(Yast::Mode).to receive(:normal).and_return(true) expect(::Registration::SwMgmt).to receive(:init) + allow(subject).to receive(:registration_ui).and_return( + double(register_system_and_base_product: true, disable_update_repos: true) + ) + subject.write end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/test/registration/ui/addon_eula_dialog_test.rb new/yast2-registration-4.3.20/test/registration/ui/addon_eula_dialog_test.rb --- old/yast2-registration-4.3.18/test/registration/ui/addon_eula_dialog_test.rb 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/test/registration/ui/addon_eula_dialog_test.rb 2021-02-19 13:19:31.000000000 +0100 @@ -63,6 +63,7 @@ before do allow(Yast::ProductLicense).to receive(:HandleLicenseDialogRet) .and_return(first_dialog_response, second_dialog_response) + allow(Yast::ProductLicense).to receive(:DisplayLicenseDialogWithTitle) end context "and the user wants to go back" do @@ -104,6 +105,7 @@ before do allow(Yast::ProductLicense).to receive(:HandleLicenseDialogRet) .and_return(:accepted) + allow(Yast::ProductLicense).to receive(:DisplayLicenseDialogWithTitle) end it "sets it as accepted" do @@ -125,6 +127,7 @@ before do allow(Yast::ProductLicense).to receive(:HandleLicenseDialogRet) .and_return(:abort) + allow(Yast::ProductLicense).to receive(:DisplayLicenseDialogWithTitle) end it "does not set it as accepted" do @@ -164,11 +167,18 @@ context "when the eula could not be downloaded" do before do allow(eula_downloader).to receive(:download).and_raise(StandardError) + allow(Yast::Report).to receive(:Error) end it "returns :back" do expect(dialog.send(:accept_eula, addon)).to eq(:back) end + + it "shows error" do + expect(Yast::Report).to receive(:Error) + + dialog.send(:accept_eula, addon) + end end it "reads the license and asks for a already seen license with the same content" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-registration-4.3.18/test/wizard_client_spec.rb new/yast2-registration-4.3.20/test/wizard_client_spec.rb --- old/yast2-registration-4.3.18/test/wizard_client_spec.rb 2021-01-19 15:46:06.000000000 +0100 +++ new/yast2-registration-4.3.20/test/wizard_client_spec.rb 2021-02-19 13:19:31.000000000 +0100 @@ -33,8 +33,9 @@ subject.main end - it "returns :abort when an exception is raised" do + it "returns :abort and show error when an exception is raised" do expect(subject).to receive(:run_sequence).and_raise("Error") + expect(Yast::Report).to receive(:Error) expect(subject.run).to eq(:abort) end end
