Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package otpclient for openSUSE:Factory
checked in at 2021-03-28 11:55:29
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/otpclient (Old)
and /work/SRC/openSUSE:Factory/.otpclient.new.2401 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "otpclient"
Sun Mar 28 11:55:29 2021 rev:7 rq:881499 version:2.4.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/otpclient/otpclient.changes 2021-02-15
23:22:06.559916379 +0100
+++ /work/SRC/openSUSE:Factory/.otpclient.new.2401/otpclient.changes
2021-03-28 11:57:35.292289082 +0200
@@ -1,0 +2,8 @@
+Thu Mar 25 15:11:20 UTC 2021 - Paolo Stivanin <i...@paolostivanin.com>
+
+- Update to 2.4.3
+ * remove hard-coded paths (#203 )
+ * fix wrong icon in taskbar (#204)
+ * fix an error in andOTP export
+
+-------------------------------------------------------------------
Old:
----
v2.4.2.tar.gz
v2.4.2.tar.gz.asc
New:
----
v2.4.3.tar.gz
v2.4.3.tar.gz.asc
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ otpclient.spec ++++++
--- /var/tmp/diff_new_pack.59fXvv/_old 2021-03-28 11:57:35.928289645 +0200
+++ /var/tmp/diff_new_pack.59fXvv/_new 2021-03-28 11:57:35.928289645 +0200
@@ -18,7 +18,7 @@
%define uclname OTPClient
Name: otpclient
-Version: 2.4.2
+Version: 2.4.3
Release: 0
Summary: Simple GTK+ client for managing TOTP and HOTP
License: GPL-3.0-or-later
++++++ v2.4.2.tar.gz -> v2.4.3.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/.circleci/config.yml
new/OTPClient-2.4.3/.circleci/config.yml
--- old/OTPClient-2.4.2/.circleci/config.yml 2021-02-12 08:21:18.000000000
+0100
+++ new/OTPClient-2.4.3/.circleci/config.yml 2021-03-25 16:06:10.000000000
+0100
@@ -39,7 +39,7 @@
archlinux:
docker:
- - image: archlinux/base:latest
+ - image: archlinux:latest
steps:
- checkout
- run: pacman -Syu --noconfirm && pacman -S --noconfirm pkg-config git
gtk3 libgcrypt zbar gcc clang cmake make libzip jansson libpng
@@ -54,4 +54,4 @@
- ubuntuLatestRolling
- debianLatestStable
- fedoraLatestStable
- - archlinux
+ #- archlinux
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/CMakeLists.txt
new/OTPClient-2.4.3/CMakeLists.txt
--- old/OTPClient-2.4.2/CMakeLists.txt 2021-02-12 08:21:18.000000000 +0100
+++ new/OTPClient-2.4.3/CMakeLists.txt 2021-03-25 16:06:10.000000000 +0100
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.5)
-project(OTPClient VERSION "2.4.2" LANGUAGES "C")
+project(OTPClient VERSION "2.4.3" LANGUAGES "C")
configure_file("src/common/version.h.in" "version.h")
include_directories(${PROJECT_BINARY_DIR})
@@ -11,11 +11,11 @@
option(BUILD_CLI "Build the CLI" ON)
set(CMAKE_C_STANDARD 11)
-set(CMAKE_C_FLAGS "-Wall -Wextra -O3 -Wformat=2 -Wmissing-format-attribute
-fstack-protector-strong -Wundef -Wmissing-format-attribute")
+set(CMAKE_C_FLAGS "-Wall -Wextra -O2 -Wformat=2 -Wmissing-format-attribute
-fstack-protector-strong -Wundef -Wmissing-format-attribute")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fdiagnostics-color=always
-Wstrict-prototypes -Wunreachable-code")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wchar-subscripts -Wwrite-strings
-Wpointer-arith -Wbad-function-cast -Wcast-align")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror=format-security
-Werror=implicit-function-declaration -Wno-sign-compare")
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2")
if(CMAKE_COMPILER_IS_GNUCC)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pie -fPIE")
endif()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/TODO.txt new/OTPClient-2.4.3/TODO.txt
--- old/OTPClient-2.4.2/TODO.txt 1970-01-01 01:00:00.000000000 +0100
+++ new/OTPClient-2.4.3/TODO.txt 2021-03-25 16:06:10.000000000 +0100
@@ -0,0 +1,15 @@
+* add "border-width: 5" to:
+ newdb_pwd_diag_id
+ decpwd_diag_id
+ changepwd_diag_id
+ unlock_pwd_diag_id
+ diag_webcam_id
+ diag_qr_clipboard_id
+ diag_webcam_id
+ manual_add_diag_id
+ dialog_rcdb_id
+ edit_diag_id
+ warning_diag_id
+ settings_diag_id
+
+* change all paths to UI file
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/OTPClient-2.4.2/data/com.github.paolostivanin.OTPClient.appdata.xml
new/OTPClient-2.4.3/data/com.github.paolostivanin.OTPClient.appdata.xml
--- old/OTPClient-2.4.2/data/com.github.paolostivanin.OTPClient.appdata.xml
2021-02-12 08:21:18.000000000 +0100
+++ new/OTPClient-2.4.3/data/com.github.paolostivanin.OTPClient.appdata.xml
2021-03-25 16:06:10.000000000 +0100
@@ -83,6 +83,16 @@
</content_rating>
<releases>
+ <release version="2.4.3" date="2021-03-25">
+ <description>
+ <p>OTPClient 2.4.3 contains some small fixes</p>
+ <ul>
+ <li>fix a small andOTP export bug</li>
+ <li>fix wrong icon in taskbar</li>
+ <li>remove hard-coded paths from get-builder.c</li>
+ </ul>
+ </description>
+ </release>
<release version="2.4.2" date="2021-02-12">
<description>
<p>OTPClient 2.4.2 contains a small fix to andOTP handling</p>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/OTPClient-2.4.2/data/com.github.paolostivanin.OTPClient.desktop
new/OTPClient-2.4.3/data/com.github.paolostivanin.OTPClient.desktop
--- old/OTPClient-2.4.2/data/com.github.paolostivanin.OTPClient.desktop
2021-02-12 08:21:18.000000000 +0100
+++ new/OTPClient-2.4.3/data/com.github.paolostivanin.OTPClient.desktop
2021-03-25 16:06:10.000000000 +0100
@@ -7,4 +7,4 @@
Name=OTPClient
Comment=GTK+ TOTP and HOTP client
Categories=GTK;GNOME;Utility;
-
+StartupWMClass=otpclient
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/src/common/andotp.c
new/OTPClient-2.4.3/src/common/andotp.c
--- old/OTPClient-2.4.2/src/common/andotp.c 2021-02-12 08:21:18.000000000
+0100
+++ new/OTPClient-2.4.3/src/common/andotp.c 2021-03-25 16:06:10.000000000
+0100
@@ -317,18 +317,18 @@
otp->secret = secure_strdup (json_string_value (json_object_get (obj,
"secret")));
const gchar *issuer = json_string_value (json_object_get (obj,
"issuer"));
- otp->issuer = g_strdup (g_strstrip (issuer));
+ otp->issuer = g_strstrip (g_strdup (issuer));
const gchar *label_with_prefix = json_string_value (json_object_get
(obj, "label"));
gchar **tokens = g_strsplit (label_with_prefix, ":", -1);
if (tokens[0] && tokens[1]) {
if(issuer != NULL && g_ascii_strcasecmp(issuer, tokens[0]) == 0) {
- otp->account_name = g_strdup (g_strstrip (tokens[1]));
+ otp->account_name = g_strstrip (g_strdup (tokens[1]));
} else {
- otp->account_name = g_strdup (g_strstrip (label_with_prefix));
+ otp->account_name = g_strstrip (g_strdup (label_with_prefix));
}
} else {
- otp->account_name = g_strdup (g_strstrip (tokens[0]));
+ otp->account_name = g_strstrip (g_strdup (tokens[0]));
}
g_strfreev (tokens);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/src/common/version.h.in
new/OTPClient-2.4.3/src/common/version.h.in
--- old/OTPClient-2.4.2/src/common/version.h.in 2021-02-12 08:21:18.000000000
+0100
+++ new/OTPClient-2.4.3/src/common/version.h.in 2021-03-25 16:06:10.000000000
+0100
@@ -1,7 +1,5 @@
#pragma once
-#define PROJECT_NAME "@PROJECT_NAME@"
-#define PROJECT_VER "@PROJECT_VERSION@"
-#define PROJECT_VER_MAJOR "@PROJECT_VERSION_MAJOR@"
-#define PROJECT_VER_MINOR "@PROJECT_VERSION_MINOR@"
-#define PTOJECT_VER_PATCH "@PROJECT_VERSION_PATCH@"
\ No newline at end of file
+#define PROJECT_NAME "@PROJECT_NAME@"
+#define PROJECT_VER "@PROJECT_VERSION@"
+#define INSTALL_PREFIX "@CMAKE_INSTALL_PREFIX@"
\ No newline at end of file
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/src/get-builder.c
new/OTPClient-2.4.3/src/get-builder.c
--- old/OTPClient-2.4.2/src/get-builder.c 2021-02-12 08:21:18.000000000
+0100
+++ new/OTPClient-2.4.3/src/get-builder.c 2021-03-25 16:06:10.000000000
+0100
@@ -1,22 +1,17 @@
#include <gtk/gtk.h>
-
+#include "version.h"
GtkBuilder *
get_builder_from_partial_path (const gchar *partial_path)
{
const gchar *prefix;
#ifndef USE_FLATPAK_APP_FOLDER
- if (g_file_test (g_strconcat ("/usr/", partial_path, NULL),
G_FILE_TEST_EXISTS)) {
- prefix = "/usr/";
- } else if (g_file_test (g_strconcat ("/usr/local/", partial_path, NULL),
G_FILE_TEST_EXISTS)) {
- prefix = "/usr/local/";
- } else {
- return NULL;
- }
+ // cmake trims the last '/', so we have to manually add it later on
+ prefix = INSTALL_PREFIX;
#else
- prefix = "/app/";
+ prefix = "/app";
#endif
- gchar *path = g_strconcat (prefix, partial_path, NULL);
+ gchar *path = g_strconcat (prefix, "/", partial_path, NULL);
GtkBuilder *builder = gtk_builder_new_from_file (path);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/src/main.c
new/OTPClient-2.4.3/src/main.c
--- old/OTPClient-2.4.2/src/main.c 2021-02-12 08:21:18.000000000 +0100
+++ new/OTPClient-2.4.3/src/main.c 2021-03-25 16:06:10.000000000 +0100
@@ -8,7 +8,6 @@
{
GtkApplication *app = gtk_application_new
("com.github.paolostivanin.OTPClient", G_APPLICATION_FLAGS_NONE);
g_set_application_name (PROJECT_NAME);
- g_set_prgname (PROJECT_VER);
g_signal_connect (app, "activate", G_CALLBACK (activate), NULL);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/OTPClient-2.4.2/src/ui/otpclient.ui
new/OTPClient-2.4.3/src/ui/otpclient.ui
--- old/OTPClient-2.4.2/src/ui/otpclient.ui 2021-02-12 08:21:18.000000000
+0100
+++ new/OTPClient-2.4.3/src/ui/otpclient.ui 2021-03-25 16:06:10.000000000
+0100
@@ -926,7 +926,7 @@
<object class="GtkEntry" id="manual_diag_secret_entry_id">
<property name="visible">True</property>
<property name="can_focus">True</property>
- <property name="max_length">96</property>
+ <property name="max_length">255</property>
<property name="visibility">False</property>
<property
name="secondary_icon_name">dialog-password-symbolic</property>
<property name="primary_icon_tooltip_text"
translatable="yes">Secret</property>
