Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package xclipboard for openSUSE:Factory checked in at 2024-08-27 19:39:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/xclipboard (Old) and /work/SRC/openSUSE:Factory/.xclipboard.new.2698 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xclipboard" Tue Aug 27 19:39:25 2024 rev:8 rq:1196223 version:1.1.5 Changes: -------- --- /work/SRC/openSUSE:Factory/xclipboard/xclipboard.changes 2022-07-11 19:11:18.295774802 +0200 +++ /work/SRC/openSUSE:Factory/.xclipboard.new.2698/xclipboard.changes 2024-08-27 19:39:49.165696570 +0200 @@ -1,0 +2,10 @@ +Tue Aug 27 08:01:52 UTC 2024 - Stefan Dirsch <sndir...@suse.com> + +- Update to version 1.1.5 + * gitlab CI: stop requiring Signed-off-by in commits + * Fix -Wbad-function-cast warnings from casting Atom to void * + * Handle -Wdiscarded-qualifiers warnings for XawTextBlock ptr + * gitlab CI: Update build container contents + * NewClip: error out if failed to allocate memory for new ClipRec + +------------------------------------------------------------------- Old: ---- xclipboard-1.1.4.tar.xz New: ---- xclipboard-1.1.5.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xclipboard.spec ++++++ --- /var/tmp/diff_new_pack.cOqO9o/_old 2024-08-27 19:39:49.573713842 +0200 +++ /var/tmp/diff_new_pack.cOqO9o/_new 2024-08-27 19:39:49.577714012 +0200 @@ -1,7 +1,7 @@ # # spec file for package xclipboard # -# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: xclipboard -Version: 1.1.4 +Version: 1.1.5 Release: 0 Summary: X clipboard client License: MIT @@ -60,7 +60,8 @@ %files %defattr(-,root,root) -%doc ChangeLog COPYING README.md +%doc ChangeLog README.md +%license COPYING %{_bindir}/xclipboard %{_bindir}/xcutsel %{_datadir}/applications/xclipboard.desktop ++++++ xclipboard-1.1.4.tar.xz -> xclipboard-1.1.5.tar.xz ++++++ ++++ 8850 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xclipboard-1.1.4/ChangeLog new/xclipboard-1.1.5/ChangeLog --- old/xclipboard-1.1.4/ChangeLog 2022-07-10 23:50:17.000000000 +0200 +++ new/xclipboard-1.1.5/ChangeLog 2024-08-27 03:40:50.000000000 +0200 @@ -1,3 +1,92 @@ +commit 02e7dc1231436274bd84232927bc99201a772b3d +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Mon Aug 26 18:36:09 2024 -0700 + + xclipboard 1.1.5 + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 36d6d686dba46f595a690c529bf56f05834ee15b +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sun Jul 28 11:59:38 2024 -0700 + + NewClip: error out if failed to allocate memory for new ClipRec + + Quiets -Wanalyzer-possible-null-dereference warnings from gcc 14.1 + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/app/xclipboard/-/merge_requests/6> + +commit 316cd14b9cbd2ef518a090edb80ce5f715282ad9 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Jul 6 12:51:19 2024 -0700 + + gitlab CI: Update build container contents + + Updates include: + - gcc 11.1 -> 14.1 + - binutils 2.36 -> 2.42 + - libX11 1.7.2 -> 1.8.9 + - autoconf 2.71 -> 2.72 + - xorg-util-macros 1.19.3 -> 1.20.1 + - xorgproto 2021.5 -> 2024.1 + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/app/xclipboard/-/merge_requests/5> + +commit e074743e9c38afdcf5809d857921959bb6c14241 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sun Apr 7 12:07:58 2024 -0700 + + Handle -Wdiscarded-qualifiers warnings for XawTextBlock ptr + + xclipboard.c: In function âNewCurrentClipâ: + xclipboard.c:384:29: warning: passing argument 1 of âNewCurrentClipContentsâ + discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers] + 384 | NewCurrentClipContents ("", 0); + | ^~ + xclipboard.c:77:44: note: expected âchar *â but argument is of type + âconst char *â + 77 | static void NewCurrentClipContents ( char *data, int len ); + | ~~~~~~^~~~ + xclipboard.c: In function âEraseTextWidgetâ: + xclipboard.c:420:15: warning: assignment discards âconstâ qualifier from + pointer target type [-Wdiscarded-qualifiers] + 420 | block.ptr = ""; + | ^ + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/app/xclipboard/-/merge_requests/4> + +commit 98ebfcf3bc9a9f7cdd94eea880bd64e2af705fd5 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Apr 6 11:26:45 2024 -0700 + + Fix -Wbad-function-cast warnings from casting Atom to void * + + xclipboard.c: In function âInsertClipboardâ: + xclipboard.c:494:33: warning: cast from function call of type âAtomâ + {aka âlong unsigned intâ} to non-matching type âvoid *â [-Wbad-function-cast] + 494 | (XtPointer)(XA_COMPOUND_TEXT(d)), + | ^ + xclipboard.c: In function âLoseSelectionâ: + xclipboard.c:637:25: warning: cast from function call of type âAtomâ + {aka âlong unsigned intâ} to non-matching type âvoid *â [-Wbad-function-cast] + 637 | (XtPointer)(XA_UTF8_STRING(d)), CurrentTime); + | ^ + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/app/xclipboard/-/merge_requests/4> + +commit b2d0637073564107c1e038da339d47e2e8c40bb9 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Thu Jul 28 17:30:21 2022 -0700 + + gitlab CI: stop requiring Signed-off-by in commits + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/app/xclipboard/-/merge_requests/4> + commit 0220c7d59cbb83c53dce331ec7e8108a76f75328 Author: Alan Coopersmith <alan.coopersm...@oracle.com> Date: Sun Jul 10 14:42:43 2022 -0700 @@ -719,7 +808,7 @@ fix rules to work with non-GNU make and outside of $srcdir commit e0a326f3bd7889da2352a1e534871a64b693545a -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Wed Jul 6 17:30:20 2005 +0000 Build system for xclipboard and xcutsel diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xclipboard-1.1.4/compile new/xclipboard-1.1.5/compile --- old/xclipboard-1.1.4/compile 2022-07-10 23:50:13.000000000 +0200 +++ new/xclipboard-1.1.5/compile 2024-08-27 03:40:45.000000000 +0200 @@ -1,9 +1,9 @@ #! /bin/sh # Wrapper for compilers which do not understand '-c -o'. -scriptversion=2018-03-07.03; # UTC +scriptversion=2024-06-19.01; # UTC -# Copyright (C) 1999-2021 Free Software Foundation, Inc. +# Copyright (C) 1999-2024 Free Software Foundation, Inc. # Written by Tom Tromey <tro...@cygnus.com>. # # This program is free software; you can redistribute it and/or modify @@ -143,7 +143,7 @@ # configure might choose to run compile as 'compile cc -o foo foo.c'. eat=1 case $2 in - *.o | *.[oO][bB][jJ]) + *.o | *.lo | *.[oO][bB][jJ]) func_file_conv "$2" set x "$@" -Fo"$file" shift @@ -248,14 +248,17 @@ right script to run: please start by reading the file 'INSTALL'. Report bugs to <bug-autom...@gnu.org>. +GNU Automake home page: <https://www.gnu.org/software/automake/>. +General help using GNU software: <https://www.gnu.org/gethelp/>. EOF exit $? ;; -v | --v*) - echo "compile $scriptversion" + echo "compile (GNU Automake) $scriptversion" exit $? ;; cl | *[/\\]cl | cl.exe | *[/\\]cl.exe | \ + clang-cl | *[/\\]clang-cl | clang-cl.exe | *[/\\]clang-cl.exe | \ icl | *[/\\]icl | icl.exe | *[/\\]icl.exe ) func_cl_wrapper "$@" # Doesn't return... ;; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xclipboard-1.1.4/config.h.in new/xclipboard-1.1.5/config.h.in --- old/xclipboard-1.1.4/config.h.in 2022-07-10 23:50:12.000000000 +0200 +++ new/xclipboard-1.1.5/config.h.in 2024-08-27 03:40:45.000000000 +0200 @@ -57,7 +57,7 @@ /* Patch version of this package */ #undef PACKAGE_VERSION_PATCHLEVEL -/* Define to 1 if all of the C90 standard headers exist (not just the ones +/* Define to 1 if all of the C89 standard headers exist (not just the ones required in a freestanding environment). This macro is provided for backward compatibility; new code need not use it. */ #undef STDC_HEADERS diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xclipboard-1.1.4/configure.ac new/xclipboard-1.1.5/configure.ac --- old/xclipboard-1.1.4/configure.ac 2022-07-10 23:50:09.000000000 +0200 +++ new/xclipboard-1.1.5/configure.ac 2024-08-27 03:40:41.000000000 +0200 @@ -22,8 +22,10 @@ dnl Process this file with autoconf to create configure. AC_PREREQ([2.60]) -AC_INIT([xclipboard], [1.1.4], - [https://gitlab.freedesktop.org/xorg/app/xclipboard/issues], [xclipboard]) +AC_INIT([xclipboard], [1.1.5], + [https://gitlab.freedesktop.org/xorg/app/xclipboard/-/issue], + [xclipboard], + [https://gitlab.freedesktop.org/xorg/app/xclipboard/]) AC_CONFIG_SRCDIR([Makefile.am]) AC_CONFIG_HEADERS([config.h]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xclipboard-1.1.4/missing new/xclipboard-1.1.5/missing --- old/xclipboard-1.1.4/missing 2022-07-10 23:50:13.000000000 +0200 +++ new/xclipboard-1.1.5/missing 2024-08-27 03:40:45.000000000 +0200 @@ -1,9 +1,11 @@ #! /bin/sh -# Common wrapper for a few potentially missing GNU programs. +# Common wrapper for a few potentially missing GNU and other programs. -scriptversion=2018-03-07.03; # UTC +scriptversion=2024-06-07.14; # UTC -# Copyright (C) 1996-2021 Free Software Foundation, Inc. +# shellcheck disable=SC2006,SC2268 # we must support pre-POSIX shells + +# Copyright (C) 1996-2024 Free Software Foundation, Inc. # Originally written by Fran,cois Pinard <pin...@iro.umontreal.ca>, 1996. # This program is free software; you can redistribute it and/or modify @@ -54,18 +56,20 @@ -v, --version output version information and exit Supported PROGRAM values: - aclocal autoconf autoheader autom4te automake makeinfo - bison yacc flex lex help2man +aclocal autoconf autogen autoheader autom4te automake autoreconf +bison flex help2man lex makeinfo perl yacc Version suffixes to PROGRAM as well as the prefixes 'gnu-', 'gnu', and 'g' are ignored when checking the name. -Send bug reports to <bug-autom...@gnu.org>." +Report bugs to <bug-autom...@gnu.org>. +GNU Automake home page: <https://www.gnu.org/software/automake/>. +General help using GNU software: <https://www.gnu.org/gethelp/>." exit $? ;; -v|--v|--ve|--ver|--vers|--versi|--versio|--version) - echo "missing $scriptversion (GNU Automake)" + echo "missing (GNU Automake) $scriptversion" exit $? ;; @@ -108,7 +112,7 @@ program_details () { case $1 in - aclocal|automake) + aclocal|automake|autoreconf) echo "The '$1' program is part of the GNU Automake package:" echo "<$gnu_software_URL/automake>" echo "It also requires GNU Autoconf, GNU m4 and Perl in order to run:" @@ -123,6 +127,9 @@ echo "<$gnu_software_URL/m4/>" echo "<$perl_URL>" ;; + *) + : + ;; esac } @@ -137,48 +144,55 @@ printf '%s\n' "'$1' is $msg." configure_deps="'configure.ac' or m4 files included by 'configure.ac'" + autoheader_deps="'acconfig.h'" + automake_deps="'Makefile.am'" + aclocal_deps="'acinclude.m4'" case $normalized_program in + aclocal*) + echo "You should only need it if you modified $aclocal_deps or" + echo "$configure_deps." + ;; autoconf*) - echo "You should only need it if you modified 'configure.ac'," - echo "or m4 files included by it." - program_details 'autoconf' + echo "You should only need it if you modified $configure_deps." + ;; + autogen*) + echo "You should only need it if you modified a '.def' or '.tpl' file." + echo "You may want to install the GNU AutoGen package:" + echo "<$gnu_software_URL/autogen/>" ;; autoheader*) - echo "You should only need it if you modified 'acconfig.h' or" + echo "You should only need it if you modified $autoheader_deps or" echo "$configure_deps." - program_details 'autoheader' ;; automake*) - echo "You should only need it if you modified 'Makefile.am' or" - echo "$configure_deps." - program_details 'automake' - ;; - aclocal*) - echo "You should only need it if you modified 'acinclude.m4' or" + echo "You should only need it if you modified $automake_deps or" echo "$configure_deps." - program_details 'aclocal' ;; - autom4te*) + autom4te*) echo "You might have modified some maintainer files that require" echo "the 'autom4te' program to be rebuilt." - program_details 'autom4te' + ;; + autoreconf*) + echo "You should only need it if you modified $aclocal_deps or" + echo "$automake_deps or $autoheader_deps or $automake_deps or" + echo "$configure_deps." ;; bison*|yacc*) echo "You should only need it if you modified a '.y' file." echo "You may want to install the GNU Bison package:" echo "<$gnu_software_URL/bison/>" ;; - lex*|flex*) - echo "You should only need it if you modified a '.l' file." - echo "You may want to install the Fast Lexical Analyzer package:" - echo "<$flex_URL>" - ;; help2man*) echo "You should only need it if you modified a dependency" \ "of a man page." echo "You may want to install the GNU Help2man package:" echo "<$gnu_software_URL/help2man/>" ;; + lex*|flex*) + echo "You should only need it if you modified a '.l' file." + echo "You may want to install the Fast Lexical Analyzer package:" + echo "<$flex_URL>" + ;; makeinfo*) echo "You should only need it if you modified a '.texi' file, or" echo "any other file indirectly affecting the aspect of the manual." @@ -189,6 +203,12 @@ echo "want to install GNU make:" echo "<$gnu_software_URL/make/>" ;; + perl*) + echo "You should only need it to run GNU Autoconf, GNU Automake, " + echo " assorted other tools, or if you modified a Perl source file." + echo "You may want to install the Perl 5 language interpreter:" + echo "<$perl_URL>" + ;; *) echo "You might have modified some files without having the proper" echo "tools for further handling them. Check the 'README' file, it" @@ -197,6 +217,7 @@ echo "case some other package contains this missing '$1' program." ;; esac + program_details "$normalized_program" } give_advice "$1" | sed -e '1s/^/WARNING: /' \ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xclipboard-1.1.4/xclipboard.c new/xclipboard-1.1.5/xclipboard.c --- old/xclipboard-1.1.4/xclipboard.c 2022-07-10 23:50:09.000000000 +0200 +++ new/xclipboard-1.1.5/xclipboard.c 2024-08-27 03:40:41.000000000 +0200 @@ -135,8 +135,10 @@ ClipPtr newClip; newClip = calloc (1, sizeof (ClipRec)); - if (!newClip) + if (!newClip) { + XtError("Failed to allocate memory for ClipRec\n"); return newClip; + } newClip->prev = old; if (old) { @@ -377,11 +379,13 @@ } } +static char empty_string[] = ""; + /* ARGUSED */ static void NewCurrentClip(Widget w, XEvent *ev, String *parms, Cardinal *np) { - NewCurrentClipContents ("", 0); + NewCurrentClipContents (empty_string, 0); } static void @@ -417,7 +421,7 @@ { XawTextBlock block; - block.ptr = ""; + block.ptr = empty_string; block.length = 0; block.firstPos = 0; block.format = FMT8BIT; @@ -459,7 +463,7 @@ int *format) { Display *d = XtDisplay(w); - Atom target = (Atom)client_data; + Atom target = *((Atom *)client_data); Boolean convert_failed = (*type == XT_CONVERT_FAIL); if (!convert_failed) @@ -489,9 +493,10 @@ /* if UTF8_STRING failed try COMPOUND_TEXT */ if (target == XA_UTF8_STRING(d)) { - XtGetSelectionValue(w, *selection, XA_COMPOUND_TEXT(d), + Atom compound_text = XA_COMPOUND_TEXT(d); + XtGetSelectionValue(w, *selection, compound_text, InsertClipboard, - (XtPointer)(XA_COMPOUND_TEXT(d)), + &compound_text, CurrentTime); return; } @@ -633,8 +638,9 @@ LoseSelection(Widget w, Atom *selection) { Display *d = XtDisplay(w); - XtGetSelectionValue(w, *selection, XA_UTF8_STRING(d), InsertClipboard, - (XtPointer)(XA_UTF8_STRING(d)), CurrentTime); + Atom utf8_string = XA_UTF8_STRING(d); + XtGetSelectionValue(w, *selection, utf8_string, InsertClipboard, + &utf8_string, CurrentTime); } /*ARGSUSED*/