Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package xtrans for openSUSE:Factory checked in at 2024-10-14 13:06:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/xtrans (Old) and /work/SRC/openSUSE:Factory/.xtrans.new.19354 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xtrans" Mon Oct 14 13:06:25 2024 rev:19 rq:1207659 version:1.5.1 Changes: -------- --- /work/SRC/openSUSE:Factory/xtrans/xtrans.changes 2024-02-27 22:45:00.339265654 +0100 +++ /work/SRC/openSUSE:Factory/.xtrans.new.19354/xtrans.changes 2024-10-14 13:06:28.654866374 +0200 @@ -1,0 +2,23 @@ +Sun Oct 13 19:15:17 UTC 2024 - Stefan Dirsch <sndir...@suse.com> + +- Update to 1.5.1 + * gitlab CI: add xz-utils to container for "make distcheck" + * gitlab CI: collect config.log to help diagnose failures + * gitlab CI: add libc-dev to required packages in build container + * LocalInitTransports: Fix -Wuseless-cast warning for getenv() call + * SocketCreateListener: Fix -Wuseless-cast warning in bind() call + * Clear numerous -Wsign-compare warnings from gcc 14.1 + * SocketINETConnect: return failure when malloc() fails + * ParseAddress: return failure when strdup() fails + * MakeAllCOTSServerListeners: Initialize temp_ciptrs + * GetMyNetworkId: Avoid writing to NULL pointer if malloc() fails + * GetPeerNetworkId: Avoid writing to NULL pointer if malloc() fails + * GetPeerNetworkId: avoid calling strlen() on a NULL pointer + * SocketOpen: avoid leak of out-of-range fd + * is_numeric: Add TRANS_SERVER to required ifdefs + * update .gitignore + * TRANS(ParseAddress): Fix "assignment discards âconstâ qualifier" warnings + * TRANS(GetHostname): Fix "âstrncpyâ output truncated.." warning + * Fix string length check + +------------------------------------------------------------------- Old: ---- xtrans-1.5.0.tar.xz New: ---- xtrans-1.5.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xtrans.spec ++++++ --- /var/tmp/diff_new_pack.jm9hAc/_old 2024-10-14 13:06:29.134886524 +0200 +++ /var/tmp/diff_new_pack.jm9hAc/_new 2024-10-14 13:06:29.138886691 +0200 @@ -1,7 +1,7 @@ # # spec file for package xtrans # -# Copyright (c) 2023 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: xtrans -Version: 1.5.0 +Version: 1.5.1 Release: 0 Summary: Library to handle network protocol transport in X License: MIT ++++++ xtrans-1.5.0.tar.xz -> xtrans-1.5.1.tar.xz ++++++ ++++ 9287 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/ChangeLog new/xtrans-1.5.1/ChangeLog --- old/xtrans-1.5.0/ChangeLog 2023-06-03 02:34:39.000000000 +0200 +++ new/xtrans-1.5.1/ChangeLog 2024-10-12 22:45:26.000000000 +0200 @@ -1,3 +1,300 @@ +commit df6ae7c7e0b6241a05ad2814bced637b00b1a83f +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Oct 12 13:39:19 2024 -0700 + + xtrans 1.5.1 + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 0f153064bfa4bb69e86f3f2383f2f421f2360319 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 18:19:45 2024 -0700 + + is_numeric: Add TRANS_SERVER to required ifdefs + + Avoids -Wunused-function warnings when only building for TRANS_CLIENT + code, such as libFS. + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 957adac35fb77d5a72f676d697f32ce94ab7392f +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 18:12:16 2024 -0700 + + SocketOpen: avoid leak of out-of-range fd + + Clears gcc 14.1 warning: + + /usr/include/X11/Xtrans/Xtranssock.c: In function â_FSTransSocketOpenâ: + /usr/include/X11/Xtrans/Xtranssock.c:425:9: warning: leak of file descriptor + [CWE-775] [-Wanalyzer-fd-leak] + 425 | free (ciptr); + | ^~~~~~~~~~~~ + [...] + | 415 | || ciptr->fd >= sysconf(_SC_OPEN_MAX) + | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | | | + | | | (62) ...to here + | | (63) following âtrueâ branch... + [...] + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit bea5a32105aebdc99f84f9ee4b70de7a116eb1d7 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:49:58 2024 -0700 + + GetPeerNetworkId: avoid calling strlen() on a NULL pointer + + Various failure states may leave addr set to NULL instead of a string. + + Clears warnings from gcc 14.1: + + /usr/include/X11/Xtrans/Xtransutil.c: In function â_IceTransGetPeerNetworkIdâ: + /usr/include/X11/Xtrans/Xtransutil.c:402:62: warning: use of NULL âaddrâ + where non-null expected [CWE-476] [-Wanalyzer-null-argument] + 402 | hostname = malloc (strlen (ciptr->transptr->TransName) + strlen (addr) + 2); + | ^~~~~~~~~~~~ + <built-in>: note: argument 1 of â__builtin_strlenâ must be non-null + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit e5390ab716fb470ac4b5fd7a4133eabbfaac994e +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:44:41 2024 -0700 + + GetPeerNetworkId: Avoid writing to NULL pointer if malloc() fails + + Clears gcc 14.1 warning: + + /usr/include/X11/Xtrans/Xtransutil.c:403:5: warning: use of possibly-NULL + âhostnameâ where non-null expected [CWE-690] + [-Wanalyzer-possible-null-argument] + 403 | strcpy (hostname, ciptr->transptr->TransName); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + <built-in>: note: argument 1 of â__builtin_strcpyâ must be non-null + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 215e8db07d05d425714b05b8a439c73735f9d04f +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:40:10 2024 -0700 + + GetMyNetworkId: Avoid writing to NULL pointer if malloc() fails + + Clears warnings from gcc 14.1: + + In file included from /usr/include/X11/Xtrans/transport.c:70: + /usr/include/X11/Xtrans/Xtransutil.c: In function â_IceTransGetMyNetworkIdâ: + /usr/include/X11/Xtrans/Xtransutil.c:253:9: warning: use of possibly-NULL + ânetworkIdâ where non-null expected [CWE-690] + [-Wanalyzer-possible-null-argument] + 253 | sprintf (networkId, "%s/%s:%s", transName, + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + 254 | hostnamebuf, saddr->sun_path); + | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + <built-in>: note: argument 1 of â__builtin_sprintfâ must be non-null + + /usr/include/X11/Xtrans/Xtransutil.c:283:9: warning: use of possibly-NULL + ânetworkIdâ where non-null expected [CWE-690] + [-Wanalyzer-possible-null-argument] + 283 | sprintf (networkId, "%s/%s:%s", transName, hostnamebuf, portnumbuf); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + <built-in>: note: argument 1 of â__builtin_sprintfâ must be non-null + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 376744aa60ff8df0ddbcf090f0177c15706df71e +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:33:13 2024 -0700 + + MakeAllCOTSServerListeners: Initialize temp_ciptrs + + I don't think this is strictly necessary, but it shouldn't hurt and + makes gcc 14.1 stop warning about: + + /usr/include/X11/Xtrans/Xtrans.c: In function + â_IceTransMakeAllCOTSServerListenersâ: + /usr/include/X11/Xtrans/Xtrans.h:108:21: warning: use of uninitialized + value âtemp_ciptrs[j]â [CWE-457] [-Wanalyzer-use-of-uninitialized-value] + 108 | #define TRANS(func) _IceTrans##func + /usr/include/X11/Xtrans/Xtrans.c:1203:21: note: in expansion of macro âTRANSâ + 1203 | TRANS(Close) (temp_ciptrs[j]); + | ^~~~~ + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 742462a572e524ae82a8c18106c03820da322102 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:23:10 2024 -0700 + + ParseAddress: return failure when strdup() fails + + Clears warning from gcc 14.1: + In file included from /usr/include/X11/Xtrans/transport.c:69: + /usr/include/X11/Xtrans/Xtrans.c: In function â_IceTransParseAddressâ: + /usr/include/X11/Xtrans/Xtrans.c:246:19: warning: use of possibly-NULL âmybufâ + where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument] + 246 | if ( ((mybuf = strchr (mybuf,'/')) == NULL) && + | ^~~~~~~~~~~~~~~~~~ + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit e9ead32308c588e5c12dbfb6a6452e0f2c88bafd +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:18:01 2024 -0700 + + SocketINETConnect: return failure when malloc() fails + + Clears warning from gcc 14.1: + In file included from /usr/include/X11/Xtrans/transport.c:67: + /usr/include/X11/Xtrans/Xtranssock.c: In function â_IceTransSocketINETConnectâ: + /usr/include/X11/Xtrans/Xtranssock.c:1385:33: warning: dereference of + possibly-NULL âaddrlistâ [CWE-690] [-Wanalyzer-possible-null-dereference] + 1385 | addrlist->firstaddr = NULL; + | ^ + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 4792e9e798de327572aba1575438b6936a55c7ef +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 17:11:28 2024 -0700 + + Clear numerous -Wsign-compare warnings from gcc 14.1 + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 9ad6c6764f0517f91492c04ae03a59f53229ef69 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 16:52:05 2024 -0700 + + SocketCreateListener: Fix -Wuseless-cast warning in bind() call + + sockname is defined as struct sockaddr * in the arguments to + SocketCreateListener so we don't need to cast to that when calling bind() + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit 9ed4f5ec909cf262a2404012768858792f976e36 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Sat Aug 24 16:51:17 2024 -0700 + + LocalInitTransports: Fix -Wuseless-cast warning for getenv() call + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/20> + +commit edd3f51328df9c621277168c9dd77b1e80ccfd7c +Author: Robert Royals <robert.roy...@protonmail.com> +Date: Sun Jul 21 22:54:27 2024 +0100 + + Fix string length check + + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/19> + +commit 656d27ed32af4082e8062c1d7c42b65ea3a6b80f +Author: Kim Woelders <k...@woelders.dk> +Date: Thu Mar 28 18:01:20 2024 +0100 + + TRANS(GetHostname): Fix "âstrncpyâ output truncated.." warning + + Occurs when compiling xserver master with gcc 13.2.1. + + In file included from /local/stuff/xorg/include/X11/Xtrans/transport.c:69: + In function â_XSERVTransGetHostnameâ, + inlined from â_XSERVTransConvertAddressâ at /local/stuff/xorg/include/X11/Xtrans/Xtransutil.c:188:12: + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c:1352:5: warning: âstrncpyâ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] + 1352 | strncpy (buf, name.nodename, len); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c:1350:11: note: length computed here + 1350 | len = strlen (name.nodename); + | ^~~~~~~~~~~~~~~~~~~~~~ + + Signed-off-by: Kim Woelders <k...@woelders.dk> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/16> + +commit 6171150fe9f8edad3f1cfb14cec59e6a42a9c15b +Author: Kim Woelders <k...@woelders.dk> +Date: Thu Mar 28 17:29:26 2024 +0100 + + TRANS(ParseAddress): Fix "assignment discards âconstâ qualifier" warnings + + Occurs when compiling xserver master with gcc 13.2.1. + + In file included from /local/stuff/xorg/include/X11/Xtrans/transport.c:69, + from ../os/xstrans.c:17: + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c: In function â_XSERVTransParseAddressâ: + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c:216:15: warning: assignment discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers] + 216 | _host = ""; + | ^ + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c:217:15: warning: assignment discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers] + 217 | _port = address; + | ^ + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c:229:15: warning: assignment discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers] + 229 | _host = ""; + | ^ + /local/stuff/xorg/include/X11/Xtrans/Xtrans.c:230:15: warning: assignment discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers] + 230 | _port = address + 5; + | ^ + + Signed-off-by: Kim Woelders <k...@woelders.dk> + Part-of: <https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/merge_requests/16> + +commit c219be946b1d8a641dcbc7a60904293f105e2866 +Author: Enrico Weigelt, metux IT consult <i...@metux.net> +Date: Wed Apr 3 12:11:48 2024 +0200 + + update .gitignore + + Add some yet missing auto-generated files. + + Signed-off-by: Enrico Weigelt, metux IT consult <i...@metux.net> + +commit 806f04c6e4529358f160e53135baf105e4ecf3b8 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Fri Oct 13 13:37:49 2023 -0700 + + gitlab CI: add libc-dev to required packages in build container + + Resolves configure failure: + configure:3823: checking whether the C compiler works + configure:3845: gcc conftest.c >&5 + /usr/bin/ld: cannot find Scrt1.o: No such file or directory + /usr/bin/ld: cannot find crti.o: No such file or directory + collect2: error: ld returned 1 exit status + configure:3849: $? = 1 + configure:3889: result: no + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 3aa3c318ded5da802e181f0d29b94ab6a692e387 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Fri Oct 13 13:32:15 2023 -0700 + + gitlab CI: collect config.log to help diagnose failures + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + +commit 6d5a4512b5ee4757a474df3f5e938784da963de1 +Author: Alan Coopersmith <alan.coopersm...@oracle.com> +Date: Fri Oct 13 13:26:49 2023 -0700 + + gitlab CI: add xz-utils to container for "make distcheck" + + Also update to latest ci-templates + + Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> + commit 3b3a3bd75d86aec78f6ef893b198c3efc378bc64 Author: Alan Coopersmith <alan.coopersm...@oracle.com> Date: Fri Jun 2 17:29:41 2023 -0700 @@ -598,7 +895,7 @@ Signed-off-by: Hans de Goede <hdego...@redhat.com> commit e1e6121a1638d43d9929589b4723da2b38cb6b44 -Author: Åukasz Stelmach <l.stelm...@samsung.com> +Author: Åukasz Stelmach <l.stelm...@samsung.com> Date: Mon Nov 25 11:11:54 2013 +0100 Enable systemd socket activation @@ -619,7 +916,7 @@ Acked-by: Peter Hutterer <peter.hutte...@who-t.net> commit b895d45e225dd3d1bf9d598774d3ae4f29fcbc25 -Author: Åukasz Stelmach <l.stelm...@samsung.com> +Author: Åukasz Stelmach <l.stelm...@samsung.com> Date: Thu Nov 28 12:57:21 2013 +0100 Define TRANS_RECEIVED flag for transports @@ -834,7 +1131,7 @@ Signed-off-by: Keith Packard <kei...@keithp.com> commit f6a161f2a003f4da0a2e414b4faa0ee0de0c01f0 -Author: Åukasz Stelmach <l.stelm...@samsung.com> +Author: Åukasz Stelmach <l.stelm...@samsung.com> Date: Tue Jul 9 16:24:43 2013 +0200 Add const qualifier to unix_nolisten @@ -1518,7 +1815,7 @@ Signed-off-by: Alan Coopersmith <alan.coopersm...@sun.com> commit dab2bcdaf60977643ec55d71a81e67c1e3a162a9 -Author: Rémi Cardona <r...@gentoo.org> +Author: Rémi Cardona <r...@gentoo.org> Date: Thu Dec 17 08:31:20 2009 +0100 require autoconf 2.60 because of $(docdir) use @@ -1976,7 +2273,7 @@ <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6688467> commit 556a351de83fc6f401b02213dae95731553c216d -Author: Loïc Minier <l...@dooz.org> +Author: Loïc Minier <l...@dooz.org> Date: Mon Mar 24 15:38:27 2008 -0400 Bug #10489: Don't retry unix socket connect()s on ENOENT. @@ -2393,7 +2690,7 @@ Make includedir=@includedir@ in xtrans.pc.in, not with /X11/Xtrans. commit b413f4c1dddc467014adf16bfe31627e65508c12 -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Wed Jun 22 22:46:39 2005 +0000 Apply these patches from Theo van Klaveren: @@ -2409,7 +2706,7 @@ platforms that don't define it in the system headers. commit f5a6a188407cec6e567070d192aac2db72cacd92 -Author: Kristian Høgsberg <k...@redhat.com> +Author: Kristian Høgsberg <k...@redhat.com> Date: Wed Jun 22 01:21:24 2005 +0000 Apply patch by Alan Coopersmith from #1605 to fix address resolution of @@ -2437,7 +2734,7 @@ prefix's aclocal dir is not in a default path for system aclocal. commit 58c7263ca5b64a21dc101bb4b24201ba67a8d068 -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Wed May 25 21:47:56 2005 +0000 - Add FSlib to symlink.sh @@ -2484,7 +2781,7 @@ Require automake 1.7 in AM_INIT_AUTOMAKE commit daa7168e9e0cdff5eb06b0c9a7155f8880681fff -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Fri May 13 22:53:43 2005 +0000 - For now put xtrans in X11/Xtrans/X11, since libX11 is looking for it in @@ -2498,32 +2795,32 @@ - Conditionally include config.h in Xlib source commit d11d95fa4faec21655625b7de27d8a71c08ffe2d -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Fri May 13 15:16:43 2005 +0000 Dummy changes to ChangeLog/configure.ac to see if that fixes group permissions commit b8a8c31f63a543d1c1c6bb4ae26a4019b4400edc -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Fri May 13 15:04:52 2005 +0000 Re-adding ChangeLog and configure.ac files commit 798c08054ce5a8238f35fee3e69218ece74441fa -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Fri May 13 15:02:19 2005 +0000 Temporarily remove ChangeLog configure.ac commit b3da86ae588df14dde916674a4f6593edf1964f7 -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Fri May 13 14:43:37 2005 +0000 Dummy commit to see if that fixes the group execute permissions commit ea04267da780c2c3f08a710d15468565897420c4 -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Thu May 12 16:12:34 2005 +0000 Make xtrans install in $(includedir)/X11/Xtrans. Remove all references to @@ -2538,7 +2835,7 @@ Add Xtransdef.h.in as an AM_CONFIG_HEADER. commit d628bf24f2bf0d017394b6961784d7ac5b33f46b -Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> +Author: Søren Sandmann Pedersen <sandm...@daimi.au.dk> Date: Wed May 11 22:44:52 2005 +0000 lib/Xau: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/Xtrans.c new/xtrans-1.5.1/Xtrans.c --- old/xtrans-1.5.0/Xtrans.c 2023-06-03 02:34:28.000000000 +0200 +++ new/xtrans-1.5.1/Xtrans.c 2024-10-12 22:45:16.000000000 +0200 @@ -150,7 +150,6 @@ #ifndef HAVE_STRCASECMP char protobuf[PROTOBUFSIZE]; #endif - int i; prmsg (3,"SelectTransport(%s)\n", protocol); @@ -170,7 +169,7 @@ /* Look at all of the configured protocols */ - for (i = 0; i < NUMTRANS; i++) + for (unsigned int i = 0; i < NUMTRANS; i++) { #ifndef HAVE_STRCASECMP if (!strcmp (protobuf, Xtransports[i].transport->TransName)) @@ -204,8 +203,9 @@ char *mybuf, *tmpptr = NULL; const char *_protocol = NULL; - char *_host, *_port; + const char *_host, *_port; char hostnamebuf[256]; + char *_host_buf; int _host_len; prmsg (3,"ParseAddress(%s)\n", address); @@ -243,9 +243,10 @@ _protocol = mybuf; - if ( ((mybuf = strchr (mybuf,'/')) == NULL) && - ((mybuf = strrchr (tmpptr,':')) == NULL) ) - { + if ((mybuf == NULL) || + ( ((mybuf = strchr (mybuf, '/')) == NULL) && + ((mybuf = strrchr (tmpptr, ':')) == NULL) ) ) + { /* address is in a bad format */ *protocol = NULL; *host = NULL; @@ -293,7 +294,7 @@ /* Get the host part */ - _host = mybuf; + _host = _host_buf = mybuf; if ((mybuf = strrchr (mybuf,':')) == NULL) { @@ -316,10 +317,10 @@ /* hostname in IPv6 [numeric_addr]:0 form? */ else if ( (_host_len > 3) && ((strcmp(_protocol, "tcp") == 0) || (strcmp(_protocol, "inet6") == 0)) - && (*_host == '[') && (*(_host + _host_len - 1) == ']') ) { + && (_host_buf[0] == '[') && (_host_buf[_host_len - 1] == ']') ) { struct sockaddr_in6 sin6; - *(_host + _host_len - 1) = '\0'; + _host_buf[_host_len - 1] = '\0'; /* Verify address is valid IPv6 numeric form */ if (inet_pton(AF_INET6, _host + 1, &sin6) == 1) { @@ -328,7 +329,7 @@ _protocol = "inet6"; } else { /* It's not, restore it just in case some other code can use it. */ - *(_host + _host_len - 1) = ']'; + _host_buf[_host_len - 1] = ']'; } } #endif @@ -499,18 +500,19 @@ XtransConnInfo ciptr = NULL; Xtransport *thistrans = NULL; char *save_port; - int i; prmsg (2,"Reopen(%d,%d,%s)\n", trans_id, fd, port); /* Determine the transport type */ - for (i = 0; i < NUMTRANS; i++) + for (unsigned int i = 0; i < NUMTRANS; i++) + { if (Xtransports[i].transport_id == trans_id) { thistrans = Xtransports[i].transport; break; } + } if (thistrans == NULL) { @@ -602,9 +604,8 @@ int *trans_id, int *fd, char **port) { - int i; - - for (i = 0; i < NUMTRANS; i++) + for (unsigned int i = 0; i < NUMTRANS; i++) + { if (Xtransports[i].transport == ciptr->transptr) { *trans_id = Xtransports[i].transport_id; @@ -615,6 +616,7 @@ else return 1; } + } return 0; } @@ -1020,13 +1022,12 @@ { int count = 0; int found_local = 0; - int i; /* * For a complete network, we only need one LOCALCONN transport to work */ - for (i = 0; i < NUMTRANS; i++) + for (unsigned int i = 0; i < NUMTRANS; i++) { if (Xtransports[i].transport->flags & TRANS_ALIAS || Xtransports[i].transport->flags & TRANS_NOLISTEN) @@ -1059,7 +1060,7 @@ return -1; } - for (i = 0; i < systemd_listen_fds && *count_ret < NUMTRANS; i++) + for (i = 0; i < systemd_listen_fds && *count_ret < (int)NUMTRANS; i++) { struct sockaddr_storage a; int ti; @@ -1126,8 +1127,8 @@ { char buffer[256]; /* ??? What size ?? */ - XtransConnInfo ciptr, temp_ciptrs[NUMTRANS]; - int status, i, j; + XtransConnInfo ciptr, temp_ciptrs[NUMTRANS] = { NULL }; + int status, j; #if defined(IPv6) && defined(AF_INET6) int ipv6_succ = 0; @@ -1151,7 +1152,7 @@ if (receive_listening_fds(port, temp_ciptrs, count_ret) < 0) return -1; - for (i = 0; i < NUMTRANS; i++) + for (unsigned int i = 0; i < NUMTRANS; i++) { Xtransport *trans = Xtransports[i].transport; unsigned int flags = 0; @@ -1199,7 +1200,8 @@ "MakeAllCOTSServerListeners: server already running\n"); for (j = 0; j < *count_ret; j++) - TRANS(Close) (temp_ciptrs[j]); + if (temp_ciptrs[j] != NULL) + TRANS(Close) (temp_ciptrs[j]); *count_ret = 0; *ciptrs_ret = NULL; @@ -1243,7 +1245,7 @@ return -1; } - for (i = 0; i < *count_ret; i++) + for (int i = 0; i < *count_ret; i++) { (*ciptrs_ret)[i] = temp_ciptrs[i]; } @@ -1348,7 +1350,7 @@ uname (&name); len = strlen (name.nodename); if (len >= maxlen) len = maxlen - 1; - strncpy (buf, name.nodename, len); + memcpy (buf, name.nodename, len); buf[len] = '\0'; #else buf[0] = '\0'; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/Xtranslcl.c new/xtrans-1.5.1/Xtranslcl.c --- old/xtrans-1.5.0/Xtranslcl.c 2023-06-03 02:34:28.000000000 +0200 +++ new/xtrans-1.5.1/Xtranslcl.c 2024-10-12 22:45:16.000000000 +0200 @@ -747,7 +747,7 @@ workingXLOCAL = freeXLOCAL = strdup (protocol); } else { - XLOCAL=(char *)getenv("XLOCAL"); + XLOCAL = getenv("XLOCAL"); if(XLOCAL==NULL) XLOCAL=DEF_XLOCAL; workingXLOCAL = freeXLOCAL = strdup (XLOCAL); @@ -771,7 +771,6 @@ TRANS(LocalGetNextTransport)(void) { - int i; char *typetocheck; prmsg(3,"LocalGetNextTransport()\n"); @@ -785,7 +784,7 @@ if(workingXLOCAL && *workingXLOCAL) *workingXLOCAL++='\0'; - for(i=0;i<NUMTRANSPORTS;i++) + for (unsigned int i = 0; i < NUMTRANSPORTS; i++) { #ifndef HAVE_STRCASECMP int j; @@ -948,7 +947,6 @@ const char *host _X_UNUSED, const char *port) { - int i; XtransConnInfo ciptr; prmsg(2,"LocalOpenServer(%d,%s,%s)\n", type, protocol, port); @@ -969,7 +967,7 @@ return NULL; } - for(i=1;i<NUMTRANSPORTS;i++) + for (unsigned int i = 1; i < NUMTRANSPORTS; i++) { if( strcmp(protocol,LOCALtrans2devtab[i].transname) != 0 ) continue; @@ -1120,7 +1118,7 @@ TRANS(LocalReopenCOTSServer)(Xtransport *thistrans, int fd, const char *port) { - int index; + unsigned int index; prmsg(2,"LocalReopenCOTSServer(%d,%s)\n", fd, port); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/Xtranssock.c new/xtrans-1.5.1/Xtranssock.c --- old/xtrans-1.5.0/Xtranssock.c 2023-06-03 02:34:28.000000000 +0200 +++ new/xtrans-1.5.1/Xtranssock.c 2024-10-12 22:45:16.000000000 +0200 @@ -196,7 +196,7 @@ static int TRANS(SocketINETClose) (XtransConnInfo ciptr); #endif -#if defined(TCPCONN) || defined(TRANS_REOPEN) +#if (defined(TCPCONN) && defined(TRANS_SERVER)) || defined(TRANS_REOPEN) static int is_numeric (const char *str) { @@ -259,7 +259,7 @@ prmsg (3,"SocketSelectFamily(%s)\n", family); - for (i = first + 1; i < NUMSOCKETFAMILIES;i++) + for (i = first + 1; i < (int)NUMSOCKETFAMILIES; i++) { if (!strcmp (family, Sockettrans2devtab[i].transname)) return i; @@ -408,14 +408,22 @@ return NULL; } - if ((ciptr->fd = socket(Sockettrans2devtab[i].family, type, - Sockettrans2devtab[i].protocol)) < 0 + ciptr->fd = socket(Sockettrans2devtab[i].family, type, + Sockettrans2devtab[i].protocol); + #ifndef WIN32 #if (defined(X11_t) && !defined(USE_POLL)) || defined(FS_t) || defined(FONT_t) - || ciptr->fd >= sysconf(_SC_OPEN_MAX) + if (ciptr->fd >= sysconf(_SC_OPEN_MAX)) + { + prmsg (2, "SocketOpen: socket() returned out of range fd %d\n", + ciptr->fd); + close (ciptr->fd); + ciptr->fd = -1; + } #endif #endif - ) { + + if (ciptr->fd < 0) { #ifdef WIN32 errno = WSAGetLastError(); #endif @@ -732,7 +740,7 @@ set_sun_path(const char *port, const char *upath, char *path, int abstract) { struct sockaddr_un s; - int maxlen = sizeof(s.sun_path) - 1; + ssize_t maxlen = sizeof(s.sun_path) - 1; const char *at = ""; if (!port || !*port || !path) @@ -748,7 +756,7 @@ if (*port == '/') /* a full pathname */ upath = ""; - if (strlen(port) + strlen(upath) > maxlen) + if ((ssize_t)(strlen(at) + strlen(upath) + strlen(port)) > maxlen) return -1; snprintf(path, sizeof(s.sun_path), "%s%s%s", at, upath, port); return 0; @@ -778,7 +786,7 @@ else retry = 0; - while (bind (fd, (struct sockaddr *) sockname, namelen) < 0) + while (bind (fd, sockname, namelen) < 0) { if (errno == EADDRINUSE) { if (flags & ADDR_IN_USE_ALLOWED) @@ -1382,6 +1390,11 @@ } } else { addrlist = malloc(sizeof(struct addrlist)); + if (addrlist == NULL) { + prmsg (1, "SocketINETConnect() can't allocate memory " + "for addrlist: %s\n", strerror(errno)); + return TRANS_CONNECT_FAILED; + } addrlist->firstaddr = NULL; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/Xtransutil.c new/xtrans-1.5.1/Xtransutil.c --- old/xtrans-1.5.0/Xtransutil.c 2023-06-03 02:34:28.000000000 +0200 +++ new/xtrans-1.5.1/Xtransutil.c 2024-10-12 22:45:16.000000000 +0200 @@ -250,8 +250,9 @@ struct sockaddr_un *saddr = (struct sockaddr_un *) addr; networkId = malloc (3 + strlen (transName) + strlen (hostnamebuf) + strlen (saddr->sun_path)); - sprintf (networkId, "%s/%s:%s", transName, - hostnamebuf, saddr->sun_path); + if (networkId != NULL) + sprintf (networkId, "%s/%s:%s", transName, + hostnamebuf, saddr->sun_path); break; } #endif /* defined(UNIXCONN) || defined(LOCALCONN) */ @@ -280,7 +281,8 @@ snprintf (portnumbuf, sizeof(portnumbuf), "%d", portnum); networkId = malloc (3 + strlen (transName) + strlen (hostnamebuf) + strlen (portnumbuf)); - sprintf (networkId, "%s/%s:%s", transName, hostnamebuf, portnumbuf); + if (networkId != NULL) + sprintf (networkId, "%s/%s:%s", transName, hostnamebuf, portnumbuf); break; } #endif /* defined(TCPCONN) */ @@ -399,12 +401,15 @@ } - hostname = malloc (strlen (ciptr->transptr->TransName) + strlen (addr) + 2); - strcpy (hostname, ciptr->transptr->TransName); - strcat (hostname, "/"); - if (addr) - strcat (hostname, addr); - + hostname = malloc (strlen (ciptr->transptr->TransName) + + (addr ? strlen (addr) : 0) + 2); + if (hostname) + { + strcpy (hostname, ciptr->transptr->TransName); + strcat (hostname, "/"); + if (addr) + strcat (hostname, addr); + } return (hostname); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/compile new/xtrans-1.5.1/compile --- old/xtrans-1.5.0/compile 2023-06-03 02:34:32.000000000 +0200 +++ new/xtrans-1.5.1/compile 2024-10-12 22:45:20.000000000 +0200 @@ -1,9 +1,9 @@ #! /bin/sh # Wrapper for compilers which do not understand '-c -o'. -scriptversion=2018-03-07.03; # UTC +scriptversion=2024-06-19.01; # UTC -# Copyright (C) 1999-2021 Free Software Foundation, Inc. +# Copyright (C) 1999-2024 Free Software Foundation, Inc. # Written by Tom Tromey <tro...@cygnus.com>. # # This program is free software; you can redistribute it and/or modify @@ -143,7 +143,7 @@ # configure might choose to run compile as 'compile cc -o foo foo.c'. eat=1 case $2 in - *.o | *.[oO][bB][jJ]) + *.o | *.lo | *.[oO][bB][jJ]) func_file_conv "$2" set x "$@" -Fo"$file" shift @@ -248,14 +248,17 @@ right script to run: please start by reading the file 'INSTALL'. Report bugs to <bug-autom...@gnu.org>. +GNU Automake home page: <https://www.gnu.org/software/automake/>. +General help using GNU software: <https://www.gnu.org/gethelp/>. EOF exit $? ;; -v | --v*) - echo "compile $scriptversion" + echo "compile (GNU Automake) $scriptversion" exit $? ;; cl | *[/\\]cl | cl.exe | *[/\\]cl.exe | \ + clang-cl | *[/\\]clang-cl | clang-cl.exe | *[/\\]clang-cl.exe | \ icl | *[/\\]icl | icl.exe | *[/\\]icl.exe ) func_cl_wrapper "$@" # Doesn't return... ;; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/configure.ac new/xtrans-1.5.1/configure.ac --- old/xtrans-1.5.0/configure.ac 2023-06-03 02:34:28.000000000 +0200 +++ new/xtrans-1.5.1/configure.ac 2024-10-12 22:45:16.000000000 +0200 @@ -21,8 +21,8 @@ # Initialize Autoconf AC_PREREQ([2.60]) -AC_INIT([xtrans], [1.5.0], - [https://gitlab.freedesktop.org/xorg/lib/libxtrans/issues], [xtrans]) +AC_INIT([xtrans], [1.5.1], + [https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/issues], [xtrans]) AC_CONFIG_SRCDIR([Makefile.am]) # Initialize Automake diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xtrans-1.5.0/missing new/xtrans-1.5.1/missing --- old/xtrans-1.5.0/missing 2023-06-03 02:34:32.000000000 +0200 +++ new/xtrans-1.5.1/missing 2024-10-12 22:45:20.000000000 +0200 @@ -1,9 +1,11 @@ #! /bin/sh -# Common wrapper for a few potentially missing GNU programs. +# Common wrapper for a few potentially missing GNU and other programs. -scriptversion=2018-03-07.03; # UTC +scriptversion=2024-06-07.14; # UTC -# Copyright (C) 1996-2021 Free Software Foundation, Inc. +# shellcheck disable=SC2006,SC2268 # we must support pre-POSIX shells + +# Copyright (C) 1996-2024 Free Software Foundation, Inc. # Originally written by Fran,cois Pinard <pin...@iro.umontreal.ca>, 1996. # This program is free software; you can redistribute it and/or modify @@ -54,18 +56,20 @@ -v, --version output version information and exit Supported PROGRAM values: - aclocal autoconf autoheader autom4te automake makeinfo - bison yacc flex lex help2man +aclocal autoconf autogen autoheader autom4te automake autoreconf +bison flex help2man lex makeinfo perl yacc Version suffixes to PROGRAM as well as the prefixes 'gnu-', 'gnu', and 'g' are ignored when checking the name. -Send bug reports to <bug-autom...@gnu.org>." +Report bugs to <bug-autom...@gnu.org>. +GNU Automake home page: <https://www.gnu.org/software/automake/>. +General help using GNU software: <https://www.gnu.org/gethelp/>." exit $? ;; -v|--v|--ve|--ver|--vers|--versi|--versio|--version) - echo "missing $scriptversion (GNU Automake)" + echo "missing (GNU Automake) $scriptversion" exit $? ;; @@ -108,7 +112,7 @@ program_details () { case $1 in - aclocal|automake) + aclocal|automake|autoreconf) echo "The '$1' program is part of the GNU Automake package:" echo "<$gnu_software_URL/automake>" echo "It also requires GNU Autoconf, GNU m4 and Perl in order to run:" @@ -123,6 +127,9 @@ echo "<$gnu_software_URL/m4/>" echo "<$perl_URL>" ;; + *) + : + ;; esac } @@ -137,48 +144,55 @@ printf '%s\n' "'$1' is $msg." configure_deps="'configure.ac' or m4 files included by 'configure.ac'" + autoheader_deps="'acconfig.h'" + automake_deps="'Makefile.am'" + aclocal_deps="'acinclude.m4'" case $normalized_program in + aclocal*) + echo "You should only need it if you modified $aclocal_deps or" + echo "$configure_deps." + ;; autoconf*) - echo "You should only need it if you modified 'configure.ac'," - echo "or m4 files included by it." - program_details 'autoconf' + echo "You should only need it if you modified $configure_deps." + ;; + autogen*) + echo "You should only need it if you modified a '.def' or '.tpl' file." + echo "You may want to install the GNU AutoGen package:" + echo "<$gnu_software_URL/autogen/>" ;; autoheader*) - echo "You should only need it if you modified 'acconfig.h' or" + echo "You should only need it if you modified $autoheader_deps or" echo "$configure_deps." - program_details 'autoheader' ;; automake*) - echo "You should only need it if you modified 'Makefile.am' or" - echo "$configure_deps." - program_details 'automake' - ;; - aclocal*) - echo "You should only need it if you modified 'acinclude.m4' or" + echo "You should only need it if you modified $automake_deps or" echo "$configure_deps." - program_details 'aclocal' ;; - autom4te*) + autom4te*) echo "You might have modified some maintainer files that require" echo "the 'autom4te' program to be rebuilt." - program_details 'autom4te' + ;; + autoreconf*) + echo "You should only need it if you modified $aclocal_deps or" + echo "$automake_deps or $autoheader_deps or $automake_deps or" + echo "$configure_deps." ;; bison*|yacc*) echo "You should only need it if you modified a '.y' file." echo "You may want to install the GNU Bison package:" echo "<$gnu_software_URL/bison/>" ;; - lex*|flex*) - echo "You should only need it if you modified a '.l' file." - echo "You may want to install the Fast Lexical Analyzer package:" - echo "<$flex_URL>" - ;; help2man*) echo "You should only need it if you modified a dependency" \ "of a man page." echo "You may want to install the GNU Help2man package:" echo "<$gnu_software_URL/help2man/>" ;; + lex*|flex*) + echo "You should only need it if you modified a '.l' file." + echo "You may want to install the Fast Lexical Analyzer package:" + echo "<$flex_URL>" + ;; makeinfo*) echo "You should only need it if you modified a '.texi' file, or" echo "any other file indirectly affecting the aspect of the manual." @@ -189,6 +203,12 @@ echo "want to install GNU make:" echo "<$gnu_software_URL/make/>" ;; + perl*) + echo "You should only need it to run GNU Autoconf, GNU Automake, " + echo " assorted other tools, or if you modified a Perl source file." + echo "You may want to install the Perl 5 language interpreter:" + echo "<$perl_URL>" + ;; *) echo "You might have modified some files without having the proper" echo "tools for further handling them. Check the 'README' file, it" @@ -197,6 +217,7 @@ echo "case some other package contains this missing '$1' program." ;; esac + program_details "$normalized_program" } give_advice "$1" | sed -e '1s/^/WARNING: /' \
