Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package secrets for openSUSE:Factory checked in at 2024-10-23 21:14:10 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/secrets (Old) and /work/SRC/openSUSE:Factory/.secrets.new.26871 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "secrets" Wed Oct 23 21:14:10 2024 rev:14 rq:1217331 version:10.2 Changes: -------- --- /work/SRC/openSUSE:Factory/secrets/secrets.changes 2024-10-15 15:01:04.759357186 +0200 +++ /work/SRC/openSUSE:Factory/.secrets.new.26871/secrets.changes 2024-10-23 21:15:14.575125112 +0200 @@ -1,0 +2,11 @@ +Thu Oct 17 18:23:37 UTC 2024 - Richard Rahl <rra...@opensuse.org> + +- update to 10.2: + * Correctly select element after creating it + * Prevents data corruption when saving on certain virtual file + systems + * Prevents a crash when deleting elements in trash +- Drop update-desktop-files and corresponding macro, they are not + needed on current versions of openSUSE. + +------------------------------------------------------------------- Old: ---- secrets-10.1.obscpio New: ---- secrets-10.2.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ secrets.spec ++++++ --- /var/tmp/diff_new_pack.Ik0kAu/_old 2024-10-23 21:15:15.247153168 +0200 +++ /var/tmp/diff_new_pack.Ik0kAu/_new 2024-10-23 21:15:15.247153168 +0200 @@ -23,7 +23,7 @@ %define psuffix %nil %endif Name: secrets%{psuffix} -Version: 10.1 +Version: 10.2 Release: 0 Summary: A password manager for GNOME License: GPL-3.0-only @@ -44,7 +44,6 @@ BuildRequires: python3-python-yubico BuildRequires: python3-validators BuildRequires: python3-zxcvbn-rs-py -BuildRequires: update-desktop-files BuildRequires: pkgconfig(gio-2.0) >= 2.66 BuildRequires: pkgconfig(glib-2.0) >= 2.73.0 BuildRequires: pkgconfig(gobject-introspection-1.0) >= 1.66 @@ -99,7 +98,6 @@ # generation done by meson. Should make the package reproducible. %py3_compile %{buildroot}%{python3_sitelib}/gsecrets %find_lang secrets %{?no_lang_C} -%suse_update_desktop_file org.gnome.World.Secrets appstream-util validate-relax --nonet %{buildroot}%{_datadir}/metainfo/*.xml glib-compile-schemas --strict --dry-run %{buildroot}%{_datadir}/glib-2.0/schemas/ %endif ++++++ _service ++++++ --- /var/tmp/diff_new_pack.Ik0kAu/_old 2024-10-23 21:15:15.291155004 +0200 +++ /var/tmp/diff_new_pack.Ik0kAu/_new 2024-10-23 21:15:15.295155172 +0200 @@ -3,7 +3,7 @@ <service name="obs_scm" mode="manual" > <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/secrets.git</param> - <param name="revision">refs/tags/10.1</param> + <param name="revision">refs/tags/10.2</param> <param name="versionformat">@PARENT_TAG@+@TAG_OFFSET@</param> <param name="versionrewrite-pattern">(.*)\+0</param> <param name="versionrewrite-replacement">\1</param> ++++++ secrets-10.1.obscpio -> secrets-10.2.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/secrets-10.1/data/org.gnome.World.Secrets.metainfo.xml.in.in new/secrets-10.2/data/org.gnome.World.Secrets.metainfo.xml.in.in --- old/secrets-10.1/data/org.gnome.World.Secrets.metainfo.xml.in.in 2024-09-21 16:45:35.000000000 +0200 +++ new/secrets-10.2/data/org.gnome.World.Secrets.metainfo.xml.in.in 2024-10-17 18:33:50.000000000 +0200 @@ -12,6 +12,16 @@ <p>Secrets is a password manager which makes use of the KeePass v.4 format. It integrates perfectly with the GNOME desktop and provides an easy and uncluttered interface for the management of password databases.</p> </description> <releases> + <release version="10.2" date="2024-10-17"> + <description> + <p>Minor release.</p> + <ul> + <li>Correctly select element after creating it</li> + <li>Prevents data corruption when saving on certain virtual filesystems</li> + <li>Prevents a crash when deleting elements in trash</li> + </ul> + </description> + </release> <release version="10.1" date="2024-09-21"> <description> <p>Minor release. Fixes crash while searching.</p> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/secrets-10.1/gsecrets/database_manager.py new/secrets-10.2/gsecrets/database_manager.py --- old/secrets-10.1/gsecrets/database_manager.py 2024-09-21 16:45:35.000000000 +0200 +++ new/secrets-10.2/gsecrets/database_manager.py 2024-10-17 18:33:50.000000000 +0200 @@ -166,14 +166,23 @@ logging.debug("Saving database %s", self.path) self.save_running = True - try: - self.db.save() - except Exception as err: # pylint: disable=broad-except - err = generic_error(str(err)) - task.return_error(err) - else: - self._update_file_monitor() - task.return_boolean(True) + with io.BytesIO() as buf: + try: + self.db.save(buf) + except Exception as err: # pylint: disable=broad-except + err = generic_error(str(err)) + task.return_error(err) + else: + flags = Gio.FileCreateFlags.NONE + gfile = Gio.File.new_for_path(self._path) + contents = buf.getvalue() + try: + gfile.replace_contents(contents, None, False, flags, None) + except GLib.Error as err: # pylint: disable=broad-except + task.return_error(err) + else: + self._update_file_monitor() + task.return_boolean(True) def save_finish(self, result: Gio.AsyncResult) -> bool: """Finish save_async. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/secrets-10.1/gsecrets/unlocked_database.py new/secrets-10.2/gsecrets/unlocked_database.py --- old/secrets-10.1/gsecrets/unlocked_database.py 2024-09-21 16:45:35.000000000 +0200 +++ new/secrets-10.2/gsecrets/unlocked_database.py 2024-10-17 18:33:50.000000000 +0200 @@ -196,6 +196,8 @@ self._split_view.props.content = page self._split_view.props.show_content = True + self.browsing_panel.selection_model.props.selected_item = element + def show_browser_page(self, group: SafeGroup) -> None: self.start_database_lock_timer() @@ -276,6 +278,7 @@ if element := self.active_element: parent_group = element.parentgroup self.browsing_panel.unselect(element) + self.active_element = parent_group if element.trash(): elements = [] else: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/secrets-10.1/meson.build new/secrets-10.2/meson.build --- old/secrets-10.1/meson.build 2024-09-21 16:45:35.000000000 +0200 +++ new/secrets-10.2/meson.build 2024-10-17 18:33:50.000000000 +0200 @@ -1,5 +1,5 @@ project('secrets', - version: '10.1', + version: '10.2', meson_version: '>= 0.59', license: 'GPL-3.0-only' ) ++++++ secrets.obsinfo ++++++ --- /var/tmp/diff_new_pack.Ik0kAu/_old 2024-10-23 21:15:15.535165191 +0200 +++ /var/tmp/diff_new_pack.Ik0kAu/_new 2024-10-23 21:15:15.535165191 +0200 @@ -1,5 +1,5 @@ name: secrets -version: 10.1 -mtime: 1726929935 -commit: ed045589ab24f1b902366d85cbe0722a3ee8f50b +version: 10.2 +mtime: 1729182830 +commit: 00c2d22143ffe8263814c4e122c0bc27d3c67834