Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package nethack for openSUSE:Factory checked
in at 2025-01-05 15:29:40
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/nethack (Old)
and /work/SRC/openSUSE:Factory/.nethack.new.1881 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nethack"
Sun Jan 5 15:29:40 2025 rev:2 rq:1234671 version:3.4.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/nethack/nethack.changes 2025-01-01
23:04:33.900223417 +0100
+++ /work/SRC/openSUSE:Factory/.nethack.new.1881/nethack.changes
2025-01-05 15:29:46.830120088 +0100
@@ -1,0 +2,27 @@
+Fri Jan 3 07:27:58 UTC 2025 - Thomas Zimmermann <tzimmerm...@suse.com>
+
+- Implement parallel builds for all target. The Makefiles do not
+ handle target dependencies correctly and parallel building does
+ not work reliably by default. Hence we run several rules explicitly
+ before 'all', which then uses the results. Guidebook.ps still has
+ to be build separately.
+
+- Build object files for makedefs first. Fixes possible linker errors
+ on parallel builds. The Makefiles do not track the dependencies correctly.
+ An example error is shown below.
+
+ [ 3s] cc -o makedefs makedefs.o ../src/monst.o ../src/objects.o
+ [ 3s] ld: /tmp/cckee6qh.debug.temp.o: bad reloc symbol index (0x74727473
>= 0x8) for offset 0x6261747274732e00 in section `.debug_line'
+ [ 3s] ld: /tmp/cckee6qh.debug.temp.o: error adding symbols: bad value
+ [ 3s] collect2: error: ld returned 1 exit status
+
+ (boo#1102408)
+
+- Remove the unnecessary invocation of 'make clean'.
+
+-------------------------------------------------------------------
+Fri Jan 3 05:02:08 UTC 2025 - Bernhard Wiedemann <bwiedem...@suse.com>
+
+- Build nethack/monst.o in a more reproducible way (boo#1102408)
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ nethack.spec ++++++
--- /var/tmp/diff_new_pack.UXHTbL/_old 2025-01-05 15:29:47.454145755 +0100
+++ /var/tmp/diff_new_pack.UXHTbL/_new 2025-01-05 15:29:47.458145919 +0100
@@ -1,7 +1,7 @@
#
# spec file for package nethack
#
-# Copyright (c) 2024 SUSE LLC
+# Copyright (c) 2025 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -64,13 +64,25 @@
# copy Makefiles and add optimization flags
sh sys/unix/setup.sh
sed -i "s/^CFLAGS.*/& %{optflags}/" Makefile dat/Makefile doc/Makefile
src/Makefile util/Makefile
-# tty
-make clean
-make %{?_smp_mflags} nethack
-# doc, data, recover... this part is not safe for parallel making
-make -j1 data oracles options quest.dat rumors dungeon spec_levs check-dlb
-make -j1 -C doc Guidebook.ps
-make -C util recover
+
+# The Makefiles do not track dependencies correctly, which can result
+# in link errors on parallel builds. Prevent this by building the object
+# files for makedefs first.
+%make_build -C src monst.o
+%make_build -C src objects.o
+
+# Build the game binary, then some data files. Finally build all
+# remaining default targets. Although 'all' covers the first three
+# make calls as well, we have to resort to sequential building
+# to make it work.
+%make_build nethack
+%make_build dungeon
+%make_build spec_levs
+%make_build all
+
+# We also package a nicely formatted manual in PostScript format. It
+# is not covered by 'all', so build it here.
+%make_build -C doc Guidebook.ps
%install
# directories
