Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package qt6-location for openSUSE:Factory checked in at 2025-02-03 21:43:03 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/qt6-location (Old) and /work/SRC/openSUSE:Factory/.qt6-location.new.2316 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "qt6-location" Mon Feb 3 21:43:03 2025 rev:17 rq:1242051 version:6.8.2 Changes: -------- --- /work/SRC/openSUSE:Factory/qt6-location/qt6-location.changes 2024-12-05 17:07:41.543210340 +0100 +++ /work/SRC/openSUSE:Factory/.qt6-location.new.2316/qt6-location.changes 2025-02-03 21:43:06.565481159 +0100 @@ -1,0 +2,6 @@ +Fri Jan 31 10:22:55 UTC 2025 - Christophe Marin <christo...@krop.fr> + +- Update to 6.8.2 + https://www.qt.io/blog/qt-6.8.2-released + +------------------------------------------------------------------- Old: ---- qtlocation-everywhere-src-6.8.1.tar.xz New: ---- qtlocation-everywhere-src-6.8.2.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ qt6-location.spec ++++++ --- /var/tmp/diff_new_pack.eWcKd2/_old 2025-02-03 21:43:07.425516658 +0100 +++ /var/tmp/diff_new_pack.eWcKd2/_new 2025-02-03 21:43:07.425516658 +0100 @@ -16,7 +16,7 @@ # -%define real_version 6.8.1 +%define real_version 6.8.2 %define short_version 6.8 %define tar_name qtlocation-everywhere-src %define tar_suffix %{nil} @@ -27,7 +27,7 @@ %endif # Name: qt6-location%{?pkg_suffix} -Version: 6.8.1 +Version: 6.8.2 Release: 0 Summary: Qt 6 Location plugins and libraries License: GPL-3.0-or-later ++++++ qtlocation-everywhere-src-6.8.1.tar.xz -> qtlocation-everywhere-src-6.8.2.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/.cmake.conf new/qtlocation-everywhere-src-6.8.2/.cmake.conf --- old/qtlocation-everywhere-src-6.8.1/.cmake.conf 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/.cmake.conf 2025-01-24 11:03:52.000000000 +0100 @@ -1,4 +1,4 @@ -set(QT_REPO_MODULE_VERSION "6.8.1") +set(QT_REPO_MODULE_VERSION "6.8.2") set(QT_REPO_MODULE_PRERELEASE_VERSION_SEGMENT "alpha1") list(APPEND QT_EXTRA_INTERNAL_TARGET_DEFINES "QT_NO_AS_CONST=1") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/.tag new/qtlocation-everywhere-src-6.8.2/.tag --- old/qtlocation-everywhere-src-6.8.1/.tag 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/.tag 2025-01-24 11:03:52.000000000 +0100 @@ -1 +1 @@ -6883067b142b243184f27c161a499a6d39c2b328 +ea727a8a6385ce5d8b51796c33d5c812b0525eb8 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/dependencies.yaml new/qtlocation-everywhere-src-6.8.2/dependencies.yaml --- old/qtlocation-everywhere-src-6.8.1/dependencies.yaml 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/dependencies.yaml 2025-01-24 11:03:52.000000000 +0100 @@ -1,10 +1,10 @@ dependencies: ../qtbase: - ref: 0db4321f2f13c6870283f3fcc0f1a462fd7cf663 + ref: f1136de66638060b8a1ab9bc0cdf1a91dcb5ec01 required: true ../qtdeclarative: - ref: b34fca34941ecdbf99819bbf58b45332ac9e6fa7 + ref: 75534f3e7fff24ed7ccb364e2ed9950a73da879f required: true ../qtpositioning: - ref: 9a8565dc6c94e7d7a977c0c2e8d3efd49879eca0 + ref: de5ceec37e48c36ef62e16e8f2e6934c96571d63 required: true diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/declarativemaps/qdeclarativegeoserviceprovider_p.h new/qtlocation-everywhere-src-6.8.2/src/location/declarativemaps/qdeclarativegeoserviceprovider_p.h --- old/qtlocation-everywhere-src-6.8.1/src/location/declarativemaps/qdeclarativegeoserviceprovider_p.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/declarativemaps/qdeclarativegeoserviceprovider_p.h 2025-01-24 11:03:52.000000000 +0100 @@ -156,7 +156,7 @@ Q_INVOKABLE bool supportsGeocoding(const GeocodingFeatures &feature = AnyGeocodingFeatures) const; Q_INVOKABLE bool supportsMapping(const MappingFeatures &feature = AnyMappingFeatures) const; Q_INVOKABLE bool supportsPlaces(const PlacesFeatures &feature = AnyPlacesFeatures) const; - Q_REVISION(11) Q_INVOKABLE bool supportsNavigation(const NavigationFeature &feature = AnyNavigationFeatures) const; + Q_REVISION(5, 11) Q_INVOKABLE bool supportsNavigation(const NavigationFeature &feature = AnyNavigationFeatures) const; QStringList locales() const; void setLocales(const QStringList &locales); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/maps/qabstractgeotilecache.cpp new/qtlocation-everywhere-src-6.8.2/src/location/maps/qabstractgeotilecache.cpp --- old/qtlocation-everywhere-src-6.8.1/src/location/maps/qabstractgeotilecache.cpp 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/maps/qabstractgeotilecache.cpp 2025-01-24 11:03:52.000000000 +0100 @@ -11,9 +11,12 @@ #include <QMetaType> #include <QPixmap> #include <QDebug> +#include <QtCore/qtemporaryfile.h> QT_BEGIN_NAMESPACE +using namespace Qt::StringLiterals; + QAbstractGeoTileCache::QAbstractGeoTileCache(QObject *parent) : QObject(parent) { @@ -80,11 +83,16 @@ static bool writableChecked = false; if (!writableChecked) { writableChecked = true; - QDir::root().mkpath(dir); - QFile writeTestFile(QDir(dir).filePath(QStringLiteral("qt_cache_check"))); - writable = writeTestFile.open(QIODevice::WriteOnly); - if (writable) - writeTestFile.remove(); + auto mkpath = [] (const QString &dir) { + const auto rt = QDir::root(); + return rt.mkpath(dir); + }; + if (mkpath(dir)) { + QTemporaryFile tmp(QDir(dir).filePath(u"qt_cache_check.XXXXXX"_s)); + writable = tmp.open(); + } else { + writable = false; + } } if (!writable) dir = QString(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/maps/qcache3q_p.h new/qtlocation-everywhere-src-6.8.2/src/location/maps/qcache3q_p.h --- old/qtlocation-everywhere-src-6.8.1/src/location/maps/qcache3q_p.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/maps/qcache3q_p.h 2025-01-24 11:03:52.000000000 +0100 @@ -74,6 +74,7 @@ template <class Key, class T, class EvPolicy = QCache3QDefaultEvictionPolicy<Key,T> > class QCache3Q : public EvPolicy { + Q_DISABLE_COPY_MOVE(QCache3Q) private: class Queue; class Node @@ -142,11 +143,6 @@ void rebalance(); void unlink(Node *n); void link_front(Node *n, Queue *q); - -private: - // make these private so they can't be used - inline QCache3Q(const QCache3Q<Key,T,EvPolicy> &) {} - inline QCache3Q<Key,T,EvPolicy> &operator=(const QCache3Q<Key,T,EvPolicy> &) {} }; template <class Key, class T, class EvPolicy> @@ -377,14 +373,15 @@ template <class Key, class T, class EvPolicy> void QCache3Q<Key,T,EvPolicy>::remove(const Key &key, bool force) { - if (!lookup_.contains(key)) { + const auto it = std::as_const(lookup_).find(key); + if (it == lookup_.cend()) return; - } - Node *n = lookup_[key]; + + Node *n = *it; unlink(n); if (n->q != q1_evicted_ && !force) EvPolicy::aboutToBeRemoved(n->k, n->v); - lookup_.remove(key); + lookup_.erase(it); delete n; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/maps/qgeofiletilecache.cpp new/qtlocation-everywhere-src-6.8.2/src/location/maps/qgeofiletilecache.cpp --- old/qtlocation-everywhere-src-6.8.1/src/location/maps/qgeofiletilecache.cpp 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/maps/qgeofiletilecache.cpp 2025-01-24 11:03:52.000000000 +0100 @@ -14,6 +14,8 @@ QT_BEGIN_NAMESPACE +using namespace Qt::StringLiterals; + class QGeoCachedTileMemory { public: @@ -465,10 +467,16 @@ cost = bytes.size(); if (diskCache_.insert(spec, td, cost)) { + auto discardCache = qScopeGuard([this, &spec]{ + diskCache_.remove(spec); + }); QFile file(filename); - file.open(QIODevice::WriteOnly); - file.write(bytes); + if (!file.open(QIODevice::WriteOnly)) + return false; + if (file.write(bytes) != bytes.size()) + return false; file.close(); + discardCache.dismiss(); return true; } return false; @@ -531,7 +539,10 @@ if (td) { const QString format = QFileInfo(td->filename).suffix(); QFile file(td->filename); - file.open(QIODevice::ReadOnly); + if (!file.open(QIODevice::ReadOnly)) { + handleError(spec, "Cannot open file %1: %2"_L1.arg(file.fileName(), file.errorString())); + return nullptr; + } QByteArray bytes = file.readAll(); file.close(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/maps/qgeomap_p_p.h new/qtlocation-everywhere-src-6.8.2/src/location/maps/qgeomap_p_p.h --- old/qtlocation-everywhere-src-6.8.1/src/location/maps/qgeomap_p_p.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/maps/qgeomap_p_p.h 2025-01-24 11:03:52.000000000 +0100 @@ -20,9 +20,12 @@ #include <QtLocation/private/qgeoprojection_p.h> #include <QtLocation/private/qgeomap_p.h> #include <QtLocation/private/qgeocameracapabilities_p.h> + #include <QtCore/private/qobject_p.h> +#include <QtCore/qpointer.h> #include <QtCore/QSize> #include <QtCore/QList> + #include "qgeomap_p.h" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/quickmapitems/qdeclarativegeomap_p.h new/qtlocation-everywhere-src-6.8.2/src/location/quickmapitems/qdeclarativegeomap_p.h --- old/qtlocation-everywhere-src-6.8.1/src/location/quickmapitems/qdeclarativegeomap_p.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/quickmapitems/qdeclarativegeomap_p.h 2025-01-24 11:03:52.000000000 +0100 @@ -152,7 +152,7 @@ Q_INVOKABLE void pan(int dx, int dy); Q_INVOKABLE void prefetchData(); // optional hint for prefetch Q_INVOKABLE void clearData(); - Q_REVISION(13) Q_INVOKABLE void fitViewportToGeoShape(const QGeoShape &shape, QVariant margins); + Q_REVISION(5, 13) Q_INVOKABLE void fitViewportToGeoShape(const QGeoShape &shape, QVariant margins); void fitViewportToGeoShape(const QGeoShape &shape, const QMargins &borders = QMargins(10, 10, 10, 10)); QString errorString() const; @@ -186,7 +186,7 @@ void copyrightsChanged(const QString ©rightsHtml); void mapReadyChanged(bool ready); void visibleAreaChanged(); - Q_REVISION(14) void visibleRegionChanged(); + Q_REVISION(5, 14) void visibleRegionChanged(); protected: void componentComplete() override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/quickmapitems/qdeclarativegeomapitembase_p.h new/qtlocation-everywhere-src-6.8.2/src/location/quickmapitems/qdeclarativegeomapitembase_p.h --- old/qtlocation-everywhere-src-6.8.1/src/location/quickmapitems/qdeclarativegeomapitembase_p.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/quickmapitems/qdeclarativegeomapitembase_p.h 2025-01-24 11:03:52.000000000 +0100 @@ -28,6 +28,8 @@ #include <QScopedPointer> #include <QtQuickShapes/private/qquickshape_p.h> +#include <QtCore/qpointer.h> + QT_BEGIN_NAMESPACE struct Q_LOCATION_EXPORT QGeoMapViewportChangeEvent @@ -106,8 +108,8 @@ Q_SIGNALS: void mapItemOpacityChanged(); - Q_REVISION(12) void addTransitionFinished(); - Q_REVISION(12) void removeTransitionFinished(); + Q_REVISION(5, 12) void addTransitionFinished(); + Q_REVISION(5, 12) void removeTransitionFinished(); void referenceSurfaceChanged(); void lodThresholdChanged(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/location/quickmapitems/qdeclarativegeomapquickitem_p.h new/qtlocation-everywhere-src-6.8.2/src/location/quickmapitems/qdeclarativegeomapquickitem_p.h --- old/qtlocation-everywhere-src-6.8.1/src/location/quickmapitems/qdeclarativegeomapquickitem_p.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/location/quickmapitems/qdeclarativegeomapquickitem_p.h 2025-01-24 11:03:52.000000000 +0100 @@ -24,6 +24,8 @@ #include <QtLocation/private/qdeclarativegeomapitembase_p.h> #include <QtPositioning/qgeoshape.h> +#include <QtCore/qpointer.h> + QT_BEGIN_NAMESPACE class QMapQuickItemMatrix4x4 : public QQuickTransform diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/plugins/geoservices/nokia/qgeotilefetcher_nokia.h new/qtlocation-everywhere-src-6.8.2/src/plugins/geoservices/nokia/qgeotilefetcher_nokia.h --- old/qtlocation-everywhere-src-6.8.1/src/plugins/geoservices/nokia/qgeotilefetcher_nokia.h 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/plugins/geoservices/nokia/qgeotilefetcher_nokia.h 2025-01-24 11:03:52.000000000 +0100 @@ -8,6 +8,8 @@ #include <QtLocation/private/qgeotilefetcher_p.h> +#include <QtCore/qpointer.h> + QT_BEGIN_NAMESPACE class QGeoTiledMapReply; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/src/plugins/geoservices/osm/qgeotileproviderosm.cpp new/qtlocation-everywhere-src-6.8.2/src/plugins/geoservices/osm/qgeotileproviderosm.cpp --- old/qtlocation-everywhere-src-6.8.1/src/plugins/geoservices/osm/qgeotileproviderosm.cpp 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/src/plugins/geoservices/osm/qgeotileproviderosm.cpp 2025-01-24 11:03:52.000000000 +0100 @@ -196,6 +196,8 @@ p->resolveProvider(); #endif emit resolutionRequired(); + } else { + emit resolutionFinished(this); } break; } @@ -330,6 +332,7 @@ // Errors we don't expect to recover from in the near future, which // prevent accessing the redirection info but not the actual providers. m_status = Invalid; + break; default: //qWarning() << "QGeoTileProviderOsm network error:" << error; break; @@ -344,7 +347,8 @@ switch (m_status) { case Resolving: m_status = Idle; - case Idle: // should not happen + break; + case Idle: // should not happen case Invalid: // should not happen break; case Valid: // should not happen diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/tests/auto/declarative_ui/tst_map_keepgrab.qml new/qtlocation-everywhere-src-6.8.2/tests/auto/declarative_ui/tst_map_keepgrab.qml --- old/qtlocation-everywhere-src-6.8.1/tests/auto/declarative_ui/tst_map_keepgrab.qml 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/tests/auto/declarative_ui/tst_map_keepgrab.qml 2025-01-24 11:03:52.000000000 +0100 @@ -81,11 +81,15 @@ tryCompare(flickStartedSpy,"count",1) compare(flickable.flicking, true) pan() // pan map: this interrupts flicking - compare(flickStartedSpy.count, 1) // didn't start flicking again - compare(flickable.flicking, false) - tryCompare(panActiveSpy, "count", 2) - // map should change - verify(center != mapView.map.center) + + // The remaining lines of this test are commented out work that + // affects Flickable and grabbing has landed in QtQuick. + + // compare(flickStartedSpy.count, 1) // didn't start flicking again + // compare(flickable.flicking, false) + // tryCompare(panActiveSpy, "count", 2) + // // map should change + // verify(center != mapView.map.center) } } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/tests/auto/qgeojson/tst_qgeojson.cpp new/qtlocation-everywhere-src-6.8.2/tests/auto/qgeojson/tst_qgeojson.cpp --- old/qtlocation-everywhere-src-6.8.1/tests/auto/qgeojson/tst_qgeojson.cpp 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/tests/auto/qgeojson/tst_qgeojson.cpp 2025-01-24 11:03:52.000000000 +0100 @@ -48,7 +48,7 @@ modelList.clear(); QFile file(testDataDir + QStringLiteral("/") + exampleGeometries[i]); - file.open(QFile::ReadOnly); + QVERIFY2(file.open(QFile::ReadOnly), qPrintable(file.errorString())); QByteArray testJson = file.readAll(); originalDocument = QJsonDocument::fromJson(testJson); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/qtlocation-everywhere-src-6.8.1/tests/baseline/mapitems/tst_baseline_mapitems.cpp new/qtlocation-everywhere-src-6.8.2/tests/baseline/mapitems/tst_baseline_mapitems.cpp --- old/qtlocation-everywhere-src-6.8.1/tests/baseline/mapitems/tst_baseline_mapitems.cpp 2024-11-21 05:05:15.000000000 +0100 +++ new/qtlocation-everywhere-src-6.8.2/tests/baseline/mapitems/tst_baseline_mapitems.cpp 2025-01-24 11:03:52.000000000 +0100 @@ -34,6 +34,7 @@ void initTestCase(); void init(); void cleanup(); + void cleanupTestCase(); void mapItems_data() { setupTestSuite(); } void mapItems() { runTest(); } @@ -145,6 +146,11 @@ QTest::qWait(20); } +void tst_Baseline_MapItems::cleanupTestCase() +{ + QBaselineTest::finalizeAndDisconnect(); +} + void tst_Baseline_MapItems::setupTestSuite() { QTest::addColumn<QString>("qmlFile"); @@ -225,14 +231,6 @@ return true; } -#define main _realmain -QTEST_MAIN(tst_Baseline_MapItems) -#undef main - -int main(int argc, char *argv[]) -{ - QBaselineTest::handleCmdLineArgs(&argc, &argv); - return _realmain(argc, argv); -} +QBASELINETEST_MAIN(tst_Baseline_MapItems) #include "tst_baseline_mapitems.moc"