Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package aws-c-common for openSUSE:Factory checked in at 2025-02-06 22:05:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/aws-c-common (Old) and /work/SRC/openSUSE:Factory/.aws-c-common.new.2316 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "aws-c-common" Thu Feb 6 22:05:25 2025 rev:20 rq:1243452 version:0.11.0 Changes: -------- --- /work/SRC/openSUSE:Factory/aws-c-common/aws-c-common.changes 2025-01-29 16:18:51.620574988 +0100 +++ /work/SRC/openSUSE:Factory/.aws-c-common.new.2316/aws-c-common.changes 2025-02-06 22:06:58.065930438 +0100 @@ -1,0 +2,9 @@ +Thu Jan 30 11:31:28 UTC 2025 - John Paul Adrian Glaubitz <adrian.glaub...@suse.com> + +- Update to version 0.11.0 + * A bunch of CMake fixes by @graebm in (#1178) +- from version 0.10.9 + * Fix heap overflow on uri parsing by @TingDaoK in (#1185) +- Remove workaround to move cmake files to correct installation path + +------------------------------------------------------------------- Old: ---- v0.10.8.tar.gz New: ---- v0.11.0.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ aws-c-common.spec ++++++ --- /var/tmp/diff_new_pack.Y8gD52/_old 2025-02-06 22:06:58.621953350 +0100 +++ /var/tmp/diff_new_pack.Y8gD52/_new 2025-02-06 22:06:58.625953515 +0100 @@ -19,7 +19,7 @@ %define library_version 1.0.0 %define library_soversion 1 Name: aws-c-common -Version: 0.10.8 +Version: 0.11.0 Release: 0 Summary: Core C99 package for AWS SDK for C License: Apache-2.0 @@ -73,12 +73,6 @@ %install %cmake_install -# Move cmake files to correct installation path -mkdir -p %{buildroot}%{_libdir}/cmake/aws-c-common -mv %{buildroot}%{_libdir}/aws-c-common/cmake/* %{buildroot}%{_libdir}/cmake/aws-c-common/ -mv %{buildroot}%{_libdir}/cmake/Aws* %{buildroot}%{_libdir}/cmake/aws-c-common/ -rm -rf %{buildroot}%{_libdir}/aws-c-common - %ldconfig_scriptlets -n lib%{name}%{library_soversion} %files -n lib%{name}%{library_soversion} ++++++ v0.10.8.tar.gz -> v0.11.0.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/AWSCRTAndroidTestRunner/app/src/main/cpp/CMakeLists.txt new/aws-c-common-0.11.0/AWSCRTAndroidTestRunner/app/src/main/cpp/CMakeLists.txt --- old/aws-c-common-0.10.8/AWSCRTAndroidTestRunner/app/src/main/cpp/CMakeLists.txt 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/AWSCRTAndroidTestRunner/app/src/main/cpp/CMakeLists.txt 2025-01-29 00:09:51.000000000 +0100 @@ -3,7 +3,7 @@ # Sets the minimum version of CMake required to build the native library. -cmake_minimum_required(VERSION 3.9) +cmake_minimum_required(VERSION 3.9...3.31) # AWS lib set(path_to_common "${CMAKE_CURRENT_LIST_DIR}/../../../../..") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/CMakeLists.txt new/aws-c-common-0.11.0/CMakeLists.txt --- old/aws-c-common-0.10.8/CMakeLists.txt 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/CMakeLists.txt 2025-01-29 00:09:51.000000000 +0100 @@ -3,17 +3,13 @@ # As of October 2024, we picked 3.9 as our version because internally we still support RHEL5 and AL2012, and CMake 3.9 # was the latest version available on those platforms. -cmake_minimum_required(VERSION 3.9) +cmake_minimum_required(VERSION 3.9...3.31) option(ALLOW_CROSS_COMPILED_TESTS "Allow tests to be compiled via cross compile, for use with qemu" OFF) project(aws-c-common LANGUAGES C VERSION 0.1.0) message(STATUS "CMake ${CMAKE_VERSION}") -if (POLICY CMP0077) - cmake_policy(SET CMP0077 OLD) # Enable options to get their values from normal variables -endif() - list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") include(AwsCFlags) include(AwsCheckHeaders) @@ -23,6 +19,7 @@ include(AwsThreadAffinity) include(AwsThreadName) include(CTest) +include(GNUInstallDirs) set(GENERATED_ROOT_DIR "${CMAKE_CURRENT_BINARY_DIR}/generated") set(GENERATED_INCLUDE_DIR "${GENERATED_ROOT_DIR}/include") @@ -247,7 +244,7 @@ unset(HEADER_DSTDIR) - foreach(POTENTIAL_PREFIX IN ITEMS ${GENERATED_ROOT_DIR} ${CMAKE_CURRENT_SOURCE_DIR}) + foreach(POTENTIAL_PREFIX IN ITEMS "${GENERATED_INCLUDE_DIR}" "${CMAKE_CURRENT_SOURCE_DIR}/include") string(LENGTH ${POTENTIAL_PREFIX} _prefixlen) string(SUBSTRING ${HEADER_DIR} 0 ${_prefixlen} _actual_prefix) if(${_actual_prefix} STREQUAL ${POTENTIAL_PREFIX}) @@ -261,7 +258,7 @@ endif() install(FILES ${HEADER_SRCPATH} - DESTINATION ${HEADER_DSTDIR} + DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${HEADER_DSTDIR}" COMPONENT Development) endforeach() @@ -278,12 +275,12 @@ endif() install(EXPORT "${PROJECT_NAME}-targets" - DESTINATION "${LIBRARY_DIRECTORY}/${PROJECT_NAME}/cmake/${TARGET_DIR}" + DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}/${TARGET_DIR}" NAMESPACE AWS:: COMPONENT Development) install(FILES "${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}-config.cmake" - DESTINATION "${LIBRARY_DIRECTORY}/${PROJECT_NAME}/cmake" + DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}" COMPONENT Development) list(APPEND EXPORT_MODULES @@ -300,7 +297,7 @@ ) install(FILES ${EXPORT_MODULES} - DESTINATION "${LIBRARY_DIRECTORY}/cmake" + DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}/modules" COMPONENT Development) # This should come last, to ensure all variables defined by cmake will be available for export diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/bin/system_info/CMakeLists.txt new/aws-c-common-0.11.0/bin/system_info/CMakeLists.txt --- old/aws-c-common-0.10.8/bin/system_info/CMakeLists.txt 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/bin/system_info/CMakeLists.txt 2025-01-29 00:09:51.000000000 +0100 @@ -1,7 +1,5 @@ project(print-sys-info C) -list(APPEND CMAKE_MODULE_PATH "${CMAKE_INSTALL_PREFIX}/lib/cmake") - file(GLOB SI_SRC "*.c" ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/cmake/AwsSharedLibSetup.cmake new/aws-c-common-0.11.0/cmake/AwsSharedLibSetup.cmake --- old/aws-c-common-0.10.8/cmake/AwsSharedLibSetup.cmake 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/cmake/AwsSharedLibSetup.cmake 2025-01-29 00:09:51.000000000 +0100 @@ -1,46 +1,32 @@ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. # SPDX-License-Identifier: Apache-2.0. -set(LIBRARY_DIRECTORY lib) -set(RUNTIME_DIRECTORY bin) -# Set the default lib installation path on GNU systems with GNUInstallDirs -if (UNIX AND NOT APPLE) - include(GNUInstallDirs) - set(LIBRARY_DIRECTORY ${CMAKE_INSTALL_LIBDIR}) - set(RUNTIME_DIRECTORY ${CMAKE_INSTALL_BINDIR}) - - # this is the absolute dumbest thing in the world, but find_package won't work without it - # also I verified this is correctly NOT "lib64" when CMAKE_C_FLAGS includes "-m32" - if (${LIBRARY_DIRECTORY} STREQUAL "lib64") - set(FIND_LIBRARY_USE_LIB64_PATHS true) - endif() -endif() - +include(GNUInstallDirs) function(aws_prepare_shared_lib_exports target) if (BUILD_SHARED_LIBS) install(TARGETS ${target} EXPORT ${target}-targets ARCHIVE - DESTINATION ${LIBRARY_DIRECTORY} + DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT Development LIBRARY - DESTINATION ${LIBRARY_DIRECTORY} + DESTINATION ${CMAKE_INSTALL_LIBDIR} NAMELINK_SKIP COMPONENT Runtime RUNTIME - DESTINATION ${RUNTIME_DIRECTORY} + DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT Runtime) install(TARGETS ${target} EXPORT ${target}-targets LIBRARY - DESTINATION ${LIBRARY_DIRECTORY} + DESTINATION ${CMAKE_INSTALL_LIBDIR} NAMELINK_ONLY COMPONENT Development) else() install(TARGETS ${target} EXPORT ${target}-targets - ARCHIVE DESTINATION ${LIBRARY_DIRECTORY} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT Development) endif() endfunction() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/cmake/CPackConfig.cmake new/aws-c-common-0.11.0/cmake/CPackConfig.cmake --- old/aws-c-common-0.10.8/cmake/CPackConfig.cmake 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/cmake/CPackConfig.cmake 2025-01-29 00:09:51.000000000 +0100 @@ -62,7 +62,7 @@ # By default, we'll try to claim the cmake directory under the library directory # and the aws include directory. We have to share both of these set(CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION - /usr/${LIBRARY_DIRECTORY}/cmake + /usr/${CMAKE_INSTALL_LIBDIR}/cmake /usr/include/aws) # Include CPack, which generates the package target diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/cmake/aws-c-common-config.cmake new/aws-c-common-0.11.0/cmake/aws-c-common-config.cmake --- old/aws-c-common-0.10.8/cmake/aws-c-common-config.cmake 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/cmake/aws-c-common-config.cmake 2025-01-29 00:09:51.000000000 +0100 @@ -1,3 +1,6 @@ +# make installed modules (e.g. AwsCFlags.cmake) available to dependencies +list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/modules) + set(THREADS_PREFER_PTHREAD_FLAG ON) if(WIN32 OR UNIX OR APPLE) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/source/uri.c new/aws-c-common-0.11.0/source/uri.c --- old/aws-c-common-0.10.8/source/uri.c 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/source/uri.c 2025-01-29 00:09:51.000000000 +0100 @@ -282,8 +282,9 @@ return; } - /* make sure we didn't just pick up the port by mistake */ - if ((size_t)(location_of_colon - str->ptr) < str->len && *(location_of_colon + 1) != '/') { + /* Ensure location_of_colon is not the last character before checking *(location_of_colon + 1) */ + if ((size_t)(location_of_colon - str->ptr) + 1 >= str->len || *(location_of_colon + 1) != '/') { + /* make sure we didn't just pick up the port by mistake */ parser->state = ON_AUTHORITY; return; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/tests/CMakeLists.txt new/aws-c-common-0.11.0/tests/CMakeLists.txt --- old/aws-c-common-0.10.8/tests/CMakeLists.txt 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/tests/CMakeLists.txt 2025-01-29 00:09:51.000000000 +0100 @@ -513,6 +513,7 @@ add_test_case(uri_invalid_scheme_parse) add_test_case(uri_invalid_port_parse) add_test_case(uri_port_too_large_parse) +add_test_case(uri_single_colon_parse) add_test_case(uri_builder) add_test_case(uri_builder_from_string) add_test_case(test_uri_encode_path_rfc3986) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.10.8/tests/uri_test.c new/aws-c-common-0.11.0/tests/uri_test.c --- old/aws-c-common-0.10.8/tests/uri_test.c 2025-01-24 20:01:58.000000000 +0100 +++ new/aws-c-common-0.11.0/tests/uri_test.c 2025-01-29 00:09:51.000000000 +0100 @@ -593,6 +593,18 @@ AWS_TEST_CASE(uri_port_too_large_parse, s_test_uri_port_too_large_parse); +static int s_test_uri_single_colon_parse(struct aws_allocator *allocator, void *ctx) { + (void)ctx; + const char *str_uri = ":"; + struct aws_byte_cursor uri_csr = aws_byte_cursor_from_array(str_uri, 1); + struct aws_uri uri; + ASSERT_SUCCESS(aws_uri_init_parse(&uri, allocator, &uri_csr)); + aws_uri_clean_up(&uri); + return AWS_OP_SUCCESS; +} + +AWS_TEST_CASE(uri_single_colon_parse, s_test_uri_single_colon_parse); + static int s_test_uri_builder(struct aws_allocator *allocator, void *ctx) { (void)ctx; const char *str_uri =