Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-network for openSUSE:Factory
checked in at 2021-04-14 10:09:34
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-network (Old)
and /work/SRC/openSUSE:Factory/.yast2-network.new.2401 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network"
Wed Apr 14 10:09:34 2021 rev:449 rq:885057 version:4.4.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes
2021-04-10 15:26:24.482310043 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-network.new.2401/yast2-network.changes
2021-04-14 10:09:37.749356926 +0200
@@ -1,0 +2,7 @@
+Tue Apr 13 12:32:16 UTC 2021 - Knut Anderssen <kanders...@suse.com>
+
+- Do not crash when checking if an interface is a hotplug one and
+ it is not present (bsc#1184623)
+- 4.4.3
+
+-------------------------------------------------------------------
Old:
----
yast2-network-4.4.2.tar.bz2
New:
----
yast2-network-4.4.3.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-network.spec ++++++
--- /var/tmp/diff_new_pack.FaZEOw/_old 2021-04-14 10:09:38.389358007 +0200
+++ /var/tmp/diff_new_pack.FaZEOw/_new 2021-04-14 10:09:38.393358013 +0200
@@ -17,7 +17,7 @@
Name: yast2-network
-Version: 4.4.2
+Version: 4.4.3
Release: 0
Summary: YaST2 - Network Configuration
License: GPL-2.0-only
++++++ yast2-network-4.4.2.tar.bz2 -> yast2-network-4.4.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.4.2/.coveralls.yml
new/yast2-network-4.4.3/.coveralls.yml
--- old/yast2-network-4.4.2/.coveralls.yml 2021-04-10 10:37:01.000000000
+0200
+++ new/yast2-network-4.4.3/.coveralls.yml 1970-01-01 01:00:00.000000000
+0100
@@ -1 +0,0 @@
-service_name: travis-ci
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.4.2/package/yast2-network.changes
new/yast2-network-4.4.3/package/yast2-network.changes
--- old/yast2-network-4.4.2/package/yast2-network.changes 2021-04-10
10:37:01.000000000 +0200
+++ new/yast2-network-4.4.3/package/yast2-network.changes 2021-04-13
15:07:47.000000000 +0200
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Tue Apr 13 12:32:16 UTC 2021 - Knut Anderssen <kanders...@suse.com>
+
+- Do not crash when checking if an interface is a hotplug one and
+ it is not present (bsc#1184623)
+- 4.4.3
+
+-------------------------------------------------------------------
Fri Apr 9 11:22:42 UTC 2021 - Knut Anderssen <kanders...@suse.com>
- bsc#1181956
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.4.2/package/yast2-network.spec
new/yast2-network-4.4.3/package/yast2-network.spec
--- old/yast2-network-4.4.2/package/yast2-network.spec 2021-04-10
10:37:01.000000000 +0200
+++ new/yast2-network-4.4.3/package/yast2-network.spec 2021-04-13
15:07:47.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-network
-Version: 4.4.2
+Version: 4.4.3
Release: 0
Summary: YaST2 - Network Configuration
License: GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.4.2/src/include/network/lan/address.rb
new/yast2-network-4.4.3/src/include/network/lan/address.rb
--- old/yast2-network-4.4.2/src/include/network/lan/address.rb 2021-04-10
10:37:01.000000000 +0200
+++ new/yast2-network-4.4.3/src/include/network/lan/address.rb 2021-04-13
15:07:47.000000000 +0200
@@ -57,31 +57,31 @@
def AddressDialog(builder:)
ret = Y2Network::Dialogs::EditInterface.run(builder)
- if ret != :back && ret != :abort
- if builder.boot_protocol.dhcp? && !builder.interface.hotplug?
- # fixed bug #73739 - if dhcp is used, dont set default gw statically
- # but also: reset default gw only if DHCP* is used, this branch
covers
- # "No IP address" case, then default gw must stay (#460262)
- # and also: don't delete default GW for usb/pcmcia devices (#307102)
- #
- # Is check for hotplug really needed? It contained a typo up to
SLE-15-SP4 and
- # nobody complained - something to think of during next refactoring.
- yast_config = Y2Network::Config.find(:yast)
- if yast_config&.routing&.default_route
- remove_gw = Popup.YesNo(
- _(
- "A static default route is defined.\n" \
- "It is suggested to remove the static default route definition
\n" \
- "if one can be obtained also via DHCP.\n" \
- "Do you want to remove the static default route?"
- )
- )
- yast_config.routing.remove_default_routes if remove_gw
- end
- end
+ log.info "AddressDialog res: #{ret.inspect}"
+
+ return ret if [:back, :abort].include?(ret)
+ return ret if builder.interface&.hotplug? || !builder.boot_protocol.dhcp?
+
+ # fixed bug #73739 - if dhcp is used, dont set default gw statically
+ # but also: reset default gw only if DHCP* is used, this branch covers
+ # "No IP address" case, then default gw must stay (#460262)
+ # and also: don't delete default GW for usb/pcmcia devices (#307102)
+ #
+ # Is check for hotplug really needed? It contained a typo up to
SLE-15-SP4 and
+ # nobody complained - something to think of during next refactoring.
+ yast_config = Y2Network::Config.find(:yast)
+ if yast_config&.routing&.default_route
+ remove_gw = Popup.YesNo(
+ _(
+ "A static default route is defined.\n" \
+ "It is suggested to remove the static default route definition \n"
\
+ "if one can be obtained also via DHCP.\n" \
+ "Do you want to remove the static default route?"
+ )
+ )
+ yast_config.routing.remove_default_routes if remove_gw
end
- log.info "AddressDialog res: #{ret.inspect}"
ret
end
end
