Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package roast for openSUSE:Factory checked in at 2025-06-26 11:39:35 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/roast (Old) and /work/SRC/openSUSE:Factory/.roast.new.7067 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "roast" Thu Jun 26 11:39:35 2025 rev:13 rq:1288559 version:10.0.1 Changes: -------- --- /work/SRC/openSUSE:Factory/roast/roast.changes 2025-06-23 15:03:57.486442782 +0200 +++ /work/SRC/openSUSE:Factory/.roast.new.7067/roast.changes 2025-06-26 11:40:47.361432470 +0200 @@ -1,0 +2,17 @@ +Wed Jun 25 13:50:51 UTC 2025 - Soc Virnyl Estela <uncomfyhaloma...@opensuse.org> + +- Update to version 10.0.1: + * chore(release): v10.0.1 + * fix: `start_trace` should be passed + * chore(release): v10.0.0 + * tests: add missing flag `--silent` + * misc: allow `clippy::if_same_then_else`. + * Merge branch '20250625-provide-silent-flag' + * refactor: path_buf_filename -> filename + * fix: the renaming logic have caused the `outdir` to be useless. + * docs: update README.md + * feat: if compiled with feature `obs`, make `--silent` flag do nothing. + * feat: add silent flag + * docs: add a section about reproducibility + +------------------------------------------------------------------- Old: ---- roast-9.0.0.tar.zst New: ---- roast-10.0.1.tar.zst ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ roast.spec ++++++ --- /var/tmp/diff_new_pack.4NpCSa/_old 2025-06-26 11:40:48.433476501 +0200 +++ /var/tmp/diff_new_pack.4NpCSa/_new 2025-06-26 11:40:48.437476665 +0200 @@ -17,7 +17,7 @@ Name: roast -Version: 9.0.0 +Version: 10.0.1 Release: 0 Summary: Simpler tar archiver and extractor License: MPL-2.0 ++++++ roast-9.0.0.tar.zst -> roast-10.0.1.tar.zst ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/CHANGELOG.md new/roast-10.0.1/CHANGELOG.md --- old/roast-9.0.0/CHANGELOG.md 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/CHANGELOG.md 1970-01-01 01:00:00.000000000 +0100 @@ -2,6 +2,41 @@ All notable changes to this project will be documented in this file. +## [10.0.1] - 2025-06-25 + +### Bug Fixes + +- `start_trace` should be passed [a267574](https://codeberg.org/Rusty-Geckos/roast/commit/a2675743abb34f0c4c4d3fcbb64686cf0de40ee2) + +## [10.0.0] - 2025-06-25 + +### Bug Fixes + +- The renaming logic have caused the `outdir` to be useless. [23673dc](https://codeberg.org/Rusty-Geckos/roast/commit/23673dc940a83de23d95dc065db88e5ef09892b3) + +### Documentation + +- Update README.md [7337011](https://codeberg.org/Rusty-Geckos/roast/commit/7337011b7600263255550f95184bfee4eb895348) +- Add a section about reproducibility [91355df](https://codeberg.org/Rusty-Geckos/roast/commit/91355dfed43cbcfc6712cb162a4622481c29306d) + +### Features + +- If compiled with feature `obs`, make `--silent` flag do nothing. [704993f](https://codeberg.org/Rusty-Geckos/roast/commit/704993fcb8ba22d7012b4fe9108d01336094a989) +- Add silent flag [fbe8d61](https://codeberg.org/Rusty-Geckos/roast/commit/fbe8d61f205e24589a46469dd9262cb1e8c45712) + +### Miscellaneous Tasks + +- V10.0.0 [ba46b2d](https://codeberg.org/Rusty-Geckos/roast/commit/ba46b2dc0703e1ba17b2b723bb71b3bc3b042eb5) +- Allow `clippy::if_same_then_else`. [11940e1](https://codeberg.org/Rusty-Geckos/roast/commit/11940e1012ebe77055da00363479bc8dd3b6be06) + +### Refactor + +- Path_buf_filename -> filename [278836f](https://codeberg.org/Rusty-Geckos/roast/commit/278836fdfceeb9c6cc6be1242722828681121de1) + +### Testing + +- Add missing flag `--silent` [efad22a](https://codeberg.org/Rusty-Geckos/roast/commit/efad22a0d6f36068655202633a8463ff14331fbb) + ## [9.0.0] - 2025-06-22 ### Bug Fixes @@ -19,6 +54,10 @@ - Create a new binary name for `roast_scm`. [65e9dcf](https://codeberg.org/Rusty-Geckos/roast/commit/65e9dcf00d246af4ff7d376eaa5df9cfd6e106d6) - Add new subcommand `generate-completions-for` using `clap_complete` [f6ab16b](https://codeberg.org/Rusty-Geckos/roast/commit/f6ab16b675fe9d0dc141a71678531d27d9fcfd42) +### Miscellaneous Tasks + +- V9.0.0 [c3d248b](https://codeberg.org/Rusty-Geckos/roast/commit/c3d248b3f90c9ef556bdb9bef4722ec021082725) + ### Other - Update workspace default members [047dfe3](https://codeberg.org/Rusty-Geckos/roast/commit/047dfe353a2978cb3904d4ac2272264927d6922d) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/Cargo.lock new/roast-10.0.1/Cargo.lock --- old/roast-9.0.0/Cargo.lock 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/Cargo.lock 1970-01-01 01:00:00.000000000 +0100 @@ -114,9 +114,9 @@ [[package]] name = "bumpalo" -version = "3.18.1" +version = "3.19.0" source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "793db76d6187cd04dff33004d8e6c9cc4e05cd330500379d2394209271b4aeee" +checksum = "46c5e41b57b8bba42a04676d81cb89e9ee8e859a1a66f80a5a72e1cb76b34d43" [[package]] name = "byteorder" @@ -701,7 +701,7 @@ [[package]] name = "libroast" -version = "9.0.0" +version = "10.0.1" dependencies = [ "bzip2", "clap", @@ -1065,7 +1065,7 @@ [[package]] name = "roast-cli" -version = "9.0.0" +version = "10.0.1" dependencies = [ "clap", "libroast", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/Cargo.toml new/roast-10.0.1/Cargo.toml --- old/roast-9.0.0/Cargo.toml 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/Cargo.toml 1970-01-01 01:00:00.000000000 +0100 @@ -1,6 +1,6 @@ [workspace.package] authors = ["Soc Virnyl Estela"] -version = "9.0.0" +version = "10.0.1" edition = "2024" license = "MPL-2.0" repository = "https://codeberg.org/Rusty-Geckos/roast"; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/README.md new/roast-10.0.1/README.md --- old/roast-9.0.0/README.md 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/README.md 1970-01-01 01:00:00.000000000 +0100 @@ -249,14 +249,31 @@ > [!NOTE] > The behaviours might differ in `roast_scm.service` if roast was compiled > with `obs` feature. This additional feature flag -> will update the version from a target specfile. +> will update the version from a target specfile and makes the `--silent` flag do nothing, regardless of what value is passed. +> Since the `--silent` flag does nothing, the flag is not documented in the service files. +> All of the service files are assumed to have the executables to be compiled with `obs` flag. + +Most of the flags in the service files maps with the output of following commands -It maps when you run the following commands - `raw -h` - `recomprizz -h` - `roast -h` - `roast_scm -h` +# Reproducibility + +This project does not and will not support reproducible builds as a feature. If +you submit a PR to enable those features, we may accept it but we will not +maintain or guarantee that it will continue to work in the future. + +> [!NOTE] +> Although, reproducible or deterministic tarballs are fine to reduce checks, +> the idea of reproducibility for security is something the authors +> of this project don't believe in e.g. the Jia Tan incident can't be +> caught with reproducible builds. Although, the tainted sources can be identified using +> reproducible / deterministic generation of the tarballs, those tainted sources +> are **only known AFTER a successful malicious attempt**. + [github]: https://github.com/openSUSE-Rust/roast [sourcehut]: https://git.sr.ht/~uncomfy/roast [codeberg]: https://codeberg.org/Rusty-Geckos/roast diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/src/operations/cli.rs new/roast-10.0.1/libroast/src/operations/cli.rs --- old/roast-9.0.0/libroast/src/operations/cli.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/src/operations/cli.rs 1970-01-01 01:00:00.000000000 +0100 @@ -125,6 +125,8 @@ action = clap::ArgAction::Set )] pub ignore_hidden: bool, + #[arg(long, short = 'S', help = "Whether to silence the output or not.", default_value_t = true, action = clap::ArgAction::Set)] + pub silent: bool, #[command(subcommand)] pub subcommands: Option<Subcommands>, } @@ -151,6 +153,8 @@ pub target: Option<PathBuf>, #[arg(long, short = 'd', help = "Output directory of extracted archive.")] pub outdir: Option<PathBuf>, + #[arg(long, short = 'S', help = "Whether to silence the output or not.", default_value_t = true, action = clap::ArgAction::Set)] + pub silent: bool, #[command(subcommand)] pub subcommands: Option<Subcommands>, } @@ -245,6 +249,8 @@ action = clap::ArgAction::Set )] pub ignore_hidden: bool, + #[arg(long, short = 'S', help = "Whether to silence the output or not.", default_value_t = true, action = clap::ArgAction::Set)] + pub silent: bool, #[command(subcommand)] pub subcommands: Option<Subcommands>, } @@ -369,6 +375,8 @@ pub ignore_hidden: bool, #[arg(long, short = 'c', help = "Compression to use.", default_value_t)] pub compression: Compression, + #[arg(long, short = 'S', help = "Whether to silence the output or not.", default_value_t = true, action = clap::ArgAction::Set)] + pub silent: bool, #[command(subcommand)] pub subcommands: Option<Subcommands>, } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/src/operations/raw.rs new/roast-10.0.1/libroast/src/operations/raw.rs --- old/roast-9.0.0/libroast/src/operations/raw.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/src/operations/raw.rs 1970-01-01 01:00:00.000000000 +0100 @@ -48,11 +48,17 @@ } else { - if start_trace + if cfg!(feature = "obs") + { + if start_trace + { + start_tracing(); + } + } + else if !raw_args.silent && start_trace { start_tracing(); } - info!("🥩 Starting Raw."); debug!(?raw_args); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/src/operations/recomprizz.rs new/roast-10.0.1/libroast/src/operations/recomprizz.rs --- old/roast-9.0.0/libroast/src/operations/recomprizz.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/src/operations/recomprizz.rs 1970-01-01 01:00:00.000000000 +0100 @@ -60,8 +60,15 @@ } else { - let start_trace = false; - start_tracing(); + #[allow(clippy::if_same_then_else)] // It's not actually the same + if cfg!(feature = "obs") + { + start_tracing(); + } + else if !recomprizz_args.silent + { + start_tracing(); + } info!("📤 Starting Recomprizz."); debug!(?recomprizz_args); let tmp_binding_for_raw = tempfile::Builder::new() @@ -83,10 +90,11 @@ let raw_args = RawArgs { target: Some(target.clone()), outdir: Some(outpath_for_raw.to_path_buf()), + silent: recomprizz_args.silent, subcommands: None, }; - raw_opts(raw_args, start_trace)?; + raw_opts(raw_args, false)?; let file_extension = recomprizz_args.compression.to_extension(); @@ -121,8 +129,8 @@ { crate::common::SupportedFormat::Compressed(compression, path_buf) => { - let path_buf_filename = path_buf.to_string_lossy(); - match path_buf_filename.rsplit_once(&compression.to_extension()) + let filename = path_buf.file_name().unwrap_or_default().to_string_lossy(); + match filename.rsplit_once(&compression.to_extension()) { Some((name, _)) => name.to_string(), None => @@ -136,7 +144,7 @@ "Not removing old file extension. This will result to an \ undesirable rename of the file." ); - path_buf_filename.to_string() + filename.to_string() } } } @@ -161,10 +169,11 @@ ignore_git: recomprizz_args.ignore_git, ignore_hidden: recomprizz_args.ignore_hidden, include: recomprizz_args.include, + silent: recomprizz_args.silent, subcommands: None, }; - roast_opts(&roast_args, start_trace)?; + roast_opts(&roast_args, false)?; info!("📥 Finished Recomprizz."); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/src/operations/roast/mod.rs new/roast-10.0.1/libroast/src/operations/roast/mod.rs --- old/roast-9.0.0/libroast/src/operations/roast/mod.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/src/operations/roast/mod.rs 1970-01-01 01:00:00.000000000 +0100 @@ -270,7 +270,14 @@ } else { - if start_trace + if cfg!(feature = "obs") + { + if start_trace + { + start_tracing(); + } + } + else if !roast_args.silent && start_trace { start_tracing(); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/src/operations/roast_scm/mod.rs new/roast-10.0.1/libroast/src/operations/roast_scm/mod.rs --- old/roast-9.0.0/libroast/src/operations/roast_scm/mod.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/src/operations/roast_scm/mod.rs 1970-01-01 01:00:00.000000000 +0100 @@ -1079,7 +1079,15 @@ } else { - if start_trace + #[allow(clippy::if_same_then_else)] // It's not actually the same + if cfg!(feature = "obs") + { + if start_trace + { + start_tracing(); + } + } + else if !roast_scm_args.silent && start_trace { start_tracing(); } @@ -1179,6 +1187,7 @@ reproducible: roast_scm_args.reproducible, ignore_git: roast_scm_args.ignore_git, ignore_hidden: roast_scm_args.ignore_hidden, + silent: roast_scm_args.silent, subcommands: None, }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/tests/obs_scm.rs new/roast-10.0.1/libroast/tests/obs_scm.rs --- old/roast-9.0.0/libroast/tests/obs_scm.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/tests/obs_scm.rs 1970-01-01 01:00:00.000000000 +0100 @@ -48,6 +48,7 @@ std::env::set_current_dir(&outdir)?; fs::copy(&specfile_path, &outdir.join("obs-service-cargo.spec"))?; let r1 = RoastScmArgs { + silent: false, subcommands: None, changesgenerate: true, changesauthor: Some("Soc Virnyl Estela".to_string()), @@ -77,6 +78,7 @@ let buf1 = read(outdir.join("r1.tar.zst"))?; hasher1.update(buf1); let r2 = RoastScmArgs { + silent: false, subcommands: None, changesgenerate: false, changesauthor: None, @@ -133,6 +135,7 @@ fs::copy(&specfile_path, &outdir2.join("obs-service-cargo.spec"))?; std::env::set_current_dir(&outdir1)?; let r1 = RoastScmArgs { + silent: false, subcommands: None, changesgenerate: false, changesauthor: None, @@ -157,6 +160,7 @@ libroast::operations::roast_scm::roast_scm_opts(None, &r1, false)?; std::env::set_current_dir(&outdir2)?; let r2 = RoastScmArgs { + silent: false, subcommands: None, changesgenerate: false, changesauthor: None, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/libroast/tests/scm.rs new/roast-10.0.1/libroast/tests/scm.rs --- old/roast-9.0.0/libroast/tests/scm.rs 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/libroast/tests/scm.rs 1970-01-01 01:00:00.000000000 +0100 @@ -55,12 +55,14 @@ reproducible: true, ignore_git: true, ignore_hidden: false, + silent: false, compression: libroast::common::Compression::default(), }; libroast::operations::roast_scm::roast_scm_opts(None, &r1, false)?; let buf1 = read(outdir.join("r1.tar.zst"))?; hasher1.update(buf1); let r2 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, @@ -105,6 +107,7 @@ let outdir1 = tmp_binding1.path(); let outdir2 = tmp_binding2.path(); let r1 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, @@ -128,6 +131,7 @@ }; libroast::operations::roast_scm::roast_scm_opts(None, &r1, false)?; let r2 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, @@ -187,6 +191,7 @@ let outdir1 = tmp_binding1.path(); let outdir2 = tmp_binding2.path(); let r1 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, @@ -210,6 +215,7 @@ }; libroast::operations::roast_scm::roast_scm_opts(None, &r1, false)?; let r2 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, @@ -269,6 +275,7 @@ let outdir1 = tmp_binding1.path(); let outdir2 = tmp_binding2.path(); let r1 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, @@ -292,6 +299,7 @@ }; libroast::operations::roast_scm::roast_scm_opts(None, &r1, false)?; let r2 = RoastScmArgs { + silent: false, subcommands: None, set_version: None, set_name: None, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/roast-9.0.0/roast-cli/Cargo.toml new/roast-10.0.1/roast-cli/Cargo.toml --- old/roast-9.0.0/roast-cli/Cargo.toml 1970-01-01 01:00:00.000000000 +0100 +++ new/roast-10.0.1/roast-cli/Cargo.toml 1970-01-01 01:00:00.000000000 +0100 @@ -17,7 +17,7 @@ ] } tracing-subscriber = { version = "0.3", features = ["env-filter"] } tempfile = "3.12.0" -libroast = { version = "9", path = "../libroast" } +libroast = { version = "10", path = "../libroast" } [features] obs = ["libroast/obs"] ++++++ vendor.tar.zst ++++++ /work/SRC/openSUSE:Factory/roast/vendor.tar.zst /work/SRC/openSUSE:Factory/.roast.new.7067/vendor.tar.zst differ: char 7, line 1
