Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2025-06-26 14:05:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.7067 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Thu Jun 26 14:05:43 2025 rev:276 rq:1288609 version:5.0.0 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2025-05-26 18:31:46.577947434 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.7067/virt-manager.changes 2025-06-26 14:06:29.540795283 +0200 @@ -1,0 +2,15 @@ +Wed Jun 18 14:06:18 MDT 2025 - carn...@suse.com + +- bsc#1244685 - Could not find an installable distribution with + virt-install command + virtinst-add-sle16-detection-support.patch + +------------------------------------------------------------------- +Thu Jun 12 15:51:44 MDT 2025 - carn...@suse.com + +- Upstream bug fixes (bsc#1027942) + 050-Validation-allow-spaces-disallow-slashes.patch + 051-fix-default-start_folder-to-None.patch + 052-Add-Ctrl+Alt+Shift+Esc-key-command-for-loginds-SecureAttentionKey.patch + +------------------------------------------------------------------- New: ---- 050-Validation-allow-spaces-disallow-slashes.patch 051-fix-default-start_folder-to-None.patch 052-Add-Ctrl+Alt+Shift+Esc-key-command-for-loginds-SecureAttentionKey.patch ----------(New B)---------- New:- Upstream bug fixes (bsc#1027942) 050-Validation-allow-spaces-disallow-slashes.patch 051-fix-default-start_folder-to-None.patch New: 050-Validation-allow-spaces-disallow-slashes.patch 051-fix-default-start_folder-to-None.patch 052-Add-Ctrl+Alt+Shift+Esc-key-command-for-loginds-SecureAttentionKey.patch New: 051-fix-default-start_folder-to-None.patch 052-Add-Ctrl+Alt+Shift+Esc-key-command-for-loginds-SecureAttentionKey.patch ----------(New E)---------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.kVl8N2/_old 2025-06-26 14:06:36.277074516 +0200 +++ /var/tmp/diff_new_pack.kVl8N2/_new 2025-06-26 14:06:36.281074682 +0200 @@ -83,6 +83,9 @@ Patch47: 047-virt-install-add-support-for-vDPA-network-device.patch Patch48: 048-virt-manager-add-support-for-vDPA-network-device.patch Patch49: 049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch +Patch50: 050-Validation-allow-spaces-disallow-slashes.patch +Patch51: 051-fix-default-start_folder-to-None.patch +Patch52: 052-Add-Ctrl+Alt+Shift+Esc-key-command-for-loginds-SecureAttentionKey.patch Patch100: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch # SUSE Only Patch150: virtman-desktop.patch ++++++ 050-Validation-allow-spaces-disallow-slashes.patch ++++++ Subject: Validation: allow spaces, disallow slashes From: AbhinavTiruvee ranjaniabhi...@gmail.com Mon Apr 7 18:05:41 2025 -0500 Date: Tue Apr 22 12:11:00 2025 +0200: Git: 237896029d668543465b4566d0ea880d468c7058 Libvirt permits spaces in object names but rejects the ‘/’ character. This change aligns our validator with libvirt’s behavior (and QEMU’s), preventing names with '/' while still allowing human‑friendly names with spaces. Fixes: #740 diff --git a/tests/test_xmlparse.py b/tests/test_xmlparse.py index c4107f932..898fc55c3 100644 --- a/tests/test_xmlparse.py +++ b/tests/test_xmlparse.py @@ -1011,7 +1011,9 @@ def testXMLBuilderCoverage(): virtinst.DeviceDisk.validate_generic_name("objtype", None) with pytest.raises(ValueError): - virtinst.DeviceDisk.validate_generic_name("objtype", "foo bar") + virtinst.DeviceDisk.validate_generic_name("objtype", "foo/bar") + + assert virtinst.DeviceDisk.validate_generic_name("objtype", "foo bar") is None # Test property __repr__ for code coverage assert "DeviceAddress" in str(virtinst.DeviceDisk.address) diff --git a/virtinst/xmlbuilder.py b/virtinst/xmlbuilder.py index 64ea25e1b..8ec18a7a7 100644 --- a/virtinst/xmlbuilder.py +++ b/virtinst/xmlbuilder.py @@ -511,9 +511,8 @@ class XMLBuilder(object): @staticmethod def validate_generic_name(name_label, val): - # Rather than try and match libvirt's regex, just forbid things we - # know don't work - forbid = [" "] + # Only character that shouldn't work is '/', matching QEMU + forbid = ["/"] if not val: # translators: value is a generic object type name raise ValueError(_("A name must be specified for the %s") % ++++++ 051-fix-default-start_folder-to-None.patch ++++++ Subject: fix: default start_folder to None From: Zahid Kizmaz tech@zahid.rocks Sun May 11 22:41:44 2025 +0200 Date: Tue Jun 10 09:22:10 2025 +0200: Git: 62f976a61b0363b9e6a0eac1fd2e8553d24d5457 diff --git a/virtManager/storagebrowse.py b/virtManager/storagebrowse.py index 8e8239b4d..d8c70c925 100644 --- a/virtManager/storagebrowse.py +++ b/virtManager/storagebrowse.py @@ -176,6 +176,7 @@ class vmmStorageBrowser(vmmGObjectUI): data = _BrowseReasonMetadata(self._browse_reason) gsettings_key = data.gsettings_key + start_folder = None if gsettings_key: start_folder = self.config.get_default_directory(gsettings_key) ++++++ 052-Add-Ctrl+Alt+Shift+Esc-key-command-for-loginds-SecureAttentionKey.patch ++++++ Subject: Add Ctrl+Alt+Shift+Esc key command for logind's SecureAttentionKey From: n3rdopolis bluescreen_aven...@verizon.net Mon May 5 22:29:18 2025 -0400 Date: Wed Jun 11 09:32:34 2025 +0200: Git: 4b89c39eea1cb89dda597d81831fc385db3f8cbc logind now supports a new key binding https://github.com/systemd/systemd/pull/29542 Ctrl+Alt+Shift+Esc that emits SecureAttentionKey to allow login managers to start or switch back to the greeter diff --git a/virtManager/details/console.py b/virtManager/details/console.py index 54b587772..e68bb9ac8 100644 --- a/virtManager/details/console.py +++ b/virtManager/details/console.py @@ -120,6 +120,7 @@ def build_keycombo_menu(on_send_key_fn): make_item("<Control><Alt>BackSpace", ["Control_L", "Alt_L", "BackSpace"]) make_item("<Control><Alt>Delete", ["Control_L", "Alt_L", "Delete"]) + make_item("<Control><Alt><Shift>Escape", ["Control_L", "Alt_L", "Shift_L", "Escape"]) menu.add(Gtk.SeparatorMenuItem()) for i in range(1, 13): ++++++ virtinst-add-sle16-detection-support.patch ++++++ --- /var/tmp/diff_new_pack.kVl8N2/_old 2025-06-26 14:06:36.681091264 +0200 +++ /var/tmp/diff_new_pack.kVl8N2/_new 2025-06-26 14:06:36.685091430 +0200 @@ -1,7 +1,7 @@ -Index: virt-manager-4.1.0/virtinst/install/urldetect.py +Index: virt-manager-5.0.0/virtinst/install/urldetect.py =================================================================== ---- virt-manager-4.1.0.orig/virtinst/install/urldetect.py -+++ virt-manager-4.1.0/virtinst/install/urldetect.py +--- virt-manager-5.0.0.orig/virtinst/install/urldetect.py ++++ virt-manager-5.0.0/virtinst/install/urldetect.py @@ -279,6 +279,10 @@ class _SUSEContent(object): else: if "SUSE SL Micro" in self.product_name: @@ -13,7 +13,24 @@ else: sle_version = self.product_name.strip().rsplit(' ')[4] if len(self.product_name.strip().rsplit(' ')) > 5 and not " Micro " in self.product_name: -@@ -582,6 +586,10 @@ class _SuseDistro(_RHELDistro): +@@ -521,10 +525,16 @@ class _SuseDistro(_RHELDistro): + content_str = cache.acquire_file_content("content") + if content_str is None: + products_str = cache.acquire_file_content("media.1/products") ++ if not products_str: ++ # For SLES16 install iso (not agama) ++ products_str = cache.acquire_file_content("install/media.1/products") + if products_str: + products_str = products_str.replace('/', ' ,', 1) + products_str = "DISTRO " + products_str.replace('-', ' ') + media_str = cache.acquire_file_content("media.1/media") ++ if not media_str: ++ # For SLES16 install iso (not agama) ++ media_str = cache.acquire_file_content("install/media.1/media") + if media_str: + media_arch = "x86_64" + if 'aarch64' in media_str: +@@ -582,6 +592,10 @@ class _SuseDistro(_RHELDistro): self._kernel_paths.append( ("suseboot/linux64", "suseboot/initrd64"))