Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package ntpd-rs for openSUSE:Factory checked in at 2025-07-22 12:20:03 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ntpd-rs (Old) and /work/SRC/openSUSE:Factory/.ntpd-rs.new.8875 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ntpd-rs" Tue Jul 22 12:20:03 2025 rev:10 rq:1294876 version:1.6.1 Changes: -------- --- /work/SRC/openSUSE:Factory/ntpd-rs/ntpd-rs.changes 2025-07-01 11:36:11.342379507 +0200 +++ /work/SRC/openSUSE:Factory/.ntpd-rs.new.8875/ntpd-rs.changes 2025-07-22 12:20:08.579741284 +0200 @@ -1,0 +2,7 @@ +Wed Jul 16 16:00:25 UTC 2025 - Martin Hauke <mar...@gmx.de> + +- Update to version 1.6.1 + * Fixed mistake in the calculation of root dispersion used in + serving and observability. + +------------------------------------------------------------------- Old: ---- ntpd-rs-1.6.0.tar.gz New: ---- ntpd-rs-1.6.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ntpd-rs.spec ++++++ --- /var/tmp/diff_new_pack.KJx6KO/_old 2025-07-22 12:20:09.795792016 +0200 +++ /var/tmp/diff_new_pack.KJx6KO/_new 2025-07-22 12:20:09.799792183 +0200 @@ -19,7 +19,7 @@ %define services ntpd-rs.service ntpd-rs-metrics.service Name: ntpd-rs -Version: 1.6.0 +Version: 1.6.1 Release: 0 Summary: Full-featured implementation of NTP with NTS support License: Apache-2.0 OR MIT ++++++ ntpd-rs-1.6.0.tar.gz -> ntpd-rs-1.6.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/CHANGELOG.md new/ntpd-rs-1.6.1/CHANGELOG.md --- old/ntpd-rs-1.6.0/CHANGELOG.md 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/CHANGELOG.md 2025-07-16 09:24:23.000000000 +0200 @@ -1,5 +1,10 @@ # Changelog +## [1.6.1] - 2025-07-16 + +### Fixed +- Fixed mistake in the calculation of root dispersion used in serving and observability. + ## [1.6.0] - 2025-06-26 ### Added @@ -301,6 +306,7 @@ - Fixed a bug in peer dispersion calculation which resulted in overly pessimistic dispersion estimates. +[1.6.1]: https://github.com/pendulum-project/ntpd-rs/compare/v1.6.0...v1.6.1 [1.6.0]: https://github.com/pendulum-project/ntpd-rs/compare/v1.5.0...v1.6.0 [1.5.0]: https://github.com/pendulum-project/ntpd-rs/compare/v1.4.0...v1.5.0 [1.4.0]: https://github.com/pendulum-project/ntpd-rs/compare/v1.3.1...v1.4.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/Cargo.lock new/ntpd-rs-1.6.1/Cargo.lock --- old/ntpd-rs-1.6.0/Cargo.lock 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/Cargo.lock 2025-07-16 09:24:23.000000000 +0200 @@ -573,7 +573,7 @@ [[package]] name = "ntp-proto" -version = "1.6.0" +version = "1.6.1" dependencies = [ "aead", "aes-siv", @@ -590,7 +590,7 @@ [[package]] name = "ntpd" -version = "1.6.0" +version = "1.6.1" dependencies = [ "async-trait", "clock-steering", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/Cargo.toml new/ntpd-rs-1.6.1/Cargo.toml --- old/ntpd-rs-1.6.0/Cargo.toml 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/Cargo.toml 2025-07-16 09:24:23.000000000 +0200 @@ -11,7 +11,7 @@ # Global settings for our crates [workspace.package] -version = "1.6.0" +version = "1.6.1" edition = "2021" license = "Apache-2.0 OR MIT" repository = "https://github.com/pendulum-project/ntpd-rs"; @@ -60,4 +60,4 @@ # our own crates used as dependencies, same version as the workspace version # NOTE: keep this part at the bottom of the file, do not change this line -ntp-proto = { version = "1.6.0", path = "./ntp-proto", default-features = false, features = ["__internal-api"] } +ntp-proto = { version = "1.6.1", path = "./ntp-proto", default-features = false, features = ["__internal-api"] } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/man/ntp-ctl.8.md new/ntpd-rs-1.6.1/docs/man/ntp-ctl.8.md --- old/ntpd-rs-1.6.0/docs/man/ntp-ctl.8.md 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/man/ntp-ctl.8.md 2025-07-16 09:24:23.000000000 +0200 @@ -1,5 +1,5 @@ <!-- --- -title: NTP-CTL(8) ntpd-rs 1.6.0 | ntpd-rs +title: NTP-CTL(8) ntpd-rs 1.6.1 | ntpd-rs --- --> # NAME diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/man/ntp-daemon.8.md new/ntpd-rs-1.6.1/docs/man/ntp-daemon.8.md --- old/ntpd-rs-1.6.0/docs/man/ntp-daemon.8.md 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/man/ntp-daemon.8.md 2025-07-16 09:24:23.000000000 +0200 @@ -1,5 +1,5 @@ <!-- --- -title: NTP-DAEMON(8) ntpd-rs 1.6.0 | ntpd-rs +title: NTP-DAEMON(8) ntpd-rs 1.6.1 | ntpd-rs --- --> # NAME diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/man/ntp-metrics-exporter.8.md new/ntpd-rs-1.6.1/docs/man/ntp-metrics-exporter.8.md --- old/ntpd-rs-1.6.0/docs/man/ntp-metrics-exporter.8.md 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/man/ntp-metrics-exporter.8.md 2025-07-16 09:24:23.000000000 +0200 @@ -1,5 +1,5 @@ <!-- --- -title: NTP-METRICS-EXPORTER(8) ntpd-rs 1.6.0 | ntpd-rs +title: NTP-METRICS-EXPORTER(8) ntpd-rs 1.6.1 | ntpd-rs --- --> # NAME diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/man/ntp.toml.5.md new/ntpd-rs-1.6.1/docs/man/ntp.toml.5.md --- old/ntpd-rs-1.6.0/docs/man/ntp.toml.5.md 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/man/ntp.toml.5.md 2025-07-16 09:24:23.000000000 +0200 @@ -1,5 +1,5 @@ <!-- --- -title: NTP.TOML(5) ntpd-rs 1.6.0 | ntpd-rs +title: NTP.TOML(5) ntpd-rs 1.6.1 | ntpd-rs --- --> # NAME diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/precompiled/man/ntp-ctl.8 new/ntpd-rs-1.6.1/docs/precompiled/man/ntp-ctl.8 --- old/ntpd-rs-1.6.0/docs/precompiled/man/ntp-ctl.8 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/precompiled/man/ntp-ctl.8 2025-07-16 09:24:23.000000000 +0200 @@ -14,7 +14,7 @@ . ftr VB CB . ftr VBI CBI .\} -.TH "NTP-CTL" "8" "" "ntpd-rs 1.6.0" "ntpd-rs" +.TH "NTP-CTL" "8" "" "ntpd-rs 1.6.1" "ntpd-rs" .hy .SH NAME .PP diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/precompiled/man/ntp-daemon.8 new/ntpd-rs-1.6.1/docs/precompiled/man/ntp-daemon.8 --- old/ntpd-rs-1.6.0/docs/precompiled/man/ntp-daemon.8 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/precompiled/man/ntp-daemon.8 2025-07-16 09:24:23.000000000 +0200 @@ -14,7 +14,7 @@ . ftr VB CB . ftr VBI CBI .\} -.TH "NTP-DAEMON" "8" "" "ntpd-rs 1.6.0" "ntpd-rs" +.TH "NTP-DAEMON" "8" "" "ntpd-rs 1.6.1" "ntpd-rs" .hy .SH NAME .PP diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/precompiled/man/ntp-metrics-exporter.8 new/ntpd-rs-1.6.1/docs/precompiled/man/ntp-metrics-exporter.8 --- old/ntpd-rs-1.6.0/docs/precompiled/man/ntp-metrics-exporter.8 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/precompiled/man/ntp-metrics-exporter.8 2025-07-16 09:24:23.000000000 +0200 @@ -14,7 +14,7 @@ . ftr VB CB . ftr VBI CBI .\} -.TH "NTP-METRICS-EXPORTER" "8" "" "ntpd-rs 1.6.0" "ntpd-rs" +.TH "NTP-METRICS-EXPORTER" "8" "" "ntpd-rs 1.6.1" "ntpd-rs" .hy .SH NAME .PP diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/docs/precompiled/man/ntp.toml.5 new/ntpd-rs-1.6.1/docs/precompiled/man/ntp.toml.5 --- old/ntpd-rs-1.6.0/docs/precompiled/man/ntp.toml.5 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/docs/precompiled/man/ntp.toml.5 2025-07-16 09:24:23.000000000 +0200 @@ -14,7 +14,7 @@ . ftr VB CB . ftr VBI CBI .\} -.TH "NTP.TOML" "5" "" "ntpd-rs 1.6.0" "ntpd-rs" +.TH "NTP.TOML" "5" "" "ntpd-rs 1.6.1" "ntpd-rs" .hy .SH NAME .PP diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/ntp-proto/src/system.rs new/ntpd-rs-1.6.1/ntp-proto/src/system.rs --- old/ntpd-rs-1.6.0/ntp-proto/src/system.rs 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/ntp-proto/src/system.rs 2025-07-16 09:24:23.000000000 +0200 @@ -43,11 +43,13 @@ impl TimeSnapshot { pub fn root_dispersion(&self, now: NtpTimestamp) -> NtpDuration { let t = (now - self.root_variance_base_time).to_seconds(); + // Note: dispersion is the standard deviation, so we need a sqrt here. NtpDuration::from_seconds( - self.root_variance_base + (self.root_variance_base + t * self.root_variance_linear + t.powi(2) * self.root_variance_quadratic - + t.powi(3) * self.root_variance_cubic, + + t.powi(3) * self.root_variance_cubic) + .sqrt(), ) } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/ntpd/build.rs new/ntpd-rs-1.6.1/ntpd/build.rs --- old/ntpd-rs-1.6.0/ntpd/build.rs 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/ntpd/build.rs 2025-07-16 09:24:23.000000000 +0200 @@ -29,7 +29,7 @@ .ok() .map(|rev| { if is_dirty { - format!("{}-dirty", rev) + format!("{rev}-dirty") } else { rev } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/ntpd/src/daemon/config/mod.rs new/ntpd-rs-1.6.1/ntpd/src/daemon/config/mod.rs --- old/ntpd-rs-1.6.0/ntpd/src/daemon/config/mod.rs 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/ntpd/src/daemon/config/mod.rs 2025-07-16 09:24:23.000000000 +0200 @@ -116,7 +116,7 @@ // short version of --help has no arguments processed.push(CliArg::Flag(flag)); } else { - Err(format!("'-{}' expects an argument", char))?; + Err(format!("'-{char}' expects an argument"))?; } break; } else { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/ntpd/src/daemon/keyexchange.rs new/ntpd-rs-1.6.1/ntpd/src/daemon/keyexchange.rs --- old/ntpd-rs-1.6.0/ntpd/src/daemon/keyexchange.rs 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/ntpd/src/daemon/keyexchange.rs 2025-07-16 09:24:23.000000000 +0200 @@ -120,8 +120,7 @@ for client_cert in &nts_ke_config.authorized_pool_server_certificates { let pool_certificate_file = std::fs::File::open(client_cert).map_err(|e| { io_error(&format!( - "error reading authorized-pool-server-certificate at `{:?}`: {:?}", - client_cert, e + "error reading authorized-pool-server-certificate at `{client_cert:?}`: {e:?}" )) })?; let mut certs: Vec<_> = ntp_proto::tls_utils::pemfile::certs(&mut std::io::BufReader::new( @@ -133,8 +132,7 @@ pool_certs.push(certs.pop().unwrap()) } else { return Err(io_error(&format!( - "pool certificate file at `{:?}` should contain exactly one certificate", - client_cert + "pool certificate file at `{client_cert:?}` should contain exactly one certificate" ))); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/ntpd/src/daemon/spawn/standard.rs new/ntpd-rs-1.6.1/ntpd/src/daemon/spawn/standard.rs --- old/ntpd-rs-1.6.0/ntpd/src/daemon/spawn/standard.rs 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/ntpd/src/daemon/spawn/standard.rs 2025-07-16 09:24:23.000000000 +0200 @@ -330,17 +330,13 @@ for addr in seen_addresses.iter() { assert!( addresses.contains(addr), - "{:?} should have been drawn from {:?}", - addr, - addresses + "{addr:?} should have been drawn from {addresses:?}" ); } assert!( seen_addresses.iter().any(|seen| seen != &initial_addr), - "Re-resolved\n\n\t{:?}\n\n should contain at least one address that isn't the original\n\n\t{:?}", - seen_addresses, - initial_addr, + "Re-resolved\n\n\t{seen_addresses:?}\n\n should contain at least one address that isn't the original\n\n\t{initial_addr:?}", ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ntpd-rs-1.6.0/ntpd/src/force_sync/mod.rs new/ntpd-rs-1.6.1/ntpd/src/force_sync/mod.rs --- old/ntpd-rs-1.6.0/ntpd/src/force_sync/mod.rs 2025-06-26 15:17:00.000000000 +0200 +++ new/ntpd-rs-1.6.1/ntpd/src/force_sync/mod.rs 2025-07-16 09:24:23.000000000 +0200 @@ -21,20 +21,20 @@ if offset >= 86400.0 { let days = (offset / 86400.0).floor() as u64; offset -= days as f64 * 86400.0; - res.push_str(&format!("{} day(s) ", days)); + res.push_str(&format!("{days} day(s) ")); } if offset >= 3600.0 { let hours = (offset / 3600.0).floor() as u64; offset -= hours as f64 * 3600.0; - res.push_str(&format!("{} hour(s) ", hours)); + res.push_str(&format!("{hours} hour(s) ")); } if offset >= 60.0 { let minutes = (offset / 60.0).floor() as u64; offset -= minutes as f64 * 60.0; - res.push_str(&format!("{} minute(s) ", minutes)); + res.push_str(&format!("{minutes} minute(s) ")); } if offset >= 1.0 { - res.push_str(&format!("{:.0} second(s)", offset)); + res.push_str(&format!("{offset:.0} second(s)")); } res } @@ -53,7 +53,7 @@ std::process::Command::new("date") .arg("-d") - .arg(format!("@{}", ts)) + .arg(format!("@{ts}")) .arg("+%c") .output() .ok() ++++++ vendor.tar.zst ++++++ /work/SRC/openSUSE:Factory/ntpd-rs/vendor.tar.zst /work/SRC/openSUSE:Factory/.ntpd-rs.new.8875/vendor.tar.zst differ: char 8, line 1
