Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package grub2 for openSUSE:Factory checked in at 2025-09-23 20:47:08 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/grub2 (Old) and /work/SRC/openSUSE:Factory/.grub2.new.27445 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "grub2" Tue Sep 23 20:47:08 2025 rev:373 rq:1306728 version:2.12 Changes: -------- --- /work/SRC/openSUSE:Factory/grub2/grub2.changes 2025-09-12 21:09:26.743013763 +0200 +++ /work/SRC/openSUSE:Factory/.grub2.new.27445/grub2.changes 2025-09-23 20:47:57.637527158 +0200 @@ -1,0 +2,13 @@ +Tue Sep 23 08:47:49 UTC 2025 - Steffen Winterfeldt <[email protected]> + +- turn off page flipping for i386-pc using VBE video backend (bsc#1245636) + * grub2-i386-pc-no-pageflipping.patch + +------------------------------------------------------------------- +Mon Sep 22 07:15:00 UTC 2025 - Michael Chang <[email protected]> + +- Fix boot hangs in setting up serial console when ACPI SPCR table is present + and redirection is disabled (bsc#1249088) + * 0001-term-ns8250-spcr-Return-if-redirection-is-disabled.patch + +------------------------------------------------------------------- New: ---- 0001-term-ns8250-spcr-Return-if-redirection-is-disabled.patch grub2-i386-pc-no-pageflipping.patch ----------(New B)---------- New: and redirection is disabled (bsc#1249088) * 0001-term-ns8250-spcr-Return-if-redirection-is-disabled.patch New:- turn off page flipping for i386-pc using VBE video backend (bsc#1245636) * grub2-i386-pc-no-pageflipping.patch ----------(New E)---------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ grub2.spec ++++++ --- /var/tmp/diff_new_pack.IFUkIS/_old 2025-09-23 20:48:02.513733291 +0200 +++ /var/tmp/diff_new_pack.IFUkIS/_new 2025-09-23 20:48:02.517733461 +0200 @@ -1,6 +1,7 @@ # # spec file for package grub2 # +# Copyright (c) 2025 SUSE LLC # Copyright (c) 2025 SUSE LLC and contributors # # All modifications and additions to the file contributed by third parties @@ -516,6 +517,8 @@ Patch340: 0002-lib-pbkdf2-Optimize-PBKDF2-by-reusing-HMAC-handle.patch Patch341: 0001-kern-misc-Implement-faster-grub_memcpy-for-aligned-b.patch Patch342: grub2-bls-loader-entry-default.patch +Patch343: 0001-term-ns8250-spcr-Return-if-redirection-is-disabled.patch +Patch344: grub2-i386-pc-no-pageflipping.patch %if 0%{?suse_version} < 1600 Requires: gettext-runtime ++++++ 0001-term-ns8250-spcr-Return-if-redirection-is-disabled.patch ++++++ >From f0a08324d0f923527ba611887a3780c1f2cb1578 Mon Sep 17 00:00:00 2001 From: Benjamin Herrenschmidt <[email protected]> Date: Tue, 21 Jan 2025 11:01:26 -0600 Subject: [PATCH] term/ns8250-spcr: Return if redirection is disabled The Microsoft spec for SPCR says "The base address of the Serial Port register set described using the ACPI Generic Address Structure, or 0 if console redirection is disabled". So, return early if redirection is disabled (base address = 0). If this check is not done we may get invalid ports on machines with redirection disabled and boot may hang when reading the grub.cfg file. Signed-off-by: Benjamin Herrenschmidt <[email protected]> Reviewed-by: Leo Sandoval <[email protected]> Reviewed-by: Daniel Kiper <[email protected]> --- grub-core/term/ns8250-spcr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/grub-core/term/ns8250-spcr.c b/grub-core/term/ns8250-spcr.c index 4efaaf768..428b2d59a 100644 --- a/grub-core/term/ns8250-spcr.c +++ b/grub-core/term/ns8250-spcr.c @@ -76,6 +76,11 @@ grub_ns8250_spcr_init (void) config.speed = 115200; break; }; + + /* If base address is 0 it means redirection is disabled. */ + if (spcr->base_addr.addr == 0) + return NULL; + switch (spcr->base_addr.space_id) { case GRUB_ACPI_GENADDR_MEM_SPACE: -- 2.51.0 ++++++ grub2-i386-pc-no-pageflipping.patch ++++++ In x86 Legacy BIOS mode, on some Lenovo machines, the grub menu is not visible, although it demonstrably has been drawn (bsc#1245636). A workaround to avoid this is to not use page flipping mode. This patch enforces that no page flipping is used in the VBE framebuffer backend for i386-pc. --- a/grub-core/video/i386/pc/vbe.c +++ b/grub-core/video/i386/pc/vbe.c @@ -1137,7 +1137,8 @@ grub_video_vbe_setup (unsigned int width, unsigned int height, page_size = framebuffer.mode_info.pitch * framebuffer.mode_info.height; - if (vram_size >= 2 * page_size) + /* avoid page flipping mode (bsc#1245636) */ + if (0 && vram_size >= 2 * page_size) err = grub_video_fb_setup (mode_type, mode_mask, &framebuffer.mode_info, framebuffer.ptr,
