Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package agama for openSUSE:Factory checked in at 2025-09-23 16:07:56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/agama (Old) and /work/SRC/openSUSE:Factory/.agama.new.27445 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "agama" Tue Sep 23 16:07:56 2025 rev:30 rq:1306659 version:0 Changes: -------- --- /work/SRC/openSUSE:Factory/agama/agama.changes 2025-08-28 17:20:41.724312258 +0200 +++ /work/SRC/openSUSE:Factory/.agama.new.27445/agama.changes 2025-09-23 16:08:40.923114256 +0200 @@ -1,0 +2,6 @@ +Mon Sep 15 21:09:06 UTC 2025 - Imobach Gonzalez Sosa <[email protected]> + +- Do not log the events to prevent leaking passwords (bsc#1249622). +- Set logs permissions to 0o600. + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ agama.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/agama/agama-lib/src/manager/http_client.rs new/agama/agama-lib/src/manager/http_client.rs --- old/agama/agama-lib/src/manager/http_client.rs 2025-08-28 13:52:06.000000000 +0200 +++ new/agama/agama-lib/src/manager/http_client.rs 2025-09-16 09:04:46.000000000 +0200 @@ -24,8 +24,8 @@ manager::InstallerStatus, }; use reqwest::header::CONTENT_ENCODING; -use std::io::Cursor; use std::path::{Path, PathBuf}; +use std::{fs, io::Cursor, os::unix::fs::OpenOptionsExt}; use super::FinishMethod; @@ -93,11 +93,18 @@ })?); // 3) store response's binary content (logs) in a file - let mut file = std::fs::File::create(destination.as_path()).map_err(|_| { - ManagerHTTPClientError::CannotGenerateLogs(String::from( - "Cannot store received response", - )) - })?; + let mut file = fs::OpenOptions::new() + .create(true) + .truncate(true) + .write(true) + .mode(0o600) + .open(&destination) + .map_err(|_| { + ManagerHTTPClientError::CannotGenerateLogs(String::from( + "Cannot store received response", + )) + })?; + let mut content = Cursor::new(response.bytes().await.map_err(BaseHTTPClientError::HTTP)?); std::io::copy(&mut content, &mut file).map_err(|_| { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/agama/agama-server/src/web/common/progress.rs new/agama/agama-server/src/web/common/progress.rs --- old/agama/agama-server/src/web/common/progress.rs 2025-08-28 13:52:06.000000000 +0200 +++ new/agama/agama-server/src/web/common/progress.rs 2025-09-16 09:04:46.000000000 +0200 @@ -35,7 +35,7 @@ //! //! At this point, it only handles the progress that are exposed through D-Bus. -use crate::web::{event::log_event, EventsSender}; +use crate::web::EventsSender; use agama_lib::{ event, http::Event, @@ -175,7 +175,6 @@ path: path.to_string(), progress, }); - log_event(&event); self.events.send(event)?; Ok(()) } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/agama/agama-server/src/web/event.rs new/agama/agama-server/src/web/event.rs --- old/agama/agama-server/src/web/event.rs 2025-08-28 13:52:06.000000000 +0200 +++ new/agama/agama-server/src/web/event.rs 2025-09-16 09:04:46.000000000 +0200 @@ -23,11 +23,3 @@ pub type EventsSender = Sender<Event>; pub type EventsReceiver = Receiver<Event>; - -pub fn log_event(event: &Event) { - tracing::info!("event(debug): {:?}", &event); - match serde_json::to_string(&event) { - Ok(json) => tracing::info!("event: {json}"), - Err(_) => tracing::info!("event (not serialized): {:?}", &event), - } -} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/agama/agama-server/src/web.rs new/agama/agama-server/src/web.rs --- old/agama/agama-server/src/web.rs 2025-08-28 13:52:06.000000000 +0200 +++ new/agama/agama-server/src/web.rs 2025-09-16 09:04:46.000000000 +0200 @@ -56,7 +56,6 @@ use agama_lib::{connection, error::ServiceError, http::Event}; use common::{IssuesService, ProgressService}; pub use config::ServiceConfig; -use event::log_event; pub use event::{EventsReceiver, EventsSender}; pub use service::MainServiceBuilder; use std::path::Path; @@ -190,7 +189,6 @@ tokio::pin!(stream); let e = events.clone(); while let Some((_, event)) = stream.next().await { - log_event(&event); _ = e.send(event); } Ok(()) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/agama/package/agama.changes new/agama/package/agama.changes --- old/agama/package/agama.changes 2025-08-28 13:52:06.000000000 +0200 +++ new/agama/package/agama.changes 2025-09-16 09:04:46.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Sep 15 21:09:06 UTC 2025 - Imobach Gonzalez Sosa <[email protected]> + +- Do not log the events to prevent leaking passwords (bsc#1249622). +- Set logs permissions to 0o600. + +------------------------------------------------------------------- Thu Aug 28 10:15:23 UTC 2025 - Imobach Gonzalez Sosa <[email protected]> - Update the software cache when the patterns selection changes (bsc#1248826). ++++++ agama.obsinfo ++++++ --- /var/tmp/diff_new_pack.3Ke8BM/_old 2025-09-23 16:08:42.135165057 +0200 +++ /var/tmp/diff_new_pack.3Ke8BM/_new 2025-09-23 16:08:42.139165226 +0200 @@ -1,5 +1,5 @@ name: agama -version: 17+316.0791f5bbd -mtime: 1756381926 -commit: 0791f5bbd6d170a2649ff582819d639559484e8d +version: 17+359.34bc8cc0b +mtime: 1758006286 +commit: 34bc8cc0b00fc66a65a6fa8c91e68fd3edcea711
