Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package ibus for openSUSE:Factory checked in at 2025-09-23 16:06:46 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ibus (Old) and /work/SRC/openSUSE:Factory/.ibus.new.27445 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ibus" Tue Sep 23 16:06:46 2025 rev:133 rq:1306536 version:1.5.32 Changes: -------- --- /work/SRC/openSUSE:Factory/ibus/ibus.changes 2025-09-17 17:44:53.484098992 +0200 +++ /work/SRC/openSUSE:Factory/.ibus.new.27445/ibus.changes 2025-09-23 16:07:20.775730456 +0200 @@ -1,0 +2,6 @@ +Mon Sep 22 12:53:08 UTC 2025 - Hillwood Yang <[email protected]> + +- Add fix-candidate-does-not-hide-automatically.patch + * Fix PageUp/PageDown buttons with hidding candidate popup + +------------------------------------------------------------------- New: ---- fix-candidate-does-not-hide-automatically.patch ----------(New B)---------- New: - Add fix-candidate-does-not-hide-automatically.patch * Fix PageUp/PageDown buttons with hidding candidate popup ----------(New E)---------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ibus.spec ++++++ --- /var/tmp/diff_new_pack.jWsxW6/_old 2025-09-23 16:07:21.747771278 +0200 +++ /var/tmp/diff_new_pack.jWsxW6/_new 2025-09-23 16:07:21.751771445 +0200 @@ -1,7 +1,7 @@ # # spec file for package ibus # -# Copyright (c) 2025 SUSE LLC +# Copyright (c) 2025 SUSE LLC and contributors # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -73,6 +73,9 @@ # Qt5 does not be update to the new version and patch for ibus on Leap 15, # it still needs this patch on leap 15. (boo#1187202) Patch15: ibus-socket-name-compatibility.patch +# Fix PageUp/PageDown buttons with hidding candidate popup +# https://github.com/fujiwarat/ibus/commit/f9592f30a2c2ac9f3b331eddf00845d9584e3bdc +Patch16: fix-candidate-does-not-hide-automatically.patch BuildRequires: pkgconfig(dbusmenu-glib-0.4) BuildRequires: pkgconfig(dbusmenu-gtk3-0.4) BuildRequires: pkgconfig(glib-2.0) >= 2.84.0 @@ -232,6 +235,7 @@ %if 0%{?suse_version} <= 1500 %patch -P 15 -p1 %endif +%patch -P 16 -p1 %build %configure --disable-static \ ++++++ fix-candidate-does-not-hide-automatically.patch ++++++ >From f9592f30a2c2ac9f3b331eddf00845d9584e3bdc Mon Sep 17 00:00:00 2001 From: fujiwarat <[email protected]> Date: Fri, 13 Jun 2025 15:57:37 +0900 Subject: [PATCH] ui/gtk3: Fix PageUp/PageDown buttons with hidding candidate popup Gtk.Widget.show_all() changes the visibilities of the child widgets and it's not good in case that the parent visibility depends on the visibilities of child widgets. Also using no_show_all property could introduce the more complicated logic to the candidate popup. BUG=https://github.com/ibus/ibus/issues/2757 Fixes: https://github.com/ibus/ibus/commit/6ac6188 Fixes: https://github.com/ibus/ibus/commit/d5e6e71 --- ui/gtk3/candidatepanel.vala | 7 +++++-- ui/gtk3/panel.vala | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/ui/gtk3/candidatepanel.vala b/ui/gtk3/candidatepanel.vala index a4137f052..3cc2c0861 100644 --- a/ui/gtk3/candidatepanel.vala +++ b/ui/gtk3/candidatepanel.vala @@ -214,7 +214,6 @@ public class CandidatePanel : Gtk.Box{ m_set_preedit_text_id = Timeout.add(100, () => { - //warning("test set_preedit_text_real"); m_set_preedit_text_id = 0; set_preedit_text_real(text, cursor); return Source.REMOVE; @@ -480,7 +479,11 @@ public class CandidatePanel : Gtk.Box{ } public new void show() { - m_toplevel.show_all(); + // m_toplevel.show_all() changes m_candidate_area.get_visible() + // in update_real() so show() is just used. Using no_show_all + // property for m_candidate_area would introduce the more + // complicated logic. + m_toplevel.show(); } public new void hide() { diff --git a/ui/gtk3/panel.vala b/ui/gtk3/panel.vala index d65ffbb3f..61ee2e43d 100644 --- a/ui/gtk3/panel.vala +++ b/ui/gtk3/panel.vala @@ -218,7 +218,7 @@ class Panel : IBus.PanelService { #if USE_GDK_WAYLAND private CandidatePanel get_active_candidate_panel() { - if (m_wayland_object_path == null) { + if (m_is_wayland && m_wayland_object_path == null) { if (m_candidate_panel_x11 == null) { m_candidate_panel_x11 = candidate_panel_new(true); set_use_glyph_from_engine_lang(); @@ -233,7 +233,7 @@ class Panel : IBus.PanelService { } private Switcher get_active_switcher() { - if (m_wayland_object_path == null) { + if (m_is_wayland && m_wayland_object_path == null) { if (m_switcher_x11 == null) m_switcher_x11 = switcher_new(true); return m_switcher_x11;
