Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-bootloader for
openSUSE:Factory checked in at 2021-04-23 17:50:20
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-bootloader (Old)
and /work/SRC/openSUSE:Factory/.yast2-bootloader.new.12324 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-bootloader"
Fri Apr 23 17:50:20 2021 rev:306 rq:887029 version:4.4.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-bootloader/yast2-bootloader.changes
2021-03-30 20:50:08.096031284 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-bootloader.new.12324/yast2-bootloader.changes
2021-04-23 17:50:26.586775345 +0200
@@ -1,0 +2,12 @@
+Tue Apr 20 13:51:55 UTC 2021 - Ladislav Slez??k <lsle...@suse.cz>
+
+- 4.4.0
+
+-------------------------------------------------------------------
+Mon Apr 19 18:21:58 UTC 2021 - Josef Reidinger <jreidin...@suse.com>
+
+- Fix crash when bootloader is not managed by yast and security
+ module wants to show cpu mitigation (bsc#1184968)
+- 4.3.26
+
+-------------------------------------------------------------------
Old:
----
yast2-bootloader-4.3.25.tar.bz2
New:
----
yast2-bootloader-4.4.0.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-bootloader.spec ++++++
--- /var/tmp/diff_new_pack.HCMqax/_old 2021-04-23 17:50:27.162776335 +0200
+++ /var/tmp/diff_new_pack.HCMqax/_new 2021-04-23 17:50:27.166776342 +0200
@@ -17,7 +17,7 @@
Name: yast2-bootloader
-Version: 4.3.25
+Version: 4.4.0
Release: 0
Summary: YaST2 - Bootloader Configuration
License: GPL-2.0-or-later
++++++ yast2-bootloader-4.3.25.tar.bz2 -> yast2-bootloader-4.4.0.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-bootloader-4.3.25/package/yast2-bootloader.changes
new/yast2-bootloader-4.4.0/package/yast2-bootloader.changes
--- old/yast2-bootloader-4.3.25/package/yast2-bootloader.changes
2021-03-10 14:38:02.000000000 +0100
+++ new/yast2-bootloader-4.4.0/package/yast2-bootloader.changes 2021-04-20
15:53:47.000000000 +0200
@@ -1,4 +1,16 @@
-------------------------------------------------------------------
+Tue Apr 20 13:51:55 UTC 2021 - Ladislav Slez??k <lsle...@suse.cz>
+
+- 4.4.0
+
+-------------------------------------------------------------------
+Mon Apr 19 18:21:58 UTC 2021 - Josef Reidinger <jreidin...@suse.com>
+
+- Fix crash when bootloader is not managed by yast and security
+ module wants to show cpu mitigation (bsc#1184968)
+- 4.3.26
+
+-------------------------------------------------------------------
Wed Mar 10 12:47:05 UTC 2021 - Josef Reidinger <jreidin...@suse.com>
- Add validation to device map dialog to prevent exceeding BIOS
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-bootloader-4.3.25/package/yast2-bootloader.spec
new/yast2-bootloader-4.4.0/package/yast2-bootloader.spec
--- old/yast2-bootloader-4.3.25/package/yast2-bootloader.spec 2021-03-10
14:38:02.000000000 +0100
+++ new/yast2-bootloader-4.4.0/package/yast2-bootloader.spec 2021-04-20
15:53:47.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-bootloader
-Version: 4.3.25
+Version: 4.4.0
Release: 0
Summary: YaST2 - Bootloader Configuration
License: GPL-2.0-or-later
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-bootloader-4.3.25/src/lib/bootloader/grub2_widgets.rb
new/yast2-bootloader-4.4.0/src/lib/bootloader/grub2_widgets.rb
--- old/yast2-bootloader-4.3.25/src/lib/bootloader/grub2_widgets.rb
2021-03-10 14:38:02.000000000 +0100
+++ new/yast2-bootloader-4.4.0/src/lib/bootloader/grub2_widgets.rb
2021-04-20 15:53:47.000000000 +0200
@@ -129,7 +129,7 @@
def items
::Bootloader::CpuMitigations::ALL.map do |m|
- [m.value, m.to_human_string]
+ [m.value.to_s, m.to_human_string]
end
end
@@ -159,11 +159,17 @@
end
def init
- self.value = grub2.cpu_mitigations.value
+ if grub2.respond_to?(:cpu_mitigations)
+ self.value = grub2.cpu_mitigations.value.to_s
+ else
+ # do not crash when use no bootloader. This widget is also used in
security dialog.
+ # (bsc#1184968)
+ disable
+ end
end
def store
- grub2.cpu_mitigations = ::Bootloader::CpuMitigations.new(value)
+ grub2.cpu_mitigations = ::Bootloader::CpuMitigations.new(value.to_sym)
if enabled?
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-bootloader-4.3.25/test/grub2_widgets_test.rb
new/yast2-bootloader-4.4.0/test/grub2_widgets_test.rb
--- old/yast2-bootloader-4.3.25/test/grub2_widgets_test.rb 2021-03-10
14:38:02.000000000 +0100
+++ new/yast2-bootloader-4.4.0/test/grub2_widgets_test.rb 2021-04-20
15:53:47.000000000 +0200
@@ -102,6 +102,38 @@
end
end
+describe Bootloader::CpuMitigationsWidget do
+ before do
+ assign_bootloader
+ end
+
+ it_behaves_like "labeled widget"
+ it_behaves_like "CWM::ComboBox"
+
+ context "when none bootloader is selected" do
+ before do
+ assign_bootloader("none")
+ end
+
+ describe "#init" do
+ it "disables widget" do
+ expect(subject).to receive(:disable)
+
+ subject.init
+ end
+ end
+
+ describe "#store" do
+ it "does nothing on disabled widget" do
+ expect(subject).to receive(:enabled?).and_return(false)
+ expect(subject).to_not receive(:value)
+
+ subject.store
+ end
+ end
+ end
+end
+
describe Bootloader::ActivateWidget do
before do
assign_bootloader
