Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package kubectl-browse-pvc for openSUSE:Factory checked in at 2026-03-09 16:32:23 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kubectl-browse-pvc (Old) and /work/SRC/openSUSE:Factory/.kubectl-browse-pvc.new.8177 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kubectl-browse-pvc" Mon Mar 9 16:32:23 2026 rev:8 rq:1337654 version:1.4.1 Changes: -------- --- /work/SRC/openSUSE:Factory/kubectl-browse-pvc/kubectl-browse-pvc.changes 2026-02-25 21:22:17.075094995 +0100 +++ /work/SRC/openSUSE:Factory/.kubectl-browse-pvc.new.8177/kubectl-browse-pvc.changes 2026-03-09 16:32:37.705437080 +0100 @@ -1,0 +2,8 @@ +Mon Mar 09 12:21:22 UTC 2026 - Johannes Kastl <[email protected]> + +- Update to version 1.4.1: + * add test case + * fix panic when building taints and tolerations for a volume + that is not bound to a node + +------------------------------------------------------------------- Old: ---- kubectl-browse-pvc-1.4.0.obscpio New: ---- kubectl-browse-pvc-1.4.1.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kubectl-browse-pvc.spec ++++++ --- /var/tmp/diff_new_pack.ujEeKU/_old 2026-03-09 16:32:39.457508882 +0100 +++ /var/tmp/diff_new_pack.ujEeKU/_new 2026-03-09 16:32:39.489510194 +0100 @@ -19,7 +19,7 @@ %define executable_name kubectl-browse_pvc Name: kubectl-browse-pvc -Version: 1.4.0 +Version: 1.4.1 Release: 0 Summary: Kubectl plugin for browsing PVCs on the command line License: MIT ++++++ _service ++++++ --- /var/tmp/diff_new_pack.ujEeKU/_old 2026-03-09 16:32:39.801522980 +0100 +++ /var/tmp/diff_new_pack.ujEeKU/_new 2026-03-09 16:32:39.841524619 +0100 @@ -3,7 +3,7 @@ <param name="url">https://github.com/clbx/kubectl-browse-pvc</param> <param name="scm">git</param> <param name="exclude">.git</param> - <param name="revision">v1.4.0</param> + <param name="revision">v1.4.1</param> <param name="versionformat">@PARENT_TAG@</param> <param name="changesgenerate">enable</param> <param name="versionrewrite-pattern">v(.*)</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.ujEeKU/_old 2026-03-09 16:32:40.029532324 +0100 +++ /var/tmp/diff_new_pack.ujEeKU/_new 2026-03-09 16:32:40.073534128 +0100 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/clbx/kubectl-browse-pvc</param> - <param name="changesrevision">547f469a80d8f58f974b47025f1663f82551adf3</param></service></servicedata> + <param name="changesrevision">01eda30d64fcca4e44f105c8ca22e92daf854a29</param></service></servicedata> (No newline at EOF) ++++++ kubectl-browse-pvc-1.4.0.obscpio -> kubectl-browse-pvc-1.4.1.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kubectl-browse-pvc-1.4.0/cmd/browse-pvc/main.go new/kubectl-browse-pvc-1.4.1/cmd/browse-pvc/main.go --- old/kubectl-browse-pvc-1.4.0/cmd/browse-pvc/main.go 2026-02-20 20:44:50.000000000 +0100 +++ new/kubectl-browse-pvc-1.4.1/cmd/browse-pvc/main.go 2026-03-08 03:10:11.000000000 +0100 @@ -119,12 +119,18 @@ node = attachedPod.Spec.NodeName } + var tolerationsForNode []corev1.Toleration = nil + // retrieve taints of the selected node to smartly build in tolerations - nodeTaints, err := utils.GetNodeTaints(clientset, attachedPod.Spec.NodeName) - if err != nil { - fmt.Printf("Failed to get taints for node: %s. Continuing as if there weren't any", attachedPod.Spec.NodeName) + if attachedPod != nil { + nodeTaints, err := utils.GetNodeTaints(clientset, attachedPod.Spec.NodeName) + if err != nil { + log.Printf("Failed to get taints for node: %s. Continuing as if there weren't any", attachedPod.Spec.NodeName) + } + if nodeTaints != nil { + tolerationsForNode = utils.BuildTolerationsForTaints(nodeTaints) + } } - tolerationsForNode := utils.BuildTolerationsForTaints(nodeTaints) options := &utils.PodOptions{ Image: image, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kubectl-browse-pvc-1.4.0/internal/utils/taints_and_tolerations_test.go new/kubectl-browse-pvc-1.4.1/internal/utils/taints_and_tolerations_test.go --- old/kubectl-browse-pvc-1.4.0/internal/utils/taints_and_tolerations_test.go 2026-02-20 20:44:50.000000000 +0100 +++ new/kubectl-browse-pvc-1.4.1/internal/utils/taints_and_tolerations_test.go 2026-03-08 03:10:11.000000000 +0100 @@ -37,10 +37,23 @@ }, ), }, + { + name: "Node not found returns error", + err: nil, + client: fake.NewClientset(), + }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { + if test.name == "Node not found returns error" { + _, err := GetNodeTaints(test.client, "nonexistent-node") + if err == nil { + t.Errorf("Expected an error for a nonexistent node, got nil") + } + return + } + expectedTaints := []v1.Taint{ { Key: "key1", ++++++ kubectl-browse-pvc.obsinfo ++++++ --- /var/tmp/diff_new_pack.ujEeKU/_old 2026-03-09 16:32:40.901568061 +0100 +++ /var/tmp/diff_new_pack.ujEeKU/_new 2026-03-09 16:32:40.917568717 +0100 @@ -1,5 +1,5 @@ name: kubectl-browse-pvc -version: 1.4.0 -mtime: 1771616690 -commit: 547f469a80d8f58f974b47025f1663f82551adf3 +version: 1.4.1 +mtime: 1772935811 +commit: 01eda30d64fcca4e44f105c8ca22e92daf854a29 ++++++ vendor.tar.gz ++++++ /work/SRC/openSUSE:Factory/kubectl-browse-pvc/vendor.tar.gz /work/SRC/openSUSE:Factory/.kubectl-browse-pvc.new.8177/vendor.tar.gz differ: char 13, line 1
