Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-installation for 
openSUSE:Factory checked in at 2021-04-29 22:44:36
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-installation (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-installation.new.1947 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-installation"

Thu Apr 29 22:44:36 2021 rev:468 rq:888801 version:4.4.5

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-installation/yast2-installation.changes    
2021-04-19 21:05:46.404009047 +0200
+++ 
/work/SRC/openSUSE:Factory/.yast2-installation.new.1947/yast2-installation.changes
  2021-04-29 22:44:47.932192764 +0200
@@ -1,0 +2,6 @@
+Tue Apr 27 09:23:17 UTC 2021 - Knut Anderssen <kanders...@suse.com>
+
+- Remove Yast::LanItems dependency (bsc#1185338)
+- 4.4.5
+
+-------------------------------------------------------------------

Old:
----
  yast2-installation-4.4.4.tar.bz2

New:
----
  yast2-installation-4.4.5.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-installation.spec ++++++
--- /var/tmp/diff_new_pack.R18Zwp/_old  2021-04-29 22:44:48.512190181 +0200
+++ /var/tmp/diff_new_pack.R18Zwp/_new  2021-04-29 22:44:48.512190181 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-installation
-Version:        4.4.4
+Version:        4.4.5
 Release:        0
 Summary:        YaST2 - Installation Parts
 License:        GPL-2.0-only
@@ -37,8 +37,8 @@
 BuildRequires:  yast2-devtools >= 3.1.10
 # For firewall widgets
 BuildRequires:  yast2-firewall
-# Y2Network::NtpServer
-BuildRequires:  yast2-network >= 4.2.55
+# Dropped Yast::LanItems
+BuildRequires:  yast2-network >= 4.4.7
 # Y2Packager::MediumType
 BuildRequires:  yast2-packager >= 4.2.27
 # for AbortException and handle direct abort
@@ -78,8 +78,8 @@
 # Language::GetLanguageItems and other API
 # Language::Set (handles downloading the translation extensions)
 Requires:       yast2-country-data >= 2.16.11
-# Y2Network::NtpServer
-Requires:       yast2-network >= 4.2.55
+# Dropped Yast::LanItems
+Requires:       yast2-network >= 4.4.7
 # Y2Packager::MediumType
 Requires:       yast2-packager >= 4.2.22
 # Pkg::ProvidePackage

++++++ yast2-installation-4.4.4.tar.bz2 -> yast2-installation-4.4.5.tar.bz2 
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-installation-4.4.4/package/yast2-installation.changes 
new/yast2-installation-4.4.5/package/yast2-installation.changes
--- old/yast2-installation-4.4.4/package/yast2-installation.changes     
2021-04-16 12:34:20.000000000 +0200
+++ new/yast2-installation-4.4.5/package/yast2-installation.changes     
2021-04-27 15:09:41.000000000 +0200
@@ -1,4 +1,10 @@
 -------------------------------------------------------------------
+Tue Apr 27 09:23:17 UTC 2021 - Knut Anderssen <kanders...@suse.com>
+
+- Remove Yast::LanItems dependency (bsc#1185338)
+- 4.4.5
+
+-------------------------------------------------------------------
 Fri Apr 16 10:19:04 UTC 2021 - Dirk M??ller <dmuel...@suse.com>
 
 - spec-cleaner part five out of five: sort and deduplicate requires
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-installation-4.4.4/package/yast2-installation.spec 
new/yast2-installation-4.4.5/package/yast2-installation.spec
--- old/yast2-installation-4.4.4/package/yast2-installation.spec        
2021-04-16 12:34:20.000000000 +0200
+++ new/yast2-installation-4.4.5/package/yast2-installation.spec        
2021-04-27 15:09:41.000000000 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-installation
-Version:        4.4.4
+Version:        4.4.5
 Release:        0
 Summary:        YaST2 - Installation Parts
 License:        GPL-2.0-only
@@ -37,8 +37,8 @@
 BuildRequires:  yast2-devtools >= 3.1.10
 # For firewall widgets
 BuildRequires:  yast2-firewall
-# Y2Network::NtpServer
-BuildRequires:  yast2-network >= 4.2.55
+# Dropped Yast::LanItems
+BuildRequires:  yast2-network >= 4.4.7
 # Y2Packager::MediumType
 BuildRequires:  yast2-packager >= 4.2.27
 # for AbortException and handle direct abort
@@ -78,8 +78,8 @@
 # Language::GetLanguageItems and other API
 # Language::Set (handles downloading the translation extensions)
 Requires:       yast2-country-data >= 2.16.11
-# Y2Network::NtpServer
-Requires:       yast2-network >= 4.2.55
+# Dropped Yast::LanItems
+Requires:       yast2-network >= 4.4.7
 # Y2Packager::MediumType
 Requires:       yast2-packager >= 4.2.22
 # Pkg::ProvidePackage
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-installation-4.4.4/src/lib/installation/dialogs/ntp_setup.rb 
new/yast2-installation-4.4.5/src/lib/installation/dialogs/ntp_setup.rb
--- old/yast2-installation-4.4.4/src/lib/installation/dialogs/ntp_setup.rb      
2021-04-16 12:34:20.000000000 +0200
+++ new/yast2-installation-4.4.5/src/lib/installation/dialogs/ntp_setup.rb      
2021-04-27 15:09:41.000000000 +0200
@@ -32,7 +32,6 @@
         textdomain "installation"
 
         Yast.import "Lan"
-        Yast.import "LanItems"
         Yast.import "Product"
         Yast.import "ProductFeatures"
 
@@ -68,28 +67,12 @@
       def ntp_servers
         # TODO: use Yast::NtpClient.ntp_conf if configured
         # to better handle going back
-        servers = dhcp_ntp_servers
+        servers = Yast::Lan.dhcp_ntp_servers
         servers = [ntp_fallback.hostname] if servers.empty? && 
default_ntp_setup_enabled?
 
         servers
       end
 
-      # List of NTP servers from DHCP
-      #
-      # @return [Array<String>] List of servers (IP or host names), empty if 
not provided
-      def dhcp_ntp_servers
-        # When proposing NTP servers we need to know
-        #
-        #   1) list of (dhcp) interfaces
-        #   2) network service in use
-        #
-        # We can either use networking submodule for network service handling 
and get list of
-        # interfaces e.g. using a bash command or initialize whole networking 
module.
-        Yast::Lan.ReadWithCacheNoGUI
-
-        Yast::LanItems.dhcp_ntp_servers.values.flatten.uniq
-      end
-
       # Whether the a default (fallback) NTP setup is enabled in the 
control.xml
       #
       # @return [Boolean]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-installation-4.4.4/test/lib/dialogs/ntp_setup_test.rb 
new/yast2-installation-4.4.5/test/lib/dialogs/ntp_setup_test.rb
--- old/yast2-installation-4.4.4/test/lib/dialogs/ntp_setup_test.rb     
2021-04-16 12:34:20.000000000 +0200
+++ new/yast2-installation-4.4.5/test/lib/dialogs/ntp_setup_test.rb     
2021-04-27 15:09:41.000000000 +0200
@@ -17,8 +17,7 @@
       allow(Yast::Wizard).to receive(:CreateDialog)
       allow(Yast::Wizard).to receive(:CloseDialog)
       allow(Yast::CWM).to receive(:show).and_return(:next)
-      allow(Yast::Lan).to receive(:ReadWithCacheNoGUI)
-      allow(Yast::LanItems).to receive(:dhcp_ntp_servers).and_return({})
+      allow(Yast::Lan).to receive(:dhcp_ntp_servers).and_return([])
       allow(Yast::ProductFeatures).to receive(:GetBooleanFeature)
     end
 
@@ -28,7 +27,7 @@
       let(:ntp_servers) { ["ntp.example.com"] }
 
       it "proposes to use it by default" do
-        expect(Yast::LanItems).to receive(:dhcp_ntp_servers).and_return("eth0" 
=> ntp_servers)
+        expect(Yast::Lan).to receive(:dhcp_ntp_servers).and_return(ntp_servers)
         expect(::Installation::Widgets::NtpServer).to receive(:new)
           .with(ntp_servers).and_call_original
         subject.run

Reply via email to