Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libstorage-ng for openSUSE:Factory checked in at 2026-04-18 21:30:11 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libstorage-ng (Old) and /work/SRC/openSUSE:Factory/.libstorage-ng.new.11940 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libstorage-ng" Sat Apr 18 21:30:11 2026 rev:335 rq:1347657 version:4.5.313 Changes: -------- --- /work/SRC/openSUSE:Factory/libstorage-ng/libstorage-ng.changes 2026-04-16 17:25:40.504233958 +0200 +++ /work/SRC/openSUSE:Factory/.libstorage-ng.new.11940/libstorage-ng.changes 2026-04-18 21:30:21.674903744 +0200 @@ -1,0 +2,7 @@ +Fri Apr 17 08:12:54 UTC 2026 - [email protected] + +- merge gh#openSUSE/libstorage-ng#1068 +- removed redundant device lookup +- 4.5.313 + +-------------------------------------------------------------------- Old: ---- libstorage-ng-4.5.312.tar.xz New: ---- libstorage-ng-4.5.313.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libstorage-ng.spec ++++++ --- /var/tmp/diff_new_pack.Nv5plM/_old 2026-04-18 21:30:22.526937916 +0200 +++ /var/tmp/diff_new_pack.Nv5plM/_new 2026-04-18 21:30:22.530938076 +0200 @@ -18,7 +18,7 @@ %define libname %{name}1 Name: libstorage-ng -Version: 4.5.312 +Version: 4.5.313 Release: 0 Summary: Library for storage management License: GPL-2.0-only ++++++ libstorage-ng-4.5.312.tar.xz -> libstorage-ng-4.5.313.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/VERSION new/libstorage-ng-4.5.313/VERSION --- old/libstorage-ng-4.5.312/VERSION 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/VERSION 2026-04-17 10:12:54.000000000 +0200 @@ -1 +1 @@ -4.5.312 +4.5.313 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/storage/Devices/PartitionImpl.cc new/libstorage-ng-4.5.313/storage/Devices/PartitionImpl.cc --- old/libstorage-ng-4.5.312/storage/Devices/PartitionImpl.cc 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/storage/Devices/PartitionImpl.cc 2026-04-17 10:12:54.000000000 +0200 @@ -277,9 +277,12 @@ if (!label.empty()) { - if ((spec == "PARTLABEL=" + label) || - (spec == DEV_DISK_BY_PARTLABEL_DIR "/" + udev_encode(label))) + if (spec == "PARTLABEL=" + label) return true; + + // No check for /dev/disk/by-partlabel since 1. it would be redundant as there + // is a check later for major and minor number and 2. udev encoding is not + // documented. } return BlkDevice::Impl::spec_match(system_info, spec); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/storage/EtcCrypttab.cc new/libstorage-ng-4.5.313/storage/EtcCrypttab.cc --- old/libstorage-ng-4.5.312/storage/EtcCrypttab.cc 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/storage/EtcCrypttab.cc 2026-04-17 10:12:54.000000000 +0200 @@ -242,8 +242,9 @@ if (blk_device == "LABEL=" + label) return entry; - if (blk_device == DEV_DISK_BY_LABEL_DIR "/" + udev_encode(label)) - return entry; + // No check for /dev/disk/by-label since 1. it would be redundant as there + // is a check later for major and minor number and 2. udev encoding is not + // documented. } if (boost::starts_with(blk_device, DEV_DIR "/")) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/storage/Filesystems/BlkFilesystemImpl.cc new/libstorage-ng-4.5.313/storage/Filesystems/BlkFilesystemImpl.cc --- old/libstorage-ng-4.5.312/storage/Filesystems/BlkFilesystemImpl.cc 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/storage/Filesystems/BlkFilesystemImpl.cc 2026-04-17 10:12:54.000000000 +0200 @@ -730,9 +730,12 @@ if (!label.empty()) { - if ((spec == "LABEL=" + label) || - (spec == DEV_DISK_BY_LABEL_DIR "/" + udev_encode(label))) + if (spec == "LABEL=" + label) return true; + + // No check for /dev/disk/by-label since 1. it would be redundant as there is + // a check later for major and minor number and 2. udev encoding is not + // documented. } return false; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/storage/Utils/Udev.cc new/libstorage-ng-4.5.313/storage/Utils/Udev.cc --- old/libstorage-ng-4.5.312/storage/Utils/Udev.cc 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/storage/Utils/Udev.cc 2026-04-17 10:12:54.000000000 +0200 @@ -29,54 +29,6 @@ namespace storage { - string - udev_encode(const string& s) - { - string r = s; - - string::size_type pos = 0; - - while (true) - { - pos = r.find_first_of(" '\\/$", pos); - if (pos == string::npos) - break; - - char tmp[16]; - sprintf(tmp, "\\x%02x", r[pos]); - r.replace(pos, 1, tmp); - - pos += 4; - } - - return r; - } - - - string - udev_decode(const string& s) - { - string r = s; - - string::size_type pos = 0; - - while (true) - { - pos = r.find("\\x", pos); - if (pos == string::npos || pos > r.size() - 4) - break; - - unsigned int tmp; - if (sscanf(r.substr(pos + 2, 2).c_str(), "%x", &tmp) == 1) - r.replace(pos, 4, 1, (char) tmp); - - pos += 1; - } - - return r; - } - - void udev_settle() { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/storage/Utils/Udev.h new/libstorage-ng-4.5.313/storage/Utils/Udev.h --- old/libstorage-ng-4.5.312/storage/Utils/Udev.h 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/storage/Utils/Udev.h 2026-04-17 10:12:54.000000000 +0200 @@ -33,9 +33,6 @@ using std::string; - string udev_encode(const string&); - string udev_decode(const string&); - void udev_settle(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/testsuite/Utils/Makefile.am new/libstorage-ng-4.5.313/testsuite/Utils/Makefile.am --- old/libstorage-ng-4.5.312/testsuite/Utils/Makefile.am 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/testsuite/Utils/Makefile.am 2026-04-17 10:12:54.000000000 +0200 @@ -6,7 +6,7 @@ LDADD = ../../storage/libstorage-ng.la -lboost_unit_test_framework -check_PROGRAMS = enum.test udev-encoding.test humanstring.test region.test \ +check_PROGRAMS = enum.test humanstring.test region.test \ exception.test topology.test alignment.test math.test systemcmd.test \ dirname.test basename.test algorithm.test format.test join.test \ regex.test sort-by.test jsonfile.test rootprefix.test \ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.312/testsuite/Utils/udev-encoding.cc new/libstorage-ng-4.5.313/testsuite/Utils/udev-encoding.cc --- old/libstorage-ng-4.5.312/testsuite/Utils/udev-encoding.cc 2026-04-15 14:16:57.000000000 +0200 +++ new/libstorage-ng-4.5.313/testsuite/Utils/udev-encoding.cc 1970-01-01 01:00:00.000000000 +0100 @@ -1,43 +0,0 @@ - -#define BOOST_TEST_DYN_LINK -#define BOOST_TEST_MODULE libstorage - -#include <boost/test/unit_test.hpp> - -#include "storage/Utils/Udev.h" - - -using namespace std; -using namespace storage; - - -BOOST_AUTO_TEST_CASE(test_udev_encode) -{ - BOOST_CHECK_EQUAL(udev_encode("nothing"), "nothing"); - - BOOST_CHECK_EQUAL(udev_encode("hello world"), "hello\\x20world"); - BOOST_CHECK_EQUAL(udev_encode("hello world"), "hello\\x20\\x20world"); - - BOOST_CHECK_EQUAL(udev_encode(" beginning"), "\\x20beginning"); - BOOST_CHECK_EQUAL(udev_encode("ending "), "ending\\x20"); - - BOOST_CHECK_EQUAL(udev_encode("woody's"), "woody\\x27s"); - - BOOST_CHECK_EQUAL(udev_encode("A/B image"), "A\\x2fB\\x20image"); - - BOOST_CHECK_EQUAL(udev_encode("schön"), "schön"); -} - - -BOOST_AUTO_TEST_CASE(test_udev_decode) -{ - BOOST_CHECK_EQUAL(udev_decode("nothing"), "nothing"); - - BOOST_CHECK_EQUAL(udev_decode("hello\\x20world"), "hello world"); - BOOST_CHECK_EQUAL(udev_decode("hello\\x20\\x20world"), "hello world"); - - BOOST_CHECK_EQUAL(udev_decode("\\x20beginning"), " beginning"); - BOOST_CHECK_EQUAL(udev_decode("ending\\x20"), "ending "); - - BOOST_CHECK_EQUAL(udev_decode("woody\\x27s"), "woody's"); -}
