Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package expect for openSUSE:Factory checked
in at 2021-05-06 22:51:31
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/expect (Old)
and /work/SRC/openSUSE:Factory/.expect.new.2988 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "expect"
Thu May 6 22:51:31 2021 rev:29 rq:890332 version:5.45.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/expect/expect.changes 2020-10-18
16:18:09.756403800 +0200
+++ /work/SRC/openSUSE:Factory/.expect.new.2988/expect.changes 2021-05-06
22:51:31.843020843 +0200
@@ -1,0 +2,18 @@
+Tue May 4 11:02:42 UTC 2021 - Matthias Gerstner <matthias.gerst...@suse.com>
+
+- fix previous change regarding PIE linking. Passing SHLIB_CFLAGS="-shared"
+ causes /usr/bin/expect to become a shared library that SEGFAULTs upon
+ execution. Instead use SHLIB_LD to pass -shared only to shared library
+ linking.
+
+-------------------------------------------------------------------
+Wed Apr 21 13:13:28 UTC 2021 - Matthias Gerstner <matthias.gerst...@suse.com>
+
+- pass explicit -pie flag to CFLAGS and hack `make` invocation so that
+ /usr/bin/expect actually becomes a PIE binary. This is especially awkard
+ since the expect build system implicitly passes -fPIC which breaks our
+ gcc-PIE package, but does not pass -pie while linking the executable.
+ Shared libraries are also not linked with -shared so we need to explicitly
+ pass this, too, to avoid build breakage (bsc#1184122).
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ expect.spec ++++++
--- /var/tmp/diff_new_pack.5J1Sst/_old 2021-05-06 22:51:32.991016109 +0200
+++ /var/tmp/diff_new_pack.5J1Sst/_new 2021-05-06 22:51:32.995016093 +0200
@@ -1,7 +1,7 @@
#
# spec file for package expect
#
-# Copyright (c) 2020 SUSE LLC
+# Copyright (c) 2021 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -59,13 +59,14 @@
%patch4
%build
+export CFLAGS="%{optflags} -fPIC -pie"
autoreconf
%configure \
--with-tcl=%_libdir \
--with-tk=no_tk \
--with-tclinclude=%_includedir \
--enable-shared
-make %{?_smp_mflags} all pkglibdir=%_libdir/tcl/%name%version
+make SHLIB_LD="gcc -shared" %{?_smp_mflags} all
pkglibdir=%_libdir/tcl/%name%version
%check
make %{?_smp_mflags} test
