Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package openQA for openSUSE:Factory checked in at 2026-05-05 15:14:55 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/openQA (Old) and /work/SRC/openSUSE:Factory/.openQA.new.30200 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "openQA" Tue May 5 15:14:55 2026 rev:843 rq:1350708 version:5.1777888278.38a3a85c Changes: -------- --- /work/SRC/openSUSE:Factory/openQA/openQA.changes 2026-05-04 12:53:59.818664554 +0200 +++ /work/SRC/openSUSE:Factory/.openQA.new.30200/openQA.changes 2026-05-05 15:16:03.780903051 +0200 @@ -1,0 +2,7 @@ +Mon May 04 11:54:48 UTC 2026 - [email protected] + +- Update to version 5.1777888278.38a3a85c: + * style: Enforce perlcritic policy ProhibitUselessTopic + * style: Enforce perlcritic policy BuiltinFunctions::RequireBlockGrep + +------------------------------------------------------------------- Old: ---- openQA-5.1777617029.fd9e1e69.obscpio New: ---- openQA-5.1777888278.38a3a85c.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ openQA-client-test.spec ++++++ --- /var/tmp/diff_new_pack.fj11GR/_old 2026-05-05 15:16:04.896948747 +0200 +++ /var/tmp/diff_new_pack.fj11GR/_new 2026-05-05 15:16:04.900948902 +0200 @@ -18,7 +18,7 @@ %define short_name openQA-client Name: %{short_name}-test -Version: 5.1777617029.fd9e1e69 +Version: 5.1777888278.38a3a85c Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ openQA-devel-test.spec ++++++ --- /var/tmp/diff_new_pack.fj11GR/_old 2026-05-05 15:16:04.928949989 +0200 +++ /var/tmp/diff_new_pack.fj11GR/_new 2026-05-05 15:16:04.928949989 +0200 @@ -18,7 +18,7 @@ %define short_name openQA-devel Name: %{short_name}-test -Version: 5.1777617029.fd9e1e69 +Version: 5.1777888278.38a3a85c Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ openQA-test.spec ++++++ --- /var/tmp/diff_new_pack.fj11GR/_old 2026-05-05 15:16:04.964951385 +0200 +++ /var/tmp/diff_new_pack.fj11GR/_new 2026-05-05 15:16:04.968951541 +0200 @@ -18,7 +18,7 @@ %define short_name openQA Name: %{short_name}-test -Version: 5.1777617029.fd9e1e69 +Version: 5.1777888278.38a3a85c Release: 0 Summary: Test package for openQA License: GPL-2.0-or-later ++++++ openQA-worker-test.spec ++++++ --- /var/tmp/diff_new_pack.fj11GR/_old 2026-05-05 15:16:05.000952783 +0200 +++ /var/tmp/diff_new_pack.fj11GR/_new 2026-05-05 15:16:05.004952937 +0200 @@ -18,7 +18,7 @@ %define short_name openQA-worker Name: %{short_name}-test -Version: 5.1777617029.fd9e1e69 +Version: 5.1777888278.38a3a85c Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ openQA.spec ++++++ --- /var/tmp/diff_new_pack.fj11GR/_old 2026-05-05 15:16:05.040954335 +0200 +++ /var/tmp/diff_new_pack.fj11GR/_new 2026-05-05 15:16:05.040954335 +0200 @@ -99,7 +99,7 @@ %define devel_requires %devel_no_selenium_requires chromedriver Name: openQA -Version: 5.1777617029.fd9e1e69 +Version: 5.1777888278.38a3a85c Release: 0 Summary: The openQA web-frontend, scheduler and tools License: GPL-2.0-or-later ++++++ openQA-5.1777617029.fd9e1e69.obscpio -> openQA-5.1777888278.38a3a85c.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/.perlcriticrc new/openQA-5.1777888278.38a3a85c/.perlcriticrc --- old/openQA-5.1777617029.fd9e1e69/.perlcriticrc 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/.perlcriticrc 2026-05-04 11:51:18.000000000 +0200 @@ -1,6 +1,6 @@ theme = community + openqa severity = 4 -include = strict ValuesAndExpressions::ProhibitInterpolationOfLiterals CodeLayout::ProhibitParensWithBuiltins BuiltinFunctions::RequireBlockMap BuiltinFunctions::ProhibitStringySplit ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions ValuesAndExpressions::RequireQuotedHeredocTerminator Variables::ProhibitUnusedVariables ValuesAndExpressions::RequireNumberSeparators CodeLayout::ProhibitQuotedWordLists RegularExpressions::ProhibitSingleCharAlternation +include = strict ValuesAndExpressions::ProhibitInterpolationOfLiterals CodeLayout::ProhibitParensWithBuiltins BuiltinFunctions::RequireBlockMap BuiltinFunctions::ProhibitStringySplit ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions ValuesAndExpressions::RequireQuotedHeredocTerminator Variables::ProhibitUnusedVariables ValuesAndExpressions::RequireNumberSeparators CodeLayout::ProhibitQuotedWordLists RegularExpressions::ProhibitSingleCharAlternation BuiltinFunctions::RequireBlockGrep RegularExpressions::ProhibitUselessTopic # ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions # No operators like < =~ ! allowed in 'unless' or 'until', only simple diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Log.pm new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Log.pm --- old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Log.pm 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Log.pm 2026-05-04 11:51:18.000000000 +0200 @@ -211,7 +211,7 @@ } sub redact_settings ($vars) { - return {map { $_ !~ qr/(^_SECRET_|_PASSWORD)/ ? ($_ => $vars->{$_}) : ($_ => '[redacted]') } keys %$vars}; + return {map { m/(^_SECRET_|_PASSWORD)/ ? ($_ => '[redacted]') : ($_ => $vars->{$_}) } keys %$vars}; } sub redact_settings_in_file ($file) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Schema/Result/ScheduledProducts.pm new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Schema/Result/ScheduledProducts.pm --- old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Schema/Result/ScheduledProducts.pm 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Schema/Result/ScheduledProducts.pm 2026-05-04 11:51:18.000000000 +0200 @@ -464,8 +464,8 @@ sub _parse_dep_variable ($value, $job_settings) { return unless defined $value; return map { - if ($_ =~ /^(.+)\@([^@]+)$/) { [$1, $2] } - elsif ($_ =~ /^(.+):([^:]+)$/) { [$1, $2] } # for backwards compatibility + if (m/^(.+)\@([^@]+)$/) { [$1, $2] } + elsif (m/^(.+):([^:]+)$/) { [$1, $2] } # for backwards compatibility else { [$_, $job_settings->{MACHINE}] } } split /\s*,\s*/, $value; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Schema/ResultSet/Jobs.pm new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Schema/ResultSet/Jobs.pm --- old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Schema/ResultSet/Jobs.pm 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Schema/ResultSet/Jobs.pm 2026-05-04 11:51:18.000000000 +0200 @@ -136,7 +136,7 @@ my %settings = %$settings; my %new_job_args; - my @invalid_keys = grep { $_ =~ /^(PUBLISH_HDD|FORCE_PUBLISH_HDD|STORE_HDD)\S+(\d+)$/ && $settings{$_} =~ /\// } + my @invalid_keys = grep { /^(PUBLISH_HDD|FORCE_PUBLISH_HDD|STORE_HDD)\S+(\d+)$/ && $settings{$_} =~ /\// } keys %settings; die 'The ' . join(',', @invalid_keys) . " cannot include / in value\n" if @invalid_keys; @@ -338,7 +338,7 @@ my $stderr; IPC::Run::run(\@cmd, \undef, \$stdout, \$stderr); next if $stderr; - push @results, map { $_ =~ s/\..*$//; basename $_ } split /\n/, $stdout; + push @results, map { s/\..*$//; basename $_ } split /\n/, $stdout; } return \@results; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Setup.pm new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Setup.pm --- old/openQA-5.1777617029.fd9e1e69/lib/OpenQA/Setup.pm 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/lib/OpenQA/Setup.pm 2026-05-04 11:51:18.000000000 +0200 @@ -71,7 +71,7 @@ $app->log->warn("Wrong format in openqa.ini 'prio_throttling_parameters': $throttling"); return; } - my %hash = map { my ($k, $s, $r) = $_ =~ /$u/g; $k => {scale => $s, reference => $r // 0} } + my %hash = map { my ($k, $s, $r) = /$u/g; $k => {scale => $s, reference => $r // 0} } split /,/, $throttling; return \%hash; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/t/10-jobs.t new/openQA-5.1777888278.38a3a85c/t/10-jobs.t --- old/openQA-5.1777617029.fd9e1e69/t/10-jobs.t 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/t/10-jobs.t 2026-05-04 11:51:18.000000000 +0200 @@ -82,15 +82,15 @@ my $ids = $jobs->complex_query_latest_ids; # These two jobs have later clones in the fixture set, so should not appear - ok grep(!/^(99962|99945)$/, @$ids), 'jobs with later clones do not show up in latest jobs'; + ok + (grep { !/^(99962|99945)$/ } @$ids), 'jobs with later clones do not show up in latest jobs'; # These are the later clones, they should appear - ok grep(/^99963$/, @$ids), 'cloned jobs appear as latest job'; - ok grep(/^99946$/, @$ids), 'cloned jobs appear as latest job (2nd)'; + ok + (grep { /^99963$/ } @$ids), 'cloned jobs appear as latest job'; + ok + (grep { /^99946$/ } @$ids), 'cloned jobs appear as latest job (2nd)'; my $filtered_ids = $jobs->complex_query_latest_ids(filters => [{result => {-in => [FAILED, PASSED]}}]); - ok grep(!/^(99962|99945)$/, @$filtered_ids), 'jobs with later clones still not present'; - ok grep(/^99946$/, @$filtered_ids), 'failed/passed job still returned'; - ok grep(!/^99963$/, @$filtered_ids), 'running job filtered out'; + ok + (grep { !/^(99962|99945)$/ } @$filtered_ids), 'jobs with later clones still not present'; + ok + (grep { /^99946$/ } @$filtered_ids), 'failed/passed job still returned'; + ok + (grep { !/^99963$/ } @$filtered_ids), 'running job filtered out'; }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/t/14-grutasks-git.t new/openQA-5.1777888278.38a3a85c/t/14-grutasks-git.t --- old/openQA-5.1777617029.fd9e1e69/t/14-grutasks-git.t 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/t/14-grutasks-git.t 2026-05-04 11:51:18.000000000 +0200 @@ -461,7 +461,7 @@ $openqa_git->redefine( run_cmd_with_log_return_error => sub ($cmd, %args) { push @cmds, "@$cmd"; - if (grep m/push/, @$cmd) { + if (grep { m/push/ } @$cmd) { return { status => 0, return_code => 128, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/t/16-utils.t new/openQA-5.1777888278.38a3a85c/t/16-utils.t --- old/openQA-5.1777617029.fd9e1e69/t/16-utils.t 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/t/16-utils.t 2026-05-04 11:51:18.000000000 +0200 @@ -287,12 +287,12 @@ is path_to_class('foo/bar.pm'), 'foo::bar'; is path_to_class('foo/bar/baz.pm'), 'foo::bar::baz'; - ok grep('OpenQA::Utils', loaded_modules), 'Can detect loaded modules'; - ok grep('Test::Most', loaded_modules), 'Can detect loaded modules'; + ok + (grep { $_ eq 'OpenQA::Utils' } loaded_modules), 'Can detect loaded modules'; + ok + (grep { $_ eq 'Test::Most' } loaded_modules), 'Can detect loaded modules'; is_deeply [loaded_plugins('OpenQA::Utils', 'Test::Most')], ['OpenQA::Utils', 'Test::Most', 'Test::Most::Exception'], 'Can detect loaded plugins, filtering by namespace'; - ok grep('Test::Most', loaded_plugins), + ok + (grep { $_ eq 'Test::Most' } loaded_plugins), 'loaded_plugins() behave like loaded_modules() when no arguments are supplied'; my $test_hash = { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/t/30-test_parser.t new/openQA-5.1777888278.38a3a85c/t/30-test_parser.t --- old/openQA-5.1777617029.fd9e1e69/t/30-test_parser.t 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/t/30-test_parser.t 2026-05-04 11:51:18.000000000 +0200 @@ -405,7 +405,7 @@ $testdir->list_tree->each( sub { fail 'json result: filename expected to be like result-\d_.*\.json but is ' . $_ - unless $_ =~ qr/result-\d_.*\.json/; + unless m/result-\d_.*\.json/; my $res = decode_json $_->slurp; is ref $res, 'HASH', 'json result: can be decoded' or always_explain $_->slurp; fail 'json result: exists $res->{result}' unless exists $res->{result}; @@ -488,7 +488,7 @@ $testdir->list_tree->each( sub { fail 'json result: filename expected to be like result-.*\.json but is ' . $_ - unless $_ =~ qr/result-.*\.json/; + unless m/result-.*\.json/; my $res = decode_json $_->slurp; is ref $res, 'HASH', 'json result: can be decoded' or always_explain $_->slurp; fail 'json result: exists $res->{result}' unless exists $res->{result}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/t/37-limit_assets.t new/openQA-5.1777888278.38a3a85c/t/37-limit_assets.t --- old/openQA-5.1777617029.fd9e1e69/t/37-limit_assets.t 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/t/37-limit_assets.t 2026-05-04 11:51:18.000000000 +0200 @@ -368,13 +368,13 @@ # Assets here include non-iso in iso, files in other, CURRENT repos for my $name (qw(iso/whatever.sha256 other/misc.xml repo/otherrepo-CURRENT)) { ok -e assetdir() . '/' . $name, "$name exists in the test folder"; - ok grep(/$name$/, @tracked_assets), "$name picked up for cleanup" + ok + (grep { /$name$/ } @tracked_assets), "$name picked up for cleanup" || always_explain join ' ', sort @tracked_assets; } # Ignored assets include repo links, file links for my $name (qw(repo/somethingrepo other/misc2.xml)) { ok -e assetdir() . '/' . $name, "$name exists in the test folder"; - ok !grep(/$name$/, @tracked_assets), "$name ignored" || always_explain join ' ', sort @tracked_assets; + ok !(grep { /$name$/ } @tracked_assets), "$name ignored" || always_explain join ' ', sort @tracked_assets; } }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/openQA-5.1777617029.fd9e1e69/t/compile/01-compile-check-all.t new/openQA-5.1777888278.38a3a85c/t/compile/01-compile-check-all.t --- old/openQA-5.1777617029.fd9e1e69/t/compile/01-compile-check-all.t 2026-05-01 08:30:29.000000000 +0200 +++ new/openQA-5.1777888278.38a3a85c/t/compile/01-compile-check-all.t 2026-05-04 11:51:18.000000000 +0200 @@ -37,7 +37,7 @@ chomp @all_git_files; my %skip = map { $_ => undef } @$SKIP; @files = map { $root . $_ } - grep { !-l $_ && !exists $skip{$_} && $_ !~ /^(external|t|xt)\// } @all_git_files; # Exclude files to skip + grep { !-l $_ && !exists $skip{$_} && !/^(external|t|xt)\// } @all_git_files; # Exclude files to skip } else { @files = ($test->all_pm_files('lib'), $test->all_pl_files('script')); ++++++ openQA.obsinfo ++++++ --- /var/tmp/diff_new_pack.fj11GR/_old 2026-05-05 15:16:23.517682128 +0200 +++ /var/tmp/diff_new_pack.fj11GR/_new 2026-05-05 15:16:23.525682460 +0200 @@ -1,5 +1,5 @@ name: openQA -version: 5.1777617029.fd9e1e69 -mtime: 1777617029 -commit: fd9e1e6944c531b90a4edef6a15954e3390a1a3d +version: 5.1777888278.38a3a85c +mtime: 1777888278 +commit: 38a3a85c92a8473b9eb1fe3472cea5faa9e06263
