Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libmp4tag for openSUSE:Factory checked in at 2026-05-10 16:48:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libmp4tag (Old) and /work/SRC/openSUSE:Factory/.libmp4tag.new.1966 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libmp4tag" Sun May 10 16:48:06 2026 rev:5 rq:1352222 version:2.0.4 Changes: -------- --- /work/SRC/openSUSE:Factory/libmp4tag/libmp4tag.changes 2026-05-09 13:00:21.674434921 +0200 +++ /work/SRC/openSUSE:Factory/.libmp4tag.new.1966/libmp4tag.changes 2026-05-10 16:48:39.537600982 +0200 @@ -1,0 +2,7 @@ +Sat May 9 19:47:11 UTC 2026 - Andreas Stieger <[email protected]> + +- update to 2.0.4: + * fix warnings with modern compilers +- drop libmp4tag-2.0.3-fix-discarded-const-qualifier.patch + +------------------------------------------------------------------- Old: ---- libmp4tag-2.0.3-fix-discarded-const-qualifier.patch libmp4tag-src-2.0.3.tar.gz New: ---- libmp4tag-src-2.0.4.tar.gz ----------(Old B)---------- Old: * fix warnings with modern compilers - drop libmp4tag-2.0.3-fix-discarded-const-qualifier.patch ----------(Old E)---------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libmp4tag.spec ++++++ --- /var/tmp/diff_new_pack.NYKXSt/_old 2026-05-10 16:48:40.013620464 +0200 +++ /var/tmp/diff_new_pack.NYKXSt/_new 2026-05-10 16:48:40.017620627 +0200 @@ -18,13 +18,12 @@ %define sover 2 Name: libmp4tag -Version: 2.0.3 +Version: 2.0.4 Release: 0 Summary: MP4 tagging library License: Zlib URL: https://libmp4tag.sourceforge.io/ Source: https://sourceforge.net/projects/libmp4tag/files/%{name}-src-%{version}.tar.gz -Patch0: libmp4tag-2.0.3-fix-discarded-const-qualifier.patch BuildRequires: c++_compiler BuildRequires: cmake >= 3.18 ++++++ libmp4tag-src-2.0.3.tar.gz -> libmp4tag-src-2.0.4.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/CMakeLists.txt new/libmp4tag-2.0.4/CMakeLists.txt --- old/libmp4tag-2.0.3/CMakeLists.txt 2026-02-08 15:07:33.000000000 +0100 +++ new/libmp4tag-2.0.4/CMakeLists.txt 2026-05-09 19:27:44.000000000 +0200 @@ -149,6 +149,10 @@ checkAddCompileNegFlag ("-Wno-documentation-unknown-command") checkAddCompileNegFlag ("-Wno-documentation") +# I am not seeing the warnings this is supposed to generate, though +# other users are. +checkAddCompileFlag ("-Wdiscarded-qualifiers") + #### build compile options if (NOT DEFINED LIBMP4TAG_BUILD OR LIBMP4TAG_BUILD STREQUAL "") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/Makefile new/libmp4tag-2.0.4/Makefile --- old/libmp4tag-2.0.3/Makefile 2025-10-27 13:21:34.000000000 +0100 +++ new/libmp4tag-2.0.4/Makefile 2026-05-09 18:11:57.000000000 +0200 @@ -9,6 +9,7 @@ CLANG = clang LOCTMP = tmp SRCFLAG = $(LOCTMP)/source.txt +CMAKE = cmake .PHONY: release release: @@ -84,7 +85,7 @@ .PHONY: cmake-unix cmake-unix: @if [ "$(PREFIX)" = "" ]; then echo "No prefix set"; exit 1; fi - cmake \ + $(CMAKE) \ -DCMAKE_C_COMPILER=$(CC) \ -DCMAKE_INSTALL_PREFIX="$(PREFIX)" \ -DLIBMP4TAG_BUILD:STATIC=$(LIBMP4TAG_BUILD) \ @@ -94,7 +95,7 @@ .PHONY: cmake-windows cmake-windows: @if [ "$(PREFIX)" = "" ]; then echo "No prefix set"; exit 1; fi - cmake \ + $(CMAKE) \ -DCMAKE_C_COMPILER=$(CC) \ -DCMAKE_INSTALL_PREFIX="$(PREFIX)" \ -DLIBMP4TAG_BUILD:STATIC=$(LIBMP4TAG_BUILD) \ @@ -106,11 +107,11 @@ # --parallel also seems to not work on *BSD .PHONY: build build: - cmake --build $(BUILDDIR) $(pmode) + $(CMAKE) --build $(BUILDDIR) $(pmode) .PHONY: install install: - cmake --install $(BUILDDIR) + $(CMAKE) --install $(BUILDDIR) # source diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/README.md new/libmp4tag-2.0.4/README.md --- old/libmp4tag-2.0.3/README.md 2025-10-27 13:23:07.000000000 +0100 +++ new/libmp4tag-2.0.4/README.md 2026-05-09 18:54:01.000000000 +0200 @@ -127,7 +127,7 @@ Setting multiple tags: - mp4tagcli filename.m4a nam=My-Title gnr=Country + mp4tagcli filename.m4a nam=My-Title gen=Country Setting a custom tag: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/VERSION.txt new/libmp4tag-2.0.4/VERSION.txt --- old/libmp4tag-2.0.3/VERSION.txt 2026-02-08 14:45:08.000000000 +0100 +++ new/libmp4tag-2.0.4/VERSION.txt 2026-05-09 17:55:38.000000000 +0200 @@ -1,2 +1,2 @@ -LIBMP4TAG_VERSION=2.0.3 +LIBMP4TAG_VERSION=2.0.4 export LIBMP4TAG_VERSION diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/libmp4tag.c new/libmp4tag-2.0.4/libmp4tag.c --- old/libmp4tag-2.0.3/libmp4tag.c 2026-02-08 14:44:44.000000000 +0100 +++ new/libmp4tag-2.0.4/libmp4tag.c 2026-05-09 18:43:47.000000000 +0200 @@ -63,7 +63,7 @@ static void enable_core_dump (void); #endif -NODISCARD +LIBMP4TAG_NODISCARD libmp4tag_t * mp4tag_open (const char *fn, int *mp4error) { @@ -122,7 +122,7 @@ return libmp4tag; } -NODISCARD +LIBMP4TAG_NODISCARD libmp4tag_t * mp4tag_openstream (mp4tag_readcb_t readcb, mp4tag_seekcb_t seekcb, void *userdata, uint32_t timeout, int *mp4error) @@ -235,7 +235,7 @@ free (libmp4tag); } -NODISCARD +LIBMP4TAG_NODISCARD int64_t mp4tag_duration (libmp4tag_t *libmp4tag) { @@ -623,7 +623,7 @@ return rc; } -NODISCARD +LIBMP4TAG_NODISCARD libmp4tagpreserve_t * mp4tag_preserve_tags (libmp4tag_t *libmp4tag) { @@ -739,14 +739,14 @@ return libmp4tag->mp4error; } -NODISCARD +LIBMP4TAG_NODISCARD const char * mp4tag_version (void) { return LIBMP4TAG_VERSION; } -NODISCARD +LIBMP4TAG_NODISCARD const char * mp4tag_error_str (libmp4tag_t *libmp4tag) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/libmp4tag.h.in new/libmp4tag-2.0.4/libmp4tag.h.in --- old/libmp4tag-2.0.3/libmp4tag.h.in 2026-02-08 14:27:26.000000000 +0100 +++ new/libmp4tag-2.0.4/libmp4tag.h.in 2026-05-09 18:43:47.000000000 +0200 @@ -10,15 +10,15 @@ #include <stdio.h> #if __STDC_VERSION__ < 202000 -# undef NODISCARD -# define NODISCARD __attribute__ ((warn_unused_result)) +# undef LIBMP4TAG_NODISCARD +# define LIBMP4TAG_NODISCARD __attribute__ ((warn_unused_result)) #endif #if __STDC_VERSION__ >= 202000 -# undef NODISCARD -# define NODISCARD [[nodiscard]] +# undef LIBMP4TAG_NODISCARD +# define LIBMP4TAG_NODISCARD [[nodiscard]] #endif -#if ! defined (NODISCARD) -# define NODISCARD +#if ! defined (LIBMP4TAG_NODISCARD) +# define LIBMP4TAG_NODISCARD #endif #if defined (__cplusplus) || defined (c_plusplus) @@ -96,12 +96,12 @@ MP4TAG_COVER_PNG = 0x0e, }; -NODISCARD libmp4tag_t * mp4tag_open (const char *fn, int *mp4error); -NODISCARD libmp4tag_t * mp4tag_openstream (mp4tag_readcb_t readcb, mp4tag_seekcb_t seekcb, void *userdata, uint32_t timeout, int *mp4error); +LIBMP4TAG_NODISCARD libmp4tag_t * mp4tag_open (const char *fn, int *mp4error); +LIBMP4TAG_NODISCARD libmp4tag_t * mp4tag_openstream (mp4tag_readcb_t readcb, mp4tag_seekcb_t seekcb, void *userdata, uint32_t timeout, int *mp4error); int mp4tag_parse (libmp4tag_t *libmp4tag); void mp4tag_free (libmp4tag_t *libmp4tag); -NODISCARD int64_t mp4tag_duration (libmp4tag_t *libmp4tag); +LIBMP4TAG_NODISCARD int64_t mp4tag_duration (libmp4tag_t *libmp4tag); int mp4tag_get_tag_by_name (libmp4tag_t *libmp4tag, const char *tag, mp4tagpub_t *mp4tagpub); int mp4tag_iterate_init (libmp4tag_t *libmp4tag); int mp4tag_iterate (libmp4tag_t *libmp4tag, mp4tagpub_t *mp4tagpub); @@ -113,13 +113,13 @@ int mp4tag_write_tags (libmp4tag_t *libmp4tag); -NODISCARD libmp4tagpreserve_t *mp4tag_preserve_tags (libmp4tag_t *libmp4tag); +LIBMP4TAG_NODISCARD libmp4tagpreserve_t *mp4tag_preserve_tags (libmp4tag_t *libmp4tag); int mp4tag_restore_tags (libmp4tag_t *libmp4tag, libmp4tagpreserve_t *preserve); int mp4tag_preserve_free (libmp4tagpreserve_t *preserve); int mp4tag_error (libmp4tag_t *libmp4tag); -NODISCARD const char * mp4tag_version (void); -NODISCARD const char * mp4tag_error_str (libmp4tag_t *libmp4tag); +LIBMP4TAG_NODISCARD const char * mp4tag_version (void); +LIBMP4TAG_NODISCARD const char * mp4tag_error_str (libmp4tag_t *libmp4tag); void mp4tag_set_debug_flags (libmp4tag_t *libmp4tag, int dbgflags); void mp4tag_set_free_space (libmp4tag_t *libmp4tag, int32_t freespacesz); void mp4tag_set_option (libmp4tag_t *libmp4tag, int option); @@ -132,17 +132,17 @@ /* public file interface helper routines */ /* these routines are useful for the application */ -NODISCARD FILE * mp4tag_fopen (const char *fn, const char *mode); -NODISCARD ssize_t mp4tag_file_size (const char *fn); -NODISCARD char * mp4tag_read_file (const char *fn, size_t *sz, int *mp4error); +LIBMP4TAG_NODISCARD FILE * mp4tag_fopen (const char *fn, const char *mode); +LIBMP4TAG_NODISCARD ssize_t mp4tag_file_size (const char *fn); +LIBMP4TAG_NODISCARD char * mp4tag_read_file (const char *fn, size_t *sz, int *mp4error); int mp4tag_file_delete (const char *fname); int mp4tag_file_move (const char *fname, const char *nfn); void mp4tag_copy_file_times (FILE *ifh, FILE *ofh); int64_t mp4tag_ftell (FILE *fh); int mp4tag_fseek (FILE *fh, int64_t offset, int whence); #ifdef _WIN32 -NODISCARD wchar_t * mp4tag_towide (const char *buff); -NODISCARD char * mp4tag_fromwide (const wchar_t *buff); +LIBMP4TAG_NODISCARD wchar_t * mp4tag_towide (const char *buff); +LIBMP4TAG_NODISCARD char * mp4tag_fromwide (const wchar_t *buff); #endif /* versioning */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/mp4tagfileop.c new/libmp4tag-2.0.4/mp4tagfileop.c --- old/libmp4tag-2.0.3/mp4tagfileop.c 2026-02-08 15:14:54.000000000 +0100 +++ new/libmp4tag-2.0.4/mp4tagfileop.c 2026-05-09 18:43:47.000000000 +0200 @@ -24,7 +24,7 @@ #include "libmp4tag.h" #include "mp4tagint.h" -NODISCARD +LIBMP4TAG_NODISCARD FILE * mp4tag_fopen (const char *fname, const char *mode) { @@ -51,7 +51,7 @@ return fh; } -NODISCARD +LIBMP4TAG_NODISCARD ssize_t mp4tag_file_size (const char *fname) { @@ -86,7 +86,7 @@ return sz; } -NODISCARD +LIBMP4TAG_NODISCARD char * mp4tag_read_file (const char *fn, size_t *sz, int *mp4error) { @@ -251,7 +251,7 @@ #ifdef _WIN32 -NODISCARD +LIBMP4TAG_NODISCARD wchar_t * mp4tag_towide (const char *buff) { @@ -268,7 +268,7 @@ return tbuff; } -NODISCARD +LIBMP4TAG_NODISCARD char * mp4tag_fromwide (const wchar_t *buff) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/mp4tagint.h new/libmp4tag-2.0.4/mp4tagint.h --- old/libmp4tag-2.0.3/mp4tagint.h 2026-02-08 14:43:53.000000000 +0100 +++ new/libmp4tag-2.0.4/mp4tagint.h 2026-05-09 18:43:47.000000000 +0200 @@ -206,7 +206,7 @@ /* mp4tagwrite.c */ -NODISCARD char * mp4tag_build_data (libmp4tag_t *libmp4tag, uint32_t *dlen); +LIBMP4TAG_NODISCARD char * mp4tag_build_data (libmp4tag_t *libmp4tag, uint32_t *dlen); int mp4tag_write_data (libmp4tag_t *libmp4tag, const char *data, uint32_t datalen); @@ -219,7 +219,7 @@ void mp4tag_sort_tags (libmp4tag_t *libmp4tag); int mp4tag_find_tag (libmp4tag_t *libmp4tag, const char *tag, int dataidx); int mp4tag_parse_tagname (char *tag, int *dataidx); -NODISCARD mp4tagdef_t *mp4tag_check_tag (const char *tag); +LIBMP4TAG_NODISCARD const mp4tagdef_t *mp4tag_check_tag (const char *tag); int mp4tag_compare (const void *a, const void *b); int mp4tag_compare_list (const void *a, const void *b); int mp4tag_add_tag (libmp4tag_t *libmp4tag, const char *tag, const char *data, ssize_t sz, uint32_t origflag, size_t origlen, const char *covername); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/mp4tagutil.c new/libmp4tag-2.0.4/mp4tagutil.c --- old/libmp4tag-2.0.3/mp4tagutil.c 2026-02-08 14:44:20.000000000 +0100 +++ new/libmp4tag-2.0.4/mp4tagutil.c 2026-05-09 19:28:09.000000000 +0200 @@ -93,9 +93,9 @@ int mp4tag_find_tag (libmp4tag_t *libmp4tag, const char *tag, int dataidx) { - mp4tag_t key; - mp4tag_t *result; - int idx = MP4TAG_NOTFOUND; + mp4tag_t key; + const mp4tag_t *result; + int idx = MP4TAG_NOTFOUND; if (libmp4tag == NULL || libmp4tag->libmp4tagident != MP4TAG_IDENT) { return -1; @@ -115,8 +115,8 @@ } key.tag = (char *) tag; key.dataidx = dataidx; - result = bsearch (&key, libmp4tag->tags, libmp4tag->tagcount, - sizeof (mp4tag_t), mp4tag_compare); + result = bsearch (&key, libmp4tag->tags, + libmp4tag->tagcount, sizeof (mp4tag_t), mp4tag_compare); if (result != NULL) { idx = result->idx; @@ -125,13 +125,13 @@ return idx; } -NODISCARD -mp4tagdef_t * +LIBMP4TAG_NODISCARD +const mp4tagdef_t * mp4tag_check_tag (const char *tag) { - mp4tagdef_t key; - mp4tagdef_t *result; - char tmp [MP4TAG_ID_DISP_LEN]; + mp4tagdef_t key; + const mp4tagdef_t *result; + char tmp [MP4TAG_ID_DISP_LEN]; if (tag == NULL) { return NULL; @@ -507,7 +507,7 @@ identtype = mp4tag_check_covr (tag, fn); mp4tag->identtype = identtype; } else { - mp4tagdef_t *tagdef = NULL; + const mp4tagdef_t *tagdef = NULL; bool ok = false; /* a new binary data tag */ @@ -706,9 +706,9 @@ static int mp4tag_check_covr (const char *tag, const char *fn) { - int identtype = MP4TAG_ID_DATA; - char *p; - char ext [10]; + int identtype = MP4TAG_ID_DATA; + const char *p; + char ext [10]; if (memcmp (tag, boxids [MP4TAG_COVR], MP4TAG_ID_LEN) != 0) { return identtype; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/mp4tagwrite.c new/libmp4tag-2.0.4/mp4tagwrite.c --- old/libmp4tag-2.0.3/mp4tagwrite.c 2026-02-08 14:44:13.000000000 +0100 +++ new/libmp4tag-2.0.4/mp4tagwrite.c 2026-05-09 18:43:47.000000000 +0200 @@ -36,7 +36,7 @@ static void mp4tag_debug_write_vals (libmp4tag_t *libmp4tag, uint32_t datalen, int32_t delta, int32_t totdelta, int32_t freelen); /* if there are no tags, null will be returned. */ -NODISCARD +LIBMP4TAG_NODISCARD char * mp4tag_build_data (libmp4tag_t *libmp4tag, uint32_t *datalen) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmp4tag-2.0.3/wiki/ChangeLog.txt new/libmp4tag-2.0.4/wiki/ChangeLog.txt --- old/libmp4tag-2.0.3/wiki/ChangeLog.txt 2026-02-08 15:01:30.000000000 +0100 +++ new/libmp4tag-2.0.4/wiki/ChangeLog.txt 2026-05-09 19:26:00.000000000 +0200 @@ -6,6 +6,11 @@ --> +**2.0.4 2026-5-9** + +* Bug Fixes: + * Fix warnings from modern compilers. + **2.0.3 2026-2-8** * Bug Fixes:
