Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-ntp-client for openSUSE:Factory checked in at 2021-05-07 16:44:52 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-ntp-client (Old) and /work/SRC/openSUSE:Factory/.yast2-ntp-client.new.2988 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ntp-client" Fri May 7 16:44:52 2021 rev:126 rq:890311 version:4.4.1 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-ntp-client/yast2-ntp-client.changes 2021-05-02 18:36:21.844884391 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-ntp-client.new.2988/yast2-ntp-client.changes 2021-05-07 16:44:57.148451858 +0200 @@ -1,0 +2,6 @@ +Tue May 4 10:22:49 UTC 2021 - Knut Anderssen <kanders...@suse.com> + +- Adapted proposal client returning the dhcp ntp servers as strings +- 4.4.1 (bsc#1185545) + +------------------------------------------------------------------- Old: ---- yast2-ntp-client-4.4.0.tar.bz2 New: ---- yast2-ntp-client-4.4.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-ntp-client.spec ++++++ --- /var/tmp/diff_new_pack.8Ek6Hb/_old 2021-05-07 16:44:57.572449905 +0200 +++ /var/tmp/diff_new_pack.8Ek6Hb/_new 2021-05-07 16:44:57.576449887 +0200 @@ -17,7 +17,7 @@ Name: yast2-ntp-client -Version: 4.4.0 +Version: 4.4.1 Release: 0 Summary: YaST2 - NTP Client Configuration License: GPL-2.0-or-later ++++++ yast2-ntp-client-4.4.0.tar.bz2 -> yast2-ntp-client-4.4.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.4.0/package/yast2-ntp-client.changes new/yast2-ntp-client-4.4.1/package/yast2-ntp-client.changes --- old/yast2-ntp-client-4.4.0/package/yast2-ntp-client.changes 2021-04-30 18:18:00.000000000 +0200 +++ new/yast2-ntp-client-4.4.1/package/yast2-ntp-client.changes 2021-05-04 12:50:26.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Tue May 4 10:22:49 UTC 2021 - Knut Anderssen <kanders...@suse.com> + +- Adapted proposal client returning the dhcp ntp servers as strings +- 4.4.1 (bsc#1185545) + +------------------------------------------------------------------- Tue Apr 20 13:51:55 UTC 2021 - Ladislav Slez??k <lsle...@suse.cz> - 4.4.0 (bsc#1185510) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.4.0/package/yast2-ntp-client.spec new/yast2-ntp-client-4.4.1/package/yast2-ntp-client.spec --- old/yast2-ntp-client-4.4.0/package/yast2-ntp-client.spec 2021-04-30 18:18:00.000000000 +0200 +++ new/yast2-ntp-client-4.4.1/package/yast2-ntp-client.spec 2021-05-04 12:50:26.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-ntp-client -Version: 4.4.0 +Version: 4.4.1 Release: 0 Summary: YaST2 - NTP Client Configuration License: GPL-2.0-or-later diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.4.0/src/clients/ntp-client_proposal.rb new/yast2-ntp-client-4.4.1/src/clients/ntp-client_proposal.rb --- old/yast2-ntp-client-4.4.0/src/clients/ntp-client_proposal.rb 2021-04-30 18:18:00.000000000 +0200 +++ new/yast2-ntp-client-4.4.1/src/clients/ntp-client_proposal.rb 2021-05-04 12:50:26.000000000 +0200 @@ -60,7 +60,7 @@ NtpClient.ntp_selected = Ops.get_boolean(@param, "ntp_used", false) @ret = true when "dhcp_ntp_servers" - @ret = NtpClient.dhcp_ntp_servers + @ret = NtpClient.dhcp_ntp_servers.map(&:hostname) when "MakeProposal" @ret = MakeProposal() when "Write" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.4.0/test/ntp_client_proposal_test.rb new/yast2-ntp-client-4.4.1/test/ntp_client_proposal_test.rb --- old/yast2-ntp-client-4.4.0/test/ntp_client_proposal_test.rb 2021-04-30 18:18:00.000000000 +0200 +++ new/yast2-ntp-client-4.4.1/test/ntp_client_proposal_test.rb 2021-05-04 12:50:26.000000000 +0200 @@ -13,15 +13,36 @@ client end + let(:dhcp_ntp_servers) { [] } + + before do + allow(Yast::Lan).to receive(:dhcp_ntp_servers) + .and_return(dhcp_ntp_servers) + end + + describe "#main" do + let(:client) { described_class.new } + let(:func) { "dhcp_ntp_servers" } + + before do + allow(Yast::WFM).to receive(:Args).with(no_args).and_return([func]) + allow(Yast::WFM).to receive(:Args).with(0).and_return(func) + end + + context "when call with 'dhcp_ntp_servers' argument" do + let(:dhcp_ntp_servers) { ["test.example.net", "test2.example.net"] } + + it "returns servers found via DHCP" do + expect(client.main).to eql(dhcp_ntp_servers) + end + end + end + describe "#MakeProposal" do - let(:dhcp_ntp_servers) { [] } let(:config_was_read?) { false } let(:ntp_was_selected?) { false } before do - allow(Yast::Lan).to receive(:dhcp_ntp_servers) - .and_return(dhcp_ntp_servers) - allow(Yast::NtpClient).to receive(:country_ntp_servers).with("de") .and_return([Y2Network::NtpServer.new("de.pool.ntp.org")]) allow(Yast::Timezone).to receive(:timezone).and_return("Europe/Berlin")